diff options
| author | Aaron Ballman <aaron@aaronballman.com> | 2025-01-10 08:48:34 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-01-10 08:48:34 -0500 |
| commit | 8876f169829dd3c8dfebcfe9652fb1059ce75325 (patch) | |
| tree | 5e9b615616ec8304fc144425a5c4b3e1351d9b93 | |
| parent | 7b0536794349734c8862fc140808e4e5a2ab8f8d (diff) | |
| download | llvm-revert-119403-users/paulhuggett/add-clang-xcode.zip llvm-revert-119403-users/paulhuggett/add-clang-xcode.tar.gz llvm-revert-119403-users/paulhuggett/add-clang-xcode.tar.bz2 | |
Revert "Fix a cmake error when using the Xcode generator. (#119403)"revert-119403-users/paulhuggett/add-clang-xcode
This reverts commit 1842a3d833d934793012c717e98b10d51193fd0d.
| -rw-r--r-- | clang/cmake/modules/AddClang.cmake | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/clang/cmake/modules/AddClang.cmake b/clang/cmake/modules/AddClang.cmake index cdc8bd5..091aec9 100644 --- a/clang/cmake/modules/AddClang.cmake +++ b/clang/cmake/modules/AddClang.cmake @@ -109,14 +109,13 @@ macro(add_clang_library name) llvm_add_library(${name} ${LIBTYPE} ${ARG_UNPARSED_ARGUMENTS} ${srcs}) if(MSVC AND NOT CLANG_LINK_CLANG_DYLIB) - # Make sure all consumers also turn off visibility macros so they're not - # trying to dllimport symbols. + # Make sure all consumers also turn off visibility macros so there not trying to dllimport symbols. target_compile_definitions(${name} PUBLIC CLANG_BUILD_STATIC) if(TARGET "obj.${name}") target_compile_definitions("obj.${name}" PUBLIC CLANG_BUILD_STATIC) endif() - elseif(TARGET "obj.${name}" AND NOT ARG_SHARED AND NOT ARG_STATIC) - # Clang component libraries linked to clang-cpp are declared without SHARED or STATIC + elseif(NOT ARG_SHARED AND NOT ARG_STATIC) + # Clang component libraries linked in to clang-cpp are declared without SHARED or STATIC target_compile_definitions("obj.${name}" PUBLIC CLANG_EXPORTS) endif() |