diff options
| author | Tom Stellard <tstellar@redhat.com> | 2023-11-22 13:57:48 -0800 |
|---|---|---|
| committer | Tobias Hieta <tobias@hieta.se> | 2023-11-24 08:42:42 +0100 |
| commit | e957e6dcb29d94e4e1678da9829b77009be88926 (patch) | |
| tree | 30a854d78a02d27f127db64b4f0b2a2c063d0d98 | |
| parent | f8575ff46f89e88c3e3a7f560bb2da77206f83b7 (diff) | |
| download | llvm-e957e6dcb29d94e4e1678da9829b77009be88926.zip llvm-e957e6dcb29d94e4e1678da9829b77009be88926.tar.gz llvm-e957e6dcb29d94e4e1678da9829b77009be88926.tar.bz2 | |
[runtimes] Add missing test dependencies to check-all (#72955)
The test-depends target contained all the dependencies needed to run the
runtimes tests, but it was never added as a dependency of check-all.
This caused some of the tsan tests to fail, since the custom libcxx
build the tests were looking for was never built. Besides the tsan
failures, this fixes all the other test failures I was seeing with:
cmake -G Ninja -B release-build -S llvm \
-DCMAKE_POSITION_INDEPENDENT_CODE=ON \
-DCMAKE_BUILD_TYPE=Release \
-DLLVM_ENABLE_ASSERTIONS=OFF \
-DLLVM_ENABLE_PROJECTS="clang;lld" \
-DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi;libunwind;compiler-rt"
This is the same configuration the test-release.sh script uses, so I'm
hoping this will also fix all the test failures we've been seeing when
building the releases.
Fixes #58680
(cherry picked from commit 7f215b1380da49dccbf57da3040a40d25ed898f4)
| -rw-r--r-- | llvm/CMakeLists.txt | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/llvm/CMakeLists.txt b/llvm/CMakeLists.txt index 79de9eb..be0fc6c 100644 --- a/llvm/CMakeLists.txt +++ b/llvm/CMakeLists.txt @@ -1215,6 +1215,7 @@ if( LLVM_INCLUDE_TESTS ) add_custom_target(test-depends DEPENDS ${LLVM_ALL_LIT_DEPENDS} ${LLVM_ALL_ADDITIONAL_TEST_DEPENDS}) set_target_properties(test-depends PROPERTIES FOLDER "Tests") + add_dependencies(check-all test-depends) endif() if (LLVM_INCLUDE_DOCS) |