From 85422c2acba83852396c9d9fd22ff0493e3606fe Mon Sep 17 00:00:00 2001 From: Joseph Myers Date: Mon, 2 Nov 2015 18:54:19 +0000 Subject: Make nextafter, nexttoward set errno (bug 6799). nextafter and nexttoward fail to set errno on overflow and underflow. This patch makes them do so in cases that should include all the cases where such errno setting is required by glibc's goals for when to set errno (but not all cases of underflow where the result is nonzero and so glibc's goals do not require errno setting). Tested for x86_64, x86, mips64 and powerpc. [BZ #6799] * math/s_nextafter.c: Include . (__nextafter): Set errno on overflow and underflow. * math/s_nexttowardf.c: Include . (__nexttowardf): Set errno on overflow and underflow. * sysdeps/i386/fpu/s_nextafterl.c: Include . (__nextafterl): Set errno on overflow and underflow. * sysdeps/i386/fpu/s_nexttoward.c: Include . (__nexttoward): Set errno on overflow and underflow. * sysdeps/i386/fpu/s_nexttowardf.c: Include . (__nexttowardf): Set errno on overflow and underflow. * sysdeps/ieee754/flt-32/s_nextafterf.c: Include . (__nextafterf): Set errno on overflow and underflow. * sysdeps/ieee754/ldbl-128/s_nextafterl.c: Include . (__nextafterl): Set errno on overflow and underflow. * sysdeps/ieee754/ldbl-128/s_nexttoward.c: Include . (__nexttoward): Set errno on overflow and underflow. * sysdeps/ieee754/ldbl-128/s_nexttowardf.c: Include . (__nexttowardf): Set errno on overflow and underflow. * sysdeps/ieee754/ldbl-128ibm/s_nextafterl.c: Include . (__nextafterl): Set errno on overflow and underflow. * sysdeps/ieee754/ldbl-128ibm/s_nexttoward.c: Include . (__nexttoward): Set errno on overflow and underflow. * sysdeps/ieee754/ldbl-128ibm/s_nexttowardf.c: Include . (__nexttowardf): Set errno on overflow and underflow. * sysdeps/ieee754/ldbl-96/s_nexttoward.c: Include . (__nexttoward): Set errno on overflow and underflow. * sysdeps/ieee754/ldbl-96/s_nexttowardf.c: Include . (__nexttowardf): Set errno on overflow and underflow. * sysdeps/ieee754/ldbl-opt/s_nexttowardfd.c: Include . (__nldbl_nexttowardf): Set errno on overflow and underflow. * sysdeps/m68k/m680x0/fpu/s_nextafterl.c: Include . (__nextafterl): Set errno on overflow and underflow. * math/libm-test.inc (nextafter_test_data): Do not allow errno setting to be missing on overflow. Add more tests. (nexttoward_test_data): Likewise. --- sysdeps/ieee754/flt-32/s_nextafterf.c | 3 +++ sysdeps/ieee754/ldbl-128/s_nextafterl.c | 3 +++ sysdeps/ieee754/ldbl-128/s_nexttoward.c | 3 +++ sysdeps/ieee754/ldbl-128/s_nexttowardf.c | 3 +++ sysdeps/ieee754/ldbl-128ibm/s_nextafterl.c | 5 +++++ sysdeps/ieee754/ldbl-128ibm/s_nexttoward.c | 3 +++ sysdeps/ieee754/ldbl-128ibm/s_nexttowardf.c | 3 +++ sysdeps/ieee754/ldbl-96/s_nexttoward.c | 3 +++ sysdeps/ieee754/ldbl-96/s_nexttowardf.c | 3 +++ sysdeps/ieee754/ldbl-opt/s_nexttowardfd.c | 3 +++ 10 files changed, 32 insertions(+) (limited to 'sysdeps/ieee754') diff --git a/sysdeps/ieee754/flt-32/s_nextafterf.c b/sysdeps/ieee754/flt-32/s_nextafterf.c index 22e0b3d..625d54b 100644 --- a/sysdeps/ieee754/flt-32/s_nextafterf.c +++ b/sysdeps/ieee754/flt-32/s_nextafterf.c @@ -17,6 +17,7 @@ static char rcsid[] = "$NetBSD: s_nextafterf.c,v 1.4 1995/05/10 20:48:01 jtc Exp $"; #endif +#include #include #include #include @@ -59,10 +60,12 @@ float __nextafterf(float x, float y) if(hy>=0x7f800000) { float u = x+x; /* overflow */ math_force_eval (u); + __set_errno (ERANGE); } if(hy<0x00800000) { float u = x*x; /* underflow */ math_force_eval (u); /* raise underflow flag */ + __set_errno (ERANGE); } SET_FLOAT_WORD(x,hx); return x; diff --git a/sysdeps/ieee754/ldbl-128/s_nextafterl.c b/sysdeps/ieee754/ldbl-128/s_nextafterl.c index d5eaa1c..4e9a2ce 100644 --- a/sysdeps/ieee754/ldbl-128/s_nextafterl.c +++ b/sysdeps/ieee754/ldbl-128/s_nextafterl.c @@ -24,6 +24,7 @@ static char rcsid[] = "$NetBSD: $"; * Special cases: */ +#include #include #include @@ -70,10 +71,12 @@ long double __nextafterl(long double x, long double y) if(hy==0x7fff000000000000LL) { long double u = x + x; /* overflow */ math_force_eval (u); + __set_errno (ERANGE); } if(hy==0) { long double u = x*x; /* underflow */ math_force_eval (u); /* raise underflow flag */ + __set_errno (ERANGE); } SET_LDOUBLE_WORDS64(x,hx,lx); return x; diff --git a/sysdeps/ieee754/ldbl-128/s_nexttoward.c b/sysdeps/ieee754/ldbl-128/s_nexttoward.c index 2ee7a1b..4343fe8 100644 --- a/sysdeps/ieee754/ldbl-128/s_nexttoward.c +++ b/sysdeps/ieee754/ldbl-128/s_nexttoward.c @@ -25,6 +25,7 @@ static char rcsid[] = "$NetBSD: $"; * Special cases: */ +#include #include #include #include @@ -75,10 +76,12 @@ double __nexttoward(double x, long double y) if(hy>=0x7ff00000) { double u = x+x; /* overflow */ math_force_eval (u); + __set_errno (ERANGE); } if(hy<0x00100000) { double u = x*x; /* underflow */ math_force_eval (u); /* raise underflow flag */ + __set_errno (ERANGE); } INSERT_WORDS(x,hx,lx); return x; diff --git a/sysdeps/ieee754/ldbl-128/s_nexttowardf.c b/sysdeps/ieee754/ldbl-128/s_nexttowardf.c index 9c9c7e5..8703359 100644 --- a/sysdeps/ieee754/ldbl-128/s_nexttowardf.c +++ b/sysdeps/ieee754/ldbl-128/s_nexttowardf.c @@ -18,6 +18,7 @@ static char rcsid[] = "$NetBSD: $"; #endif +#include #include #include @@ -62,10 +63,12 @@ float __nexttowardf(float x, long double y) if(hy>=0x7f800000) { float u = x+x; /* overflow */ math_force_eval (u); + __set_errno (ERANGE); } if(hy<0x00800000) { float u = x*x; /* underflow */ math_force_eval (u); /* raise underflow flag */ + __set_errno (ERANGE); } SET_FLOAT_WORD(x,hx); return x; diff --git a/sysdeps/ieee754/ldbl-128ibm/s_nextafterl.c b/sysdeps/ieee754/ldbl-128ibm/s_nextafterl.c index 36a5090..515aa1e 100644 --- a/sysdeps/ieee754/ldbl-128ibm/s_nextafterl.c +++ b/sysdeps/ieee754/ldbl-128ibm/s_nextafterl.c @@ -24,6 +24,7 @@ static char rcsid[] = "$NetBSD: $"; * Special cases: */ +#include #include #include #include @@ -69,6 +70,7 @@ long double __nextafterl(long double x, long double y) if((hx==0xffefffffffffffffLL)&&(lx==0xfc8ffffffffffffeLL)) { u = x+x; /* overflow, return -inf */ math_force_eval (u); + __set_errno (ERANGE); return y; } if (hx >= 0x7ff0000000000000LL) { @@ -83,6 +85,7 @@ long double __nextafterl(long double x, long double y) || (hx < 0 && lx > 1)) { u = u * u; math_force_eval (u); /* raise underflow flag */ + __set_errno (ERANGE); } return x; } @@ -108,6 +111,7 @@ long double __nextafterl(long double x, long double y) if((hx==0x7fefffffffffffffLL)&&(lx==0x7c8ffffffffffffeLL)) { u = x+x; /* overflow, return +inf */ math_force_eval (u); + __set_errno (ERANGE); return y; } if ((uint64_t) hx >= 0xfff0000000000000ULL) { @@ -122,6 +126,7 @@ long double __nextafterl(long double x, long double y) || (hx < 0 && lx >= 0)) { u = u * u; math_force_eval (u); /* raise underflow flag */ + __set_errno (ERANGE); } if (x == 0.0L) /* handle negative LDBL_TRUE_MIN case */ x = -0.0L; diff --git a/sysdeps/ieee754/ldbl-128ibm/s_nexttoward.c b/sysdeps/ieee754/ldbl-128ibm/s_nexttoward.c index 8c61198..d8f4fc6 100644 --- a/sysdeps/ieee754/ldbl-128ibm/s_nexttoward.c +++ b/sysdeps/ieee754/ldbl-128ibm/s_nexttoward.c @@ -25,6 +25,7 @@ static char rcsid[] = "$NetBSD: $"; * Special cases: */ +#include #include #include #include @@ -76,10 +77,12 @@ double __nexttoward(double x, long double y) if(hy>=0x7ff00000) { double u = x+x; /* overflow */ math_force_eval (u); + __set_errno (ERANGE); } if(hy<0x00100000) { double u = x*x; /* underflow */ math_force_eval (u); /* raise underflow flag */ + __set_errno (ERANGE); } INSERT_WORDS(x,hx,lx); return x; diff --git a/sysdeps/ieee754/ldbl-128ibm/s_nexttowardf.c b/sysdeps/ieee754/ldbl-128ibm/s_nexttowardf.c index 4000a93..7c5d1cc 100644 --- a/sysdeps/ieee754/ldbl-128ibm/s_nexttowardf.c +++ b/sysdeps/ieee754/ldbl-128ibm/s_nexttowardf.c @@ -18,6 +18,7 @@ static char rcsid[] = "$NetBSD: $"; #endif +#include #include #include #include @@ -65,10 +66,12 @@ float __nexttowardf(float x, long double y) if(hy>=0x7f800000) { float u = x+x; /* overflow */ math_force_eval (u); + __set_errno (ERANGE); } if(hy<0x00800000) { /* underflow */ float u = x*x; math_force_eval (u); /* raise underflow flag */ + __set_errno (ERANGE); } SET_FLOAT_WORD(x,hx); return x; diff --git a/sysdeps/ieee754/ldbl-96/s_nexttoward.c b/sysdeps/ieee754/ldbl-96/s_nexttoward.c index 7908f9c..3d0382e 100644 --- a/sysdeps/ieee754/ldbl-96/s_nexttoward.c +++ b/sysdeps/ieee754/ldbl-96/s_nexttoward.c @@ -25,6 +25,7 @@ static char rcsid[] = "$NetBSD: $"; * Special cases: */ +#include #include #include #include @@ -72,10 +73,12 @@ double __nexttoward(double x, long double y) if(hy>=0x7ff00000) { double u = x+x; /* overflow */ math_force_eval (u); + __set_errno (ERANGE); } if(hy<0x00100000) { double u = x*x; /* underflow */ math_force_eval (u); /* raise underflow flag */ + __set_errno (ERANGE); } INSERT_WORDS(x,hx,lx); return x; diff --git a/sysdeps/ieee754/ldbl-96/s_nexttowardf.c b/sysdeps/ieee754/ldbl-96/s_nexttowardf.c index 53c527d..ae75389 100644 --- a/sysdeps/ieee754/ldbl-96/s_nexttowardf.c +++ b/sysdeps/ieee754/ldbl-96/s_nexttowardf.c @@ -17,6 +17,7 @@ static char rcsid[] = "$NetBSD: $"; #endif +#include #include #include #include @@ -60,10 +61,12 @@ float __nexttowardf(float x, long double y) if(hy>=0x7f800000) { float u = x+x; /* overflow */ math_force_eval (u); + __set_errno (ERANGE); } if(hy<0x00800000) { float u = x*x; /* underflow */ math_force_eval (u); /* raise underflow flag */ + __set_errno (ERANGE); } SET_FLOAT_WORD(x,hx); return x; diff --git a/sysdeps/ieee754/ldbl-opt/s_nexttowardfd.c b/sysdeps/ieee754/ldbl-opt/s_nexttowardfd.c index dbcf840..07e9375 100644 --- a/sysdeps/ieee754/ldbl-opt/s_nexttowardfd.c +++ b/sysdeps/ieee754/ldbl-opt/s_nexttowardfd.c @@ -20,6 +20,7 @@ * Special cases: */ +#include #include #include #include @@ -64,10 +65,12 @@ float __nldbl_nexttowardf(float x, double y) if(hy>=0x7f800000) { float u = x+x; /* overflow */ math_force_eval (u); + __set_errno (ERANGE); } if(hy<0x00800000) { float u = x*x; /* underflow */ math_force_eval (u); /* raise underflow flag */ + __set_errno (ERANGE); } SET_FLOAT_WORD(x,hx); return x; -- cgit v1.1