From a059f9505bbef1f22c6f52798a74184632929145 Mon Sep 17 00:00:00 2001 From: DJ Delorie Date: Fri, 13 Dec 2019 13:36:58 -0500 Subject: tunables: report sbrk() failure Reviewed-by: Carlos O'Donell --- elf/dl-tunables.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'elf') diff --git a/elf/dl-tunables.c b/elf/dl-tunables.c index e625ac1..f0d7d42 100644 --- a/elf/dl-tunables.c +++ b/elf/dl-tunables.c @@ -45,12 +45,11 @@ tunables_strdup (const char *in) while (in[i++] != '\0'); char *out = __sbrk (i); - /* FIXME: In reality if the allocation fails, __sbrk will crash attempting to - set the thread-local errno since the TCB has not yet been set up. This - needs to be fixed with an __sbrk implementation that does not set - errno. */ + /* For most of the tunables code, we ignore user errors. However, + this is a system error - and running out of memory at program + startup should be reported, so we do. */ if (out == (void *)-1) - return NULL; + _dl_fatal_printf ("sbrk() failure while processing tunables\n"); i--; -- cgit v1.1