From 206a6699116215c591c8562c67106f7e17146608 Mon Sep 17 00:00:00 2001 From: Siddhesh Poyarekar Date: Mon, 15 Apr 2013 13:52:26 +0530 Subject: Write to bench.out-tmp only once Appending benchmark program output on every run could result in a case where the benchmark run was cancelled, resulting in a partially written file. This file gets used again on the next run, resulting in results being appended to old results. It could have been possible to remove the file before every benchmark run, but it is easier to just write the output to bench.out-tmp only once. --- benchtests/Makefile | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'benchtests') diff --git a/benchtests/Makefile b/benchtests/Makefile index 3e794d7..bd0925b 100644 --- a/benchtests/Makefile +++ b/benchtests/Makefile @@ -121,10 +121,10 @@ run-bench = $(test-wrapper-env) \ $($*-ENV) $(rtld-prefix) $${run} bench: $(binaries-bench) - for run in $^; do \ - echo "Running $${run}"; \ - $(run-bench) >> $(objpfx)bench.out-tmp; \ - done; \ + { for run in $^; do \ + echo "Running $${run}" >&2; \ + $(run-bench); \ + done; } > $(objpfx)bench.out-tmp; \ if [ -f $(objpfx)bench.out ]; then \ mv -f $(objpfx)bench.out $(objpfx)bench.out.old; \ fi; \ -- cgit v1.1