aboutsummaryrefslogtreecommitdiff
path: root/nptl
AgeCommit message (Collapse)AuthorFilesLines
2013-10-05nptl: tst-mutex8.c: Handle ENOTSUP PI mutex failureMaciej W. Rozycki2-2/+15
2013-10-04PowerPC LE configuryAlan Modra1-0/+1
http://sourceware.org/ml/libc-alpha/2013-08/msg00096.html This adds the basic configury bits for powerpc64le and powerpcle. * configure.in: Map powerpc64le and powerpcle to base_machine/machine. * configure: Regenerate. * nptl/shlib-versions: Powerpc*le starts at 2.18. * shlib-versions: Likewise.
2013-10-04PowerPC ugly symbol versioningAlan Modra1-9/+4
http://sourceware.org/ml/libc-alpha/2013-08/msg00090.html This patch fixes symbol versioning in setjmp/longjmp. The existing code uses raw versions, which results in wrong symbol versioning when you want to build glibc with a base version of 2.19 for LE. Note that the merging the 64-bit and 32-bit versions in novmx-lonjmp.c and pt-longjmp.c doesn't result in GLIBC_2.0 versions for 64-bit, due to the base in shlib_versions. * sysdeps/powerpc/longjmp.c: Use proper symbol versioning macros. * sysdeps/powerpc/novmx-longjmp.c: Likewise. * sysdeps/powerpc/powerpc32/bsd-_setjmp.S: Likewise. * sysdeps/powerpc/powerpc32/bsd-setjmp.S: Likewise. * sysdeps/powerpc/powerpc32/fpu/__longjmp.S: Likewise. * sysdeps/powerpc/powerpc32/fpu/setjmp.S: Likewise. * sysdeps/powerpc/powerpc32/mcount.c: Likewise. * sysdeps/powerpc/powerpc32/setjmp.S: Likewise. * sysdeps/powerpc/powerpc64/setjmp.S: Likewise. * nptl/sysdeps/unix/sysv/linux/powerpc/pt-longjmp.c: Likewise.
2013-10-01Fix PI mutex check in pthread_cond_broadcast and pthread_cond_signalSiddhesh Poyarekar3-10/+11
Fixes BZ #15988. The check had a typo - it checked for PTHREAD_MUTEX_ROBUST_NP instead of PTHREAD_MUTEX_ROBUST_NORMAL_NP. It has now been replaced by the already existing convenience macro USE_REQUEUE_PI.
2013-09-27Move ChangeLog entrySiddhesh Poyarekar1-0/+8
2013-09-27Use the mutex member of the argumen in __libc_lock_*_recursiveSiddhesh Poyarekar1-3/+3
2013-09-04Remove --disable-versioning.Joseph Myers2-1/+7
2013-09-03Mark success return value as volatile to work around reschedulingSiddhesh Poyarekar2-1/+13
Resolves #15921 The test case nptl/tst-cleanup2 fails on s390x and power6 due to instruction sheduling in gcc. This was reported in gcc: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58034 but it was concluded that gcc is allowed to assume that the first argument to sprintf is a character array - NULL not being a valid character array.
2013-08-30Fix typos.Ondřej Bílka4-4/+10
2013-08-21Fix typos.Ondřej Bílka3-2/+7
2013-07-23Remove Linux kernel version ambiguity in comment added by previous commit.David S. Miller2-2/+6
* tst-cancel4.c (WRITE_BUFFER_SIZE): Adjust comment.
2013-07-23Increase nptl test case buffer size so we really block on current Linux kernels.David S. Miller2-1/+28
* tst-cancel4.c (WRITE_BUFFER_SIZE): Increase to 16384.
2013-07-19Clean up whitespace in lock elision patches.Dominik Vogt15-31/+52
Signed-off-by: Carlos O'Donell <carlos@redhat.com>
2013-07-19Remove remains of rwlock elision which is not implemented yet.Dominik Vogt3-11/+8
Signed-off-by: Carlos O'Donell <carlos@redhat.com> --- nptl/ 2013-07-19 Dominik Vogt <vogt@de.ibm.com> * sysdeps/unix/sysv/linux/x86/elision-conf.c: Remove __rwlock_rtm_enabled and __rwlock_rtm_read_retries. (elision_init): Don't set __rwlock_rtm_enabled. * sysdeps/unix/sysv/linux/x86/elision-conf.h: Remove __rwlock_rtm_enabled.
2013-07-03Add x86 init-arch to nptlH.J. Lu3-0/+7
2013-07-02Add a configure option to enable lock elision and disable by defaultAndi Kleen2-0/+8
Can be enabled with --enable-lock-elision=yes at configure time.
2013-07-02Disable elision for any pthread_mutexattr_settype callAndi Kleen2-0/+10
PTHREAD_MUTEX_NORMAL requires deadlock for nesting, DEFAULT does not. Since glibc uses the same value (0) disable elision for any call to pthread_mutexattr_settype() with a 0 value. This implies that a program can disable elision by doing pthread_mutexattr_settype(&attr, PTHREAD_MUTEX_NORMAL) Based on a original proposal by Rich Felker.
2013-07-02Add elision to pthread_mutex_{try,timed,un}lockAndi Kleen14-24/+267
Add elision paths to the basic mutex locks. The normal path has a check for RTM and upgrades the lock to RTM when available. Trylocks cannot automatically upgrade, so they check for elision every time. We use a 4 byte value in the mutex to store the lock elision adaptation state. This is separate from the adaptive spin state and uses a separate field. Condition variables currently do not support elision. Recursive mutexes and condition variables may be supported at some point, but are not in the current implementation. Also "trylock" will not automatically enable elision unless some other lock call has been already called on the lock. This version does not use IFUNC, so it means every lock has one additional check for elision. Benchmarking showed the overhead to be negligible.
2013-07-02Add minimal test suite changes for elision enabled kernelsAndi Kleen3-1/+28
tst-mutex5 and 8 test some behaviour not required by POSIX, that elision changes. This changes these tests to not check this when elision is enabled at configure time.
2013-07-02Add new internal mutex type flags for elision.Andi Kleen3-9/+43
Add Enable/disable flags used internally Extend the mutex initializers to have the fields needed for elision. The layout stays the same, and this is not visible to programs. These changes are not exposed outside pthread
2013-07-02Add the low level infrastructure for pthreads lock elision with TSXAndi Kleen12-0/+502
Lock elision using TSX is a technique to optimize lock scaling It allows to run locks in parallel using hardware support for a transactional execution mode in 4th generation Intel Core CPUs. See http://www.intel.com/software/tsx for more Information. This patch implements a simple adaptive lock elision algorithm based on RTM. It enables elision for the pthread mutexes and rwlocks. The algorithm keeps track whether a mutex successfully elides or not, and stops eliding for some time when it is not. When the CPU supports RTM the elision path is automatically tried, otherwise any elision is disabled. The adaptation algorithm and its tuning is currently preliminary. The code adds some checks to the lock fast paths. Micro-benchmarks show little to no difference without RTM. This patch implements the low level "lll_" code for lock elision. Followon patches hook this into the pthread implementation Changes with the RTM mutexes: ----------------------------- Lock elision in pthreads is generally compatible with existing programs. There are some obscure exceptions, which are expected to be uncommon. See the manual for more details. - A broken program that unlocks a free lock will crash. There are ways around this with some tradeoffs (more code in hot paths) I'm still undecided on what approach to take here; have to wait for testing reports. - pthread_mutex_destroy of a lock mutex will not return EBUSY but 0. - There's also a similar situation with trylock outside the mutex, "knowing" that the mutex must be held due to some other condition. In this case an assert failure cannot be recovered. This situation is usually an existing bug in the program. - Same applies to the rwlocks. Some of the return values changes (for example there is no EDEADLK for an elided lock, unless it aborts. However when elided it will also never deadlock of course) - Timing changes, so broken programs that make assumptions about specific timing may expose already existing latent problems. Note that these broken programs will break in other situations too (loaded system, new faster hardware, compiler optimizations etc.) - Programs with non recursive mutexes that take them recursively in a thread and which would always deadlock without elision may not always see a deadlock. The deadlock will only happen on an early or delayed abort (which typically happens at some point) This only happens for mutexes not explicitely set to PTHREAD_MUTEX_NORMAL or PTHREAD_MUTEX_ADAPTIVE_NP. PTHREAD_MUTEX_NORMAL mutexes do not elide. The elision default can be set at configure time. This patch implements the basic infrastructure for elision.
2013-06-24BZ #12310: pthread_exit in static app. segfaultsVladimir Nikulichev2-0/+9
Static applications that call pthread_exit on the main thread segfault. This is because after a thread terminates __libc_start_main decrements __nptl_nthreads which is only defined in pthread_create. Therefore the right solution is to add a requirement to pthread_create from pthread_exit. ~~~ nptl/ 2013-06-24 Vladimir Nikulichev <v.nikulichev@gmail.com> [BZ #12310] * pthread_exit.c: Add reference to pthread_create.
2013-06-22Include <string.h> in nptl/pthread_setattr_default_np.c.Joseph Myers2-0/+5
2013-06-17PowerPC: Reserve TCB space for EBB frameworkAdhemerval Zanella1-0/+5
This patch reserves four pointer to be used in future Event-Based Branch framework for PowerPC.
2013-06-15New API to set default thread attributesSiddhesh Poyarekar13-13/+643
This patch introduces two new convenience functions to set the default thread attributes used for creating threads. This allows a programmer to set the default thread attributes just once in a process and then run pthread_create without additional attributes.
2013-06-14Avoid access beyond memory bounds in pthread_attr_getaffinity_npSiddhesh Poyarekar4-1/+80
Resolves BZ #15618. pthread_attr_getaffinity_np may write beyond bounds of the input cpuset buffer if the size of the input buffer is smaller than the buffer present in the input pthread attributes. Fix is to copy to the extent of the minimum of the source and the destination.
2013-06-10x86*: Return syscall error for lll_futex_wake.Carlos O'Donell3-8/+17
It is very very possible that the futex syscall returns an error and that the caller of lll_futex_wake may want to look at that error and propagate the failure. This patch allows a caller to see the syscall error. There are no users of the syscall error at present, but future cleanups are now be able to check for the error. -- nplt/ 2013-06-10 Carlos O'Donell <carlos@redhat.com> * sysdeps/unix/sysv/linux/i386/lowlevellock.h (lll_futex_wake): Return syscall error. * sysdeps/unix/sysv/linux/x86_64/lowlevellock.h (lll_futex_wake): Return syscall error.
2013-06-08Fix previous commit.Ondrej Bilka1-2/+2
2013-06-08Silence warning: __inline is not at beginning of declaration.Ondrej Bilka2-1/+5
2013-06-06Fix leading whitespaces.Ondrej Bilka3-3/+8
2013-06-06Remove trailing whitespace in nptl.Joseph Myers15-49/+67
2013-05-31Link extra-libs consistently with libc and ld.so.Joseph Myers2-8/+5
2013-05-16Add #include <stdint.h> for uint[32|64]_t usage (except installed headers).Ryan S. Arnold3-0/+8
2013-05-15Reserve new TLS field for x86 and x86_64Andreas Jaeger3-2/+12
[BZ #10686] * sysdeps/x86_64/tls.h (struct tcbhead_t): Add __private_ss field. * sysdeps/i386/tls.h (struct tcbhead_t): Likewise.
2013-05-09Fix tst-mutexpi8Andi Kleen2-0/+18
2013-05-09 Andi Kleen <ak@linux.intel.com> * tst-mutex8.c (do_test): Check for ENABLE_PI.
2013-04-22Consolidate pthread_attr value validationSiddhesh Poyarekar7-29/+98
Define inline functions that wrap around validation for each of the pthread attributes to reduce duplication in code.
2013-04-11Extend i486 pthread_cond_timedwait to use futex syscall with absolute timeoutAndreas Schwab2-66/+321
2013-04-07sem_post.c: Include atomic.h.Carlos O'Donell2-0/+5
The sem_post.c file uses atomic functions without including atomic.h. Add `#include <atomic.h>' to the file to prevent any compile time warnings when other headers change and atomic.h isn't implicitly included. --- nptl/ 2013-04-07 Carlos O'Donell <carlos@redhat.com> * sysdeps/unix/sysv/linux/sem_post.c: Include atomic.h.
2013-04-04Fix static build when configured with --disable-hidden-pltSiddhesh Poyarekar2-1/+9
Fixes BZ #15337. Static builds fail with the following warning: /home/tools/glibc/glibc/nptl/../nptl/sysdeps/unix/sysv/linux/x86_64/cancellation.S:80: undefined reference to `__GI___pthread_unwind' When the source is configured with --disable-hidden-plt. This is because the preprocessor conditional in cancellation.S only checks if the build is for SHARED, whereas hidden_def is defined appropriately only for a SHARED build that will have symbol versioning *and* hidden defs are enabled. The last case is false here.
2013-03-28Avoid unconditional __call_tls_dtors calls in static linking.Roland McGrath2-1/+9
2013-03-19Fix up ChangeLogSiddhesh Poyarekar1-6/+6
I forgot to fix up the ChangeLog after renaming __default_attr to __default_pthread_attr in code.
2013-03-19Move __default_stacksize into __default_pthread_attrSiddhesh Poyarekar7-22/+26
Make __default_pthread_attr object to store default attribute values for threads.
2013-03-18Rename some static variablesSiddhesh Poyarekar4-6/+19
Rename some static variables to give them unique names.
2013-03-12Include atomic.h in generic lowlevellock.c.Carlos O'Donell2-1/+5
2013-03-04Rejigger i386 dl-sysdep.h files.Roland McGrath3-50/+44
2013-03-01Revert GLIBC_PTHREAD_DEFAULT_STACKSIZE changes.Carlos O'Donell4-133/+31
This reverts the change that allows the POSIX Thread default stack size to be changed by the environment variable GLIBC_PTHREAD_DEFAULT_STACKSIZE. It has been requested that more discussion happen before this change goes into 2.18.
2013-03-01Fix build warningSiddhesh Poyarekar2-0/+3
2013-03-01Set default stack size from program environmentSiddhesh Poyarekar4-23/+142
New environment variable GLIBC_PTHREAD_DEFAULT_STACKSIZE to do this.
2013-02-21Add priority inheritance futex support on sparc.David S. Miller2-0/+39
* sysdeps/unix/sysv/linux/sparc/lowlevellock.h (FUTEX_WAIT_REQUEUE_PI): Define. (FUTEX_CMP_REQUEUE_PI): Likewise. (lll_futex_wait_requeue_pi): Likewise. (lll_futex_timed_wait_requeue_pi): Likewise. (lll_futex_cmp_requeue_pi): Likewise.
2013-02-21nptl: Fix comment typo in fork.c.Carlos O'Donell2-1/+5
generated by cgit v1.1 at 2024-12-02 10:09:55 +0000