diff options
author | Ulrich Drepper <drepper@gmail.com> | 2011-12-17 21:27:25 -0500 |
---|---|---|
committer | Ulrich Drepper <drepper@gmail.com> | 2011-12-17 21:27:25 -0500 |
commit | a4647e727a2a52e1259474c13f4b13288938bed4 (patch) | |
tree | 7ba90ac2c88a39659951e43855a26d7b02af6596 /stdio-common | |
parent | f0b264f17458b2289a7354fb606fbdfca58826fb (diff) | |
download | glibc-a4647e727a2a52e1259474c13f4b13288938bed4.zip glibc-a4647e727a2a52e1259474c13f4b13288938bed4.tar.gz glibc-a4647e727a2a52e1259474c13f4b13288938bed4.tar.bz2 |
Fix extension of array in extended printf format handling
Diffstat (limited to 'stdio-common')
-rw-r--r-- | stdio-common/vfprintf.c | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/stdio-common/vfprintf.c b/stdio-common/vfprintf.c index 753a5ac..952886b 100644 --- a/stdio-common/vfprintf.c +++ b/stdio-common/vfprintf.c @@ -1640,9 +1640,9 @@ do_positional: /* Array with information about the needed arguments. This has to be dynamically extensible. */ size_t nspecs = 0; - size_t nspecs_max = 32; /* A more or less arbitrary start value. */ - struct printf_spec *specs - = alloca (nspecs_max * sizeof (struct printf_spec)); + /* A more or less arbitrary start value. */ + size_t nspecs_size = 32 * sizeof (struct printf_spec); + struct printf_spec *specs = alloca (nspecs_size); /* The number of arguments the format string requests. This will determine the size of the array needed to store the argument @@ -1679,15 +1679,14 @@ do_positional: for (f = lead_str_end; *f != L_('\0'); f = specs[nspecs++].next_fmt) { - if (nspecs >= nspecs_max) + if (nspecs * sizeof (*specs) >= nspecs_size) { /* Extend the array of format specifiers. */ struct printf_spec *old = specs; - specs = extend_alloca (specs, nspecs_max, - 2 * nspecs_max * sizeof (*specs)); + specs = extend_alloca (specs, nspecs_size, 2 * nspecs_size); /* Copy the old array's elements to the new space. */ - memmove (specs, old, nspecs * sizeof (struct printf_spec)); + memmove (specs, old, nspecs * sizeof (*specs)); } /* Parse the format specifier. */ |