diff options
| author | Carlos O'Donell <carlos@systemhalted.org> | 2015-10-08 16:34:53 -0400 |
|---|---|---|
| committer | Mike Frysinger <vapier@gentoo.org> | 2016-01-24 03:47:33 -0500 |
| commit | d717c3fd0e1a5bf9a2fdb61234363ce805fcc148 (patch) | |
| tree | ef97b56d93d9a18d3a47d6f4f533cc978102f75e /signal | |
| parent | 68baefe5b845e0a035ccc393d32a128542ea837b (diff) | |
| download | glibc-d717c3fd0e1a5bf9a2fdb61234363ce805fcc148.zip glibc-d717c3fd0e1a5bf9a2fdb61234363ce805fcc148.tar.gz glibc-d717c3fd0e1a5bf9a2fdb61234363ce805fcc148.tar.bz2 | |
strcoll: Remove incorrect STRDIFF-based optimization (Bug 18589).
The optimization introduced in commit
f13c2a8dff2329c6692a80176262ceaaf8a6f74e, causes regressions in
sorting for languages that have digraphs that change sort order, like
cs_CZ which sorts ch between h and i.
My analysis shows the fast-forwarding optimization in STRCOLL advances
through a digraph while possibly stopping in the middle which results
in a subsequent skipping of the digraph and incorrect sorting. The
optimization is incorrect as implemented and because of that I'm
removing it for 2.23, and I will also commit this fix for 2.22 where
it was originally introduced.
This patch reverts the optimization, introduces a new bug-strcoll2.c
regression test that tests both cs_CZ.UTF-8 and da_DK.ISO-8859-1 and
ensures they sort one digraph each correctly. The optimization can't be
applied without regressing this test.
Checked on x86_64, bug-strcoll2.c fails without this patch and passes
after. This will also get a fix on 2.22 which has the same bug.
(cherry picked from commit 87701a58e291bd7ac3b407d10a829dac52c9c16e)
(cherry picked from commit 6c84109cfa26f35c3dfed3acb97d347361bd5849)
Diffstat (limited to 'signal')
0 files changed, 0 insertions, 0 deletions