aboutsummaryrefslogtreecommitdiff
path: root/resolv
diff options
context:
space:
mode:
authorFlorian Weimer <fweimer@redhat.com>2016-03-29 12:57:56 +0200
committerAurelien Jarno <aurelien@aurel32.net>2016-04-27 13:14:47 +0200
commita02f3e795993ae0f80242b488061b74666605625 (patch)
treed6cbf988020876fc0a82dca73a9265fdb3be9242 /resolv
parent78c76f7374df7f3caff43840a01247bb7d25597e (diff)
downloadglibc-a02f3e795993ae0f80242b488061b74666605625.zip
glibc-a02f3e795993ae0f80242b488061b74666605625.tar.gz
glibc-a02f3e795993ae0f80242b488061b74666605625.tar.bz2
CVE-2016-3075: Stack overflow in _nss_dns_getnetbyname_r [BZ #19879]
The defensive copy is not needed because the name may not alias the output buffer. (cherry picked from commit 317b199b4aff8cfa27f2302ab404d2bb5032b9a4)
Diffstat (limited to 'resolv')
-rw-r--r--resolv/nss_dns/dns-network.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/resolv/nss_dns/dns-network.c b/resolv/nss_dns/dns-network.c
index 13ad38c..37de664 100644
--- a/resolv/nss_dns/dns-network.c
+++ b/resolv/nss_dns/dns-network.c
@@ -118,17 +118,14 @@ _nss_dns_getnetbyname_r (const char *name, struct netent *result,
} net_buffer;
querybuf *orig_net_buffer;
int anslen;
- char *qbuf;
enum nss_status status;
if (__res_maybe_init (&_res, 0) == -1)
return NSS_STATUS_UNAVAIL;
- qbuf = strdupa (name);
-
net_buffer.buf = orig_net_buffer = (querybuf *) alloca (1024);
- anslen = __libc_res_nsearch (&_res, qbuf, C_IN, T_PTR, net_buffer.buf->buf,
+ anslen = __libc_res_nsearch (&_res, name, C_IN, T_PTR, net_buffer.buf->buf,
1024, &net_buffer.ptr, NULL, NULL, NULL, NULL);
if (anslen < 0)
{