diff options
| author | Adhemerval Zanella <adhemerval.zanella@linaro.org> | 2020-05-14 17:02:38 -0300 |
|---|---|---|
| committer | Adhemerval Zanella <adhemerval.zanella@linaro.org> | 2020-07-07 14:10:58 -0300 |
| commit | 9deec7c8bab24659e78172dd850f4ca37c57940c (patch) | |
| tree | e55e909e60b9995054203a428c394d27862620d5 /nptl/allocatestack.c | |
| parent | f26d456b98abf02b3ff92f1a3c0d4473b7ffd85c (diff) | |
| download | glibc-9deec7c8bab24659e78172dd850f4ca37c57940c.zip glibc-9deec7c8bab24659e78172dd850f4ca37c57940c.tar.gz glibc-9deec7c8bab24659e78172dd850f4ca37c57940c.tar.bz2 | |
string: Remove old TLS usage on strsignal
The per-thread state is refactored two use two strategies:
1. The default one uses a TLS structure, which will be placed in the
static TLS space (using __thread keyword).
2. Linux allocates via struct pthread and access it through THREAD_*
macros.
The default strategy has the disadvantage of increasing libc.so static
TLS consumption and thus decreasing the possible surplus used in
some scenarios (which might be mitigated by BZ#25051 fix).
It is used only on Hurd, where accessing the thread storage in the in
single thread case is not straightforward (afaiu, Hurd developers could
correct me here).
The fallback static allocation used for allocation failure is also
removed: defining its size is problematic without synchronizing with
translated messages (to avoid partial translation) and the resulting
usage is not thread-safe.
Checked on x86-64-linux-gnu, i686-linux-gnu, powerpc64le-linux-gnu,
and s390x-linux-gnu.
Tested-by: Carlos O'Donell <carlos@redhat.com>
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Diffstat (limited to 'nptl/allocatestack.c')
| -rw-r--r-- | nptl/allocatestack.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/nptl/allocatestack.c b/nptl/allocatestack.c index d16f3d7..4ae4b5a 100644 --- a/nptl/allocatestack.c +++ b/nptl/allocatestack.c @@ -237,6 +237,8 @@ get_cached_stack (size_t *sizep, void **memp) /* No pending event. */ result->nextevent = NULL; + result->tls_state = (struct tls_internal_t) { 0 }; + /* Clear the DTV. */ dtv_t *dtv = GET_DTV (TLS_TPADJ (result)); for (size_t cnt = 0; cnt < dtv[-1].counter; ++cnt) |