aboutsummaryrefslogtreecommitdiff
path: root/misc/Makefile
diff options
context:
space:
mode:
authorMike Frysinger <vapier@gentoo.org>2015-08-28 17:08:49 -0400
committerMike Frysinger <vapier@gentoo.org>2015-08-29 18:07:00 -0400
commitb0e805fa0d6fea33745952df7b7f5442ca4c374f (patch)
tree1912c70048e9a9a4a48681f37d0dd692265cd693 /misc/Makefile
parent30da407eca459329e060d0412c3fa6710f657e83 (diff)
downloadglibc-b0e805fa0d6fea33745952df7b7f5442ca4c374f.zip
glibc-b0e805fa0d6fea33745952df7b7f5442ca4c374f.tar.gz
glibc-b0e805fa0d6fea33745952df7b7f5442ca4c374f.tar.bz2
getmntent: fix memory corruption w/blank lines [BZ #18887]
The fix for BZ #17273 introduced a single byte of memory corruption when the line is entirely blank. It would walk back past the start of the buffer if the heap happened to be 0x20 or 0x09 and then write a NUL byte. buffer = '\n'; end_ptr = buffer; while (end_ptr[-1] == ' ' || end_ptr[-1] == '\t') end_ptr--; *end_ptr = '\0'; Fix that and rework the tests. Adding the testcase for BZ #17273 to the existing \040 parser does not really make sense as it's unrelated, and leads to confusing behavior: it implicitly relies on the new entry being longer than the previous entry (since it just rewinds the FILE*). Split it out into its own dedicated testcase instead.
Diffstat (limited to 'misc/Makefile')
-rw-r--r--misc/Makefile3
1 files changed, 2 insertions, 1 deletions
diff --git a/misc/Makefile b/misc/Makefile
index aecb0da..2f5edf6 100644
--- a/misc/Makefile
+++ b/misc/Makefile
@@ -76,7 +76,8 @@ install-lib := libg.a
gpl2lgpl := error.c error.h
tests := tst-dirname tst-tsearch tst-fdset tst-efgcvt tst-mntent tst-hsearch \
- tst-error1 tst-pselect tst-insremque tst-mntent2 bug-hsearch1
+ tst-error1 tst-pselect tst-insremque tst-mntent2 bug-hsearch1 \
+ tst-mntent-blank-corrupt tst-mntent-blank-passno
ifeq ($(run-built-tests),yes)
tests-special += $(objpfx)tst-error1-mem.out
endif