diff options
author | Joseph Myers <joseph@codesourcery.com> | 2019-02-04 23:46:58 +0000 |
---|---|---|
committer | Joseph Myers <joseph@codesourcery.com> | 2019-02-04 23:46:58 +0000 |
commit | 77dc0d8643aa99c92bf671352b0a8adde705896f (patch) | |
tree | b923a316fb159a97d39d38ec39d6c72d4f1a53c1 /malloc | |
parent | 7a0dcfc6439cd4e19bf393c2e2347e385361a82c (diff) | |
download | glibc-77dc0d8643aa99c92bf671352b0a8adde705896f.zip glibc-77dc0d8643aa99c92bf671352b0a8adde705896f.tar.gz glibc-77dc0d8643aa99c92bf671352b0a8adde705896f.tar.bz2 |
Fix assertion in malloc.c:tcache_get.
One of the warnings that appears with -Wextra is "ordered comparison
of pointer with integer zero" in malloc.c:tcache_get, for the
assertion:
assert (tcache->entries[tc_idx] > 0);
Indeed, a "> 0" comparison does not make sense for
tcache->entries[tc_idx], which is a pointer. My guess is that
tcache->counts[tc_idx] is what's intended here, and this patch changes
the assertion accordingly.
Tested for x86_64.
* malloc/malloc.c (tcache_get): Compare tcache->counts[tc_idx]
with 0, not tcache->entries[tc_idx].
Diffstat (limited to 'malloc')
-rw-r--r-- | malloc/malloc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/malloc/malloc.c b/malloc/malloc.c index feaf7ee..13fc1f2 100644 --- a/malloc/malloc.c +++ b/malloc/malloc.c @@ -2946,7 +2946,7 @@ tcache_get (size_t tc_idx) { tcache_entry *e = tcache->entries[tc_idx]; assert (tc_idx < TCACHE_MAX_BINS); - assert (tcache->entries[tc_idx] > 0); + assert (tcache->counts[tc_idx] > 0); tcache->entries[tc_idx] = e->next; --(tcache->counts[tc_idx]); e->key = NULL; |