diff options
| author | Aurelien Jarno <aurelien@aurel32.net> | 2014-05-16 00:03:37 +0200 |
|---|---|---|
| committer | Aurelien Jarno <aurelien@aurel32.net> | 2014-05-16 00:07:29 +0200 |
| commit | d0583c403952630c534b0605ff7d69af5ec473cc (patch) | |
| tree | 87b8ce3f6ac98870ceff9ec85e2b4fd1f3ec7641 /login/Makefile | |
| parent | c0c08d02c82275353f5c556f935a1a01714d9d7f (diff) | |
| download | glibc-d0583c403952630c534b0605ff7d69af5ec473cc.zip glibc-d0583c403952630c534b0605ff7d69af5ec473cc.tar.gz glibc-d0583c403952630c534b0605ff7d69af5ec473cc.tar.bz2 | |
ptsname_r: don't leak uninitialized memory (BZ #16917)
If the fd refers to a terminal device, but not a pty master, the
TIOCGPTN ioctl returns with ENOTTY. This error is not caught, and the
possibly undefined buffer passed to ptsname_r is sent directly to the
stat64 syscall.
Fix this by using a fallback to the old method only if the TIOCGPTN
ioctl fails with EINVAL. This also fix the return value in that specific
case (it return ENOENT without this patch).
Also add tests to the ptsname_r function (and ptsname at the same time).
Note: this is Debian bug#741482, reported by Jakub Wilk <jwilk@debian.org>
Diffstat (limited to 'login/Makefile')
| -rw-r--r-- | login/Makefile | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/login/Makefile b/login/Makefile index ca55808..d758ac5 100644 --- a/login/Makefile +++ b/login/Makefile @@ -43,7 +43,7 @@ endif subdir-dirs = programs vpath %.c programs -tests := tst-utmp tst-utmpx tst-grantpt +tests := tst-utmp tst-utmpx tst-grantpt tst-ptsname # Build the -lutil library with these extra functions. extra-libs := libutil |