aboutsummaryrefslogtreecommitdiff
path: root/libio/iofclose.c
diff options
context:
space:
mode:
authorAndreas Schwab <schwab@suse.de>2016-03-02 17:58:42 +0100
committerAndreas Schwab <schwab@suse.de>2016-06-09 09:57:40 +0200
commitbd499987c63fae6dd52fc577c8aada54293336bc (patch)
tree339601eda6c13ecbb909f162285a227734a94449 /libio/iofclose.c
parent530bb2bf3b2972a960cbf4ed7ddd0cf4561b5f83 (diff)
downloadglibc-bd499987c63fae6dd52fc577c8aada54293336bc.zip
glibc-bd499987c63fae6dd52fc577c8aada54293336bc.tar.gz
glibc-bd499987c63fae6dd52fc577c8aada54293336bc.tar.bz2
Fix nscd assertion failure in gc (bug 19755)
If a GETxxBYyy request (for passwd or group) is running in parallel to an INVALIDATE request (for the same database) then in a particular order of events the garbage collector is not properly marking all used memory and fails an assertion: GETGRBYNAME (root) Haven't found "root" in group cache! add new entry "root" of type GETGRBYNAME for group to cache (first) handle_request: request received (Version = 2) from PID 7413 INVALIDATE (group) pruning group cache; time 9223372036854775807 considering GETGRBYNAME entry "root", timeout 1456763027 add new entry "0" of type GETGRBYGID for group to cache remove GETGRBYNAME entry "root" nscd: mem.c:403: gc: Assertion `next_data == &he_data[db->head->nentries]' failed. Here the first call to cache_add added the GETGRBYNAME entry, which is immediately marked for collection by prune_cache. Then the GETGRBYGID entry is added which shares the data packet with the first entry and therefore is marked as !first, while the marking look in prune_cache has already finished. When the garbage collector runs, it only considers references by entries marked as first, missing the reference by the secondary entry. The only way to fix that is to prevent prune_cache from running while the two related entries are added.
Diffstat (limited to 'libio/iofclose.c')
0 files changed, 0 insertions, 0 deletions