diff options
| author | Stefan Liebler <stli@linux.vnet.ibm.com> | 2015-07-07 16:11:14 +0200 |
|---|---|---|
| committer | Andreas Krebbel <krebbel@linux.vnet.ibm.com> | 2015-07-07 16:11:14 +0200 |
| commit | 890b7a4b33d482b5c768ab47d70758b80227e9bc (patch) | |
| tree | d1c0d9f0005382a0b051f227f5a0ea9af89f89b3 /NEWS | |
| parent | fa4eeac73dd1c368bf06ef071fdf20d9f40c6c15 (diff) | |
| download | glibc-890b7a4b33d482b5c768ab47d70758b80227e9bc.zip glibc-890b7a4b33d482b5c768ab47d70758b80227e9bc.tar.gz glibc-890b7a4b33d482b5c768ab47d70758b80227e9bc.tar.bz2 | |
S390: Fix "backtrace() returns infinitely deep stack frames with makecontext()" [BZ #18508].
On s390/s390x backtrace(buffer, size) returns the series of called functions until
"makecontext_ret" and additional entries (up to "size") with "makecontext_ret".
GDB-backtrace is also warning:
"Backtrace stopped: previous frame identical to this frame (corrupt stack?)"
To reproduce this scenario you have to setup a new context with makecontext()
and activate it with setcontext(). See e.g. cf() function in testcase stdlib/tst-makecontext.c.
Or see bug in libgo "Bug 66303 - runtime.Caller() returns infinitely deep stack frames
on s390x " (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66303).
This patch omits the cfi_startproc/cfi_endproc directives in ENTRY/END macro of
__makecontext_ret. Thus no frame information is generated in .eh_frame and backtrace
stops after __makecontext_ret. There is also no .eh_frame info for _start or
thread_start functions.
ChangeLog:
[BZ #18508]
* stdlib/Makefile ($(objpfx)tst-makecontext3):
Depend on $(libdl).
* stdlib/tst-makecontext.c (cf): Test if _Unwind_Backtrace
is not called infinitely times.
(backtrace_helper): New function.
(trace_arg): New struct.
(st1): Enlarge stack size.
* sysdeps/unix/sysv/linux/s390/s390-32/__makecontext_ret.S:
(__makecontext_ret): Omit cfi_startproc and cfi_endproc.
* sysdeps/unix/sysv/linux/s390/s390-64/__makecontext_ret.S:
Likewise.
Diffstat (limited to 'NEWS')
| -rw-r--r-- | NEWS | 9 |
1 files changed, 5 insertions, 4 deletions
@@ -22,10 +22,11 @@ Version 2.22 18211, 18217, 18219, 18220, 18221, 18234, 18244, 18245, 18247, 18287, 18319, 18324, 18333, 18346, 18371, 18397, 18409, 18410, 18412, 18418, 18422, 18434, 18435, 18444, 18468, 18469, 18470, 18479, 18483, 18495, - 18496, 18497, 18498, 18502, 18507, 18512, 18513, 18519, 18520, 18522, - 18527, 18528, 18529, 18530, 18532, 18533, 18534, 18536, 18539, 18540, - 18542, 18544, 18545, 18546, 18547, 18549, 18553, 18558, 18569, 18583, - 18585, 18586, 18592, 18593, 18594, 18602, 18612, 18613, 18619, 18633. + 18496, 18497, 18498, 18502, 18507, 18508, 18512, 18513, 18519, 18520, + 18522, 18527, 18528, 18529, 18530, 18532, 18533, 18534, 18536, 18539, + 18540, 18542, 18544, 18545, 18546, 18547, 18549, 18553, 18558, 18569, + 18583, 18585, 18586, 18592, 18593, 18594, 18602, 18612, 18613, 18619, + 18633. * Cache information can be queried via sysconf() function on s390 e.g. with _SC_LEVEL1_ICACHE_SIZE as argument. |