diff options
| author | Carlos O'Donell <carlos@systemhalted.org> | 2015-03-13 09:49:24 -0400 |
|---|---|---|
| committer | Carlos O'Donell <carlos@systemhalted.org> | 2015-03-13 09:49:24 -0400 |
| commit | cf9313e7d1dd42addd6cf8c9277f0f18a62cdeff (patch) | |
| tree | 6bbf8900b476073a3d30cf24aae7b317b65344fc /ChangeLog | |
| parent | 7d67a196b6548562070ac11fc673c0d3d263d846 (diff) | |
| download | glibc-cf9313e7d1dd42addd6cf8c9277f0f18a62cdeff.zip glibc-cf9313e7d1dd42addd6cf8c9277f0f18a62cdeff.tar.gz glibc-cf9313e7d1dd42addd6cf8c9277f0f18a62cdeff.tar.bz2 | |
Enhance nscd's inotify support (Bug 14906).
In bug 14906 the user complains that the inotify support in nscd
is not sufficient when it comes to detecting changes in the
configurationfiles that should be watched for the various databases.
The current nscd implementation uses inotify to watch for changes in
the configuration files, but adds watches only for IN_DELETE_SELF and
IN_MODIFY. These watches are insufficient to cover even the most basic
uses by a system administrator. For example using emacs or vim to edit
a configuration file should trigger a reload but it might not if
the editors use move to atomically update the file. This atomic update
changes the inode and thus removes the notification on the file (as
inotify is based on inodes). Thus the inotify support in nscd for
configuration files is insufficient to account for the average use
cases of system administrators and users.
The inotify support is significantly enhanced and described here:
https://www.sourceware.org/ml/libc-alpha/2015-02/msg00504.html
Tested on x86_64 with and without inotify support.
Diffstat (limited to 'ChangeLog')
| -rw-r--r-- | ChangeLog | 24 |
1 files changed, 24 insertions, 0 deletions
@@ -1,3 +1,27 @@ +2015-03-13 Carlos O'Donell <carlos@redhat.com> + + [BZ #14906] + * nscd/cache.c (prune_cache): Use TRACED_FILE. Compare and update + traced file mtime. Use consistent log message. + * nscd/connections.c [HAVE_INOTIFY] (install_watches): New function. + (register_traced_file): Call install_watches. Always set mtime. + (invalidate_cache): Iterate over all trace files. Call install_watches. + (inotify_check_files): Don't inline. Handle watching parent + directories and configuration file movement in and out. + (handle_inotify_events): New function. + (main_loop_poll): Call handle_inotify_events. + (main_loop_epoll): Likewise. + * nscd/nscd.h: Define TRACED_FILE, TRACED_DIR, and PATH_MAX. + (struct traced_file): Use array of inotify fds. Add parent directory, + and basename. + (struct database_dyn): Remove unused file_mtime. + (init_traced_file): New inline function. + (define_traced_file): New macro. + * nss/nss_db/db-init.c: Use define_traced_file. + (_nss_db_init): Use init_traced_file. + * nss/nss_files/files-init.c: Use define_traced_file. + (_nss_files_init): Use init_traced_file. + 2015-03-12 Joseph Myers <joseph@codesourcery.com> * soft-fp/soft-fp.h (_FP_STATIC_ASSERT): New macro. |