aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndreas Schwab <schwab@linux-m68k.org>2021-06-25 15:02:47 +0200
committerAndreas Schwab <schwab@linux-m68k.org>2021-06-27 19:35:42 +0200
commit5adda61f62b77384718b4c0d8336ade8f2b4b35c (patch)
tree5d3e0191705475d565e66b35415f864b14e8825d
parent3213ed770cbc5821920d16caa93c85e92dd7b9f6 (diff)
downloadglibc-5adda61f62b77384718b4c0d8336ade8f2b4b35c.zip
glibc-5adda61f62b77384718b4c0d8336ade8f2b4b35c.tar.gz
glibc-5adda61f62b77384718b4c0d8336ade8f2b4b35c.tar.bz2
wordexp: handle overflow in positional parameter number (bug 28011)
Use strtoul instead of atoi so that overflow can be detected.
-rw-r--r--posix/wordexp-test.c1
-rw-r--r--posix/wordexp.c2
2 files changed, 2 insertions, 1 deletions
diff --git a/posix/wordexp-test.c b/posix/wordexp-test.c
index f93a546..9df02db 100644
--- a/posix/wordexp-test.c
+++ b/posix/wordexp-test.c
@@ -183,6 +183,7 @@ struct test_case_struct
{ 0, NULL, "$var", 0, 0, { NULL, }, IFS },
{ 0, NULL, "\"\\n\"", 0, 1, { "\\n", }, IFS },
{ 0, NULL, "", 0, 0, { NULL, }, IFS },
+ { 0, NULL, "${1234567890123456789012}", 0, 0, { NULL, }, IFS },
/* Flags not already covered (testit() has special handling for these) */
{ 0, NULL, "one two", WRDE_DOOFFS, 2, { "one", "two", }, IFS },
diff --git a/posix/wordexp.c b/posix/wordexp.c
index bcbe96e..1f3b09f 100644
--- a/posix/wordexp.c
+++ b/posix/wordexp.c
@@ -1399,7 +1399,7 @@ envsubst:
/* Is it a numeric parameter? */
else if (isdigit (env[0]))
{
- int n = atoi (env);
+ unsigned long n = strtoul (env, NULL, 10);
if (n >= __libc_argc)
/* Substitute NULL. */