From c20ceeb226168ffd84078ef74d890c2b7f69a435 Mon Sep 17 00:00:00 2001 From: Yiran Wang Date: Mon, 20 Jul 2015 08:47:57 -0700 Subject: Remove warning about references from shared objects to hidden symbols. gold/ PR gold/15574 * resolve.cc (Symbol_table): Remove warning about references from shared objects to hidden symbols. * testsuite/Makefile.am (hidden_test): Add hidden_test.syms. * testsuite/Makefile.in: Regenerate. * testsuite/hidden_test.sh: Check dynamic symbol table; update expected error messages. --- gold/resolve.cc | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) (limited to 'gold/resolve.cc') diff --git a/gold/resolve.cc b/gold/resolve.cc index fdae0ba..22d1e78 100644 --- a/gold/resolve.cc +++ b/gold/resolve.cc @@ -286,15 +286,10 @@ Symbol_table::resolve(Sized_symbol* to, && (to->visibility() == elfcpp::STV_HIDDEN || to->visibility() == elfcpp::STV_INTERNAL)) { - // A dynamic object cannot reference a hidden or internal symbol - // defined in another object. - gold_warning(_("%s symbol '%s' in %s is referenced by DSO %s"), - (to->visibility() == elfcpp::STV_HIDDEN - ? "hidden" - : "internal"), - to->demangled_name().c_str(), - to->object()->name().c_str(), - object->name().c_str()); + // The symbol is hidden, so a reference from a shared object + // cannot bind to it. We tried issuing a warning in this case, + // but that produces false positives when the symbol is + // actually resolved in a different shared object (PR 15574). return; } else -- cgit v1.1