From 41a883c8edf98e86176d007bc8ad1c86c9675528 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Tue, 10 Apr 2018 08:24:43 -0600 Subject: Clear entire "location" in value constructor My recent change to allocate values with "new" may have introduced a small bug. In particular, the previous code allocated with XCNEW, but the new code only clears a part of the "location" field in the constructor. I didn't try very hard to actually trigger a bug here, the problem remains theoretical. This patch just arranges to initialize the entire location. Regression tested by the buildbot. 2018-05-25 Tom Tromey * value.c (value::location): Initialize. --- gdb/ChangeLog | 4 ++++ gdb/value.c | 3 +-- 2 files changed, 5 insertions(+), 2 deletions(-) (limited to 'gdb') diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 4f087b1..33c6a71 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,9 @@ 2018-05-25 Tom Tromey + * value.c (value::location): Initialize. + +2018-05-25 Tom Tromey + * dbxread.c (init_bincl_list): Remove. (bincl_list): Now a std::vector. (bincls_allocated, next_bincl): Remove. diff --git a/gdb/value.c b/gdb/value.c index aa6ca43..6bb6b8e 100644 --- a/gdb/value.c +++ b/gdb/value.c @@ -180,7 +180,6 @@ struct value type (type_), enclosing_type (type_) { - location.address = 0; } ~value () @@ -262,7 +261,7 @@ struct value /* Closure for those functions to use. */ void *closure; } computed; - } location; + } location {}; /* Describes offset of a value within lval of a structure in target addressable memory units. Note also the member embedded_offset -- cgit v1.1