From 336bb2a1c1d24f5db07394a109f7cd6c5b58b10d Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Wed, 11 Sep 2024 10:35:20 -0600 Subject: Automatically add types to Python modules PR python/32163 points out that various types provided by gdb are not added to the gdb module, so they aren't available for interactive inspection. I think this is just an oversight. This patch fixes the problem by introducing a new helper function that both readies the type and then adds it to the appropriate module. The patch also poisons PyType_Ready, the idea being to avoid this bug in the future. v2: * Fixed a bug in original patch in gdb.Architecture registration * Added regression test for the types mentioned in the bug Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=32163 Reviewed-By: Alexandra Petlanova Hajkova --- gdb/python/py-instruction.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'gdb/python/py-instruction.c') diff --git a/gdb/python/py-instruction.c b/gdb/python/py-instruction.c index bc3945a..7d77572 100644 --- a/gdb/python/py-instruction.c +++ b/gdb/python/py-instruction.c @@ -66,7 +66,7 @@ py_insn_get_insn_type () py_insn_type.tp_doc = "GDB instruction object"; py_insn_type.tp_getset = py_insn_getset; - if (PyType_Ready (&py_insn_type) < 0) + if (gdbpy_type_ready (&py_insn_type) < 0) { /* Reset the tp_new field so any subsequent calls to this function will retry to make the type ready. */ -- cgit v1.1