From 4be290b2517839872ef7de47230be8dbd291a7e5 Mon Sep 17 00:00:00 2001 From: Andrew Burgess Date: Tue, 9 Apr 2019 23:06:41 +0100 Subject: gdb: Introduce new language field la_is_string_type_p This commit is preparation work for the next commit, and by itself makes no user visible change to GDB. I've split this work into a separate commit in order to make code review easier. This commit adds a new field 'la_is_string_type_p' to the language struct, this predicate will return true if a type is a string type for the given language. Some languages already have a "is this a string" predicate that I was able to reuse, while for other languages I've had to add a new predicate. In this case I took inspiration from the value printing code for that language - what different conditions would result in printing something as a string. A default "is this a string" method has also been added that looks for TYPE_CODE_STRING, this is the fallback I've used for a couple of languages. In this commit I add the new field and initialise it for each language, however at this stage the new field is never used. gdb/ChangeLog: * ada-lang.c (ada_language_defn): Initialise new field. * c-lang.c (c_is_string_type_p): New function. (c_language_defn): Initialise new field. (cplus_language_defn): Initialise new field. (asm_language_defn): Initialise new field. (minimal_language_defn): Initialise new field. * c-lang.h (c_is_string_type_p): Declare new function. * d-lang.c (d_language_defn): Initialise new field. * f-lang.c (f_is_string_type_p): New function. (f_language_defn): Initialise new field. * go-lang.c (go_is_string_type_p): New function. (go_language_defn): Initialise new field. * language.c (default_is_string_type_p): New function. (unknown_language_defn): Initialise new field. (auto_language_defn): Initialise new field. * language.h (struct language_defn) : New member variable. (default_is_string_type_p): Declare new function. * m2-lang.c (m2_language_defn): Initialise new field. * objc-lang.c (objc_language_defn): Initialise new field. * opencl-lang.c (opencl_language_defn): Initialise new field. * p-lang.c (pascal_is_string_type_p): New function. (pascal_language_defn): Initialise new field. * rust-lang.c (rust_is_string_type_p): New function. (rust_language_defn): Initialise new field. --- gdb/c-lang.h | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'gdb/c-lang.h') diff --git a/gdb/c-lang.h b/gdb/c-lang.h index e7b6d5e..70a95ea 100644 --- a/gdb/c-lang.h +++ b/gdb/c-lang.h @@ -148,6 +148,11 @@ extern int cp_is_vtbl_ptr_type (struct type *); extern int cp_is_vtbl_member (struct type *); +/* Return true if TYPE is a string type. Unlike DEFAULT_IS_STRING_TYPE_P + this will detect arrays of characters not just TYPE_CODE_STRING. */ + +extern bool c_is_string_type_p (struct type *type); + /* These are in c-valprint.c. */ extern int c_textual_element_type (struct type *, char); -- cgit v1.1