From b926417afaea99ed17663e06d6654d0048536017 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Sat, 21 Apr 2018 16:16:27 -0600 Subject: Simple -Wshadow=local fixes This fixes all the straightforward -Wshadow=local warnings in gdb. A few standard approaches are used here: * Renaming an inner (or outer, but more commonly inner) variable; * Lowering a declaration to avoid a clash; * Moving a declaration into a more inner scope to avoid a clash, including the special case of moving a declaration into a loop header. I did not consider any of the changes in this patch to be particularly noteworthy, though of course they should all still be examined. gdb/ChangeLog 2018-10-04 Tom Tromey * ctf.c (SET_ARRAY_FIELD): Rename "u32". * p-valprint.c (pascal_val_print): Split inner "i" variable. * xtensa-tdep.c (xtensa_push_dummy_call): Declare "i" in loop header. * xstormy16-tdep.c (xstormy16_push_dummy_call): Declare "val" in more inner scope. * xcoffread.c (read_xcoff_symtab): Rename inner "symbol". * varobj.c (varobj_update): Rename inner "newobj", "type_changed". * valprint.c (generic_emit_char): Rename inner "buf". * valops.c (find_overload_match): Rename inner "temp". (value_struct_elt_for_reference): Declare "v" in more inner scope. * v850-tdep.c (v850_push_dummy_call): Rename "len". * unittests/array-view-selftests.c (run_tests): Rename inner "vec". * tui/tui-stack.c (tui_show_frame_info): Declare "i" in loop header. * tracepoint.c (merge_uploaded_trace_state_variables): Declare "tsv" in more inner scope. (print_one_static_tracepoint_marker): Rename inner "tuple_emitter". * tic6x-tdep.c (tic6x_analyze_prologue): Declare "inst" lower. (tic6x_push_dummy_call): Don't redeclare "addr". * target-float.c: Declare "dto" lower. * symtab.c (lookup_local_symbol): Rename inner "sym". (find_pc_sect_line): Rename inner "pc". * stack.c (print_frame): Don't redeclare "gdbarch". (return_command): Rename inner "gdbarch". * s390-tdep.c (s390_prologue_frame_unwind_cache): Renam inner "sp". * rust-lang.c (rust_internal_print_type): Declare "i" in loop header. * rs6000-tdep.c (ppc_process_record): Rename inner "addr". * riscv-tdep.c (riscv_push_dummy_call): Declare "info" in inner scope. * remote.c (remote_target::update_thread_list): Don't redeclare "tp". (remote_target::process_initial_stop_replies): Rename inner "thread". (remote_target::remote_parse_stop_reply): Don't redeclare "p". (remote_target::wait_as): Don't redeclare "stop_reply". (remote_target::get_thread_local_address): Rename inner "result". (remote_target::get_tib_address): Likewise. --- gdb/breakpoint.c | 26 +++++++++++--------------- 1 file changed, 11 insertions(+), 15 deletions(-) (limited to 'gdb/breakpoint.c') diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index eb408d7..3d25434 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -3300,8 +3300,6 @@ create_longjmp_master_breakpoint (void) if (!bp_objfile_data->longjmp_probes.empty ()) { - struct gdbarch *gdbarch = get_objfile_arch (objfile); - for (probe *p : bp_objfile_data->longjmp_probes) { struct breakpoint *b; @@ -3453,12 +3451,10 @@ create_exception_master_breakpoint (void) if (!bp_objfile_data->exception_probes.empty ()) { - struct gdbarch *gdbarch = get_objfile_arch (objfile); + gdbarch = get_objfile_arch (objfile); for (probe *p : bp_objfile_data->exception_probes) { - struct breakpoint *b; - b = create_internal_breakpoint (gdbarch, p->get_relocated_address (objfile), bp_exception_master, @@ -10518,7 +10514,7 @@ watch_command_1 (const char *arg, int accessflag, int from_tty, { struct breakpoint *scope_breakpoint = NULL; const struct block *exp_valid_block = NULL, *cond_exp_valid_block = NULL; - struct value *mark, *result; + struct value *result; int saved_bitpos = 0, saved_bitsize = 0; const char *exp_start = NULL; const char *exp_end = NULL; @@ -10643,7 +10639,7 @@ watch_command_1 (const char *arg, int accessflag, int from_tty, } exp_valid_block = innermost_block.block (); - mark = value_mark (); + struct value *mark = value_mark (); struct value *val_as_value = nullptr; fetch_subexp_value (exp.get (), &pc, &val_as_value, &result, NULL, just_location); @@ -11494,14 +11490,14 @@ clear_command (const char *arg, int from_tty) /* Remove duplicates from the vec. */ std::sort (found.begin (), found.end (), - [] (const breakpoint *a, const breakpoint *b) + [] (const breakpoint *bp_a, const breakpoint *bp_b) { - return compare_breakpoints (a, b) < 0; + return compare_breakpoints (bp_a, bp_b) < 0; }); found.erase (std::unique (found.begin (), found.end (), - [] (const breakpoint *a, const breakpoint *b) + [] (const breakpoint *bp_a, const breakpoint *bp_b) { - return compare_breakpoints (a, b) == 0; + return compare_breakpoints (bp_a, bp_b) == 0; }), found.end ()); @@ -13290,9 +13286,9 @@ delete_command (const char *arg, int from_tty) } else map_breakpoint_numbers - (arg, [&] (breakpoint *b) + (arg, [&] (breakpoint *br) { - iterate_over_related_breakpoints (b, delete_breakpoint); + iterate_over_related_breakpoints (br, delete_breakpoint); }); } @@ -14861,9 +14857,9 @@ delete_trace_command (const char *arg, int from_tty) } else map_breakpoint_numbers - (arg, [&] (breakpoint *b) + (arg, [&] (breakpoint *br) { - iterate_over_related_breakpoints (b, delete_breakpoint); + iterate_over_related_breakpoints (br, delete_breakpoint); }); } -- cgit v1.1