From 2e384d4f44f15e560b2a068e0ed866438aaa7cd7 Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Wed, 13 Mar 2024 06:31:28 -0700 Subject: bfd: Use MAP_FAILED for mmap failure Use MAP_FAILED, instead of ((void *) -1), for mmap failure and use ((void *) -1) only if MAP_FAILED is undefined. * bfdio.c (bfd_mmap): Replace (void *) -1 with MAP_FAILED for mmap failure. * bfdwin.c: Don't include . (MAP_FILE): Removed. (bfd_get_file_window): Replace (void *) -1 with MAP_FAILED for mmap failure. * cache.c: Don't include . (cache_bmmap): Replace (void *) -1 with MAP_FAILED for mmap failure. * opncls.c (opncls_bmmap): Likewise. * sysdep.h: Include if HAVE_MMAP is define. (MAP_FILE): New. Defined as 0 if undefined. (MAP_FAILED): New. Defined as ((void *) -1) if undefined. --- bfd/vms-lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'bfd/vms-lib.c') diff --git a/bfd/vms-lib.c b/bfd/vms-lib.c index b0ca990..592a57f 100644 --- a/bfd/vms-lib.c +++ b/bfd/vms-lib.c @@ -1277,7 +1277,7 @@ vms_lib_bmmap (struct bfd *abfd ATTRIBUTE_UNUSED, void **map_addr ATTRIBUTE_UNUSED, bfd_size_type *map_len ATTRIBUTE_UNUSED) { - return (void *) -1; + return MAP_FAILED; } static const struct bfd_iovec vms_lib_iovec = { -- cgit v1.1