From 7ca371dba5d612ff1cdaa4ffe33474c1993fbe7f Mon Sep 17 00:00:00 2001
From: Alan Modra <amodra@gmail.com>
Date: Fri, 28 Aug 2020 21:45:49 +0930
Subject: PR26418 UBSAN: cache.c:386 null pointer fwrite

The previous "fix" tested the wrong value.

	PR 26418
	* ecofflink.c (WRITE): Really don't write zero size chunks.
---
 bfd/ecofflink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'bfd/ecofflink.c')

diff --git a/bfd/ecofflink.c b/bfd/ecofflink.c
index 7c9a7ae..e8c3f9f 100644
--- a/bfd/ecofflink.c
+++ b/bfd/ecofflink.c
@@ -1491,7 +1491,7 @@ bfd_ecoff_write_debug (bfd *abfd,
 #define WRITE(ptr, count, size, offset) \
   BFD_ASSERT (symhdr->offset == 0				\
 	      || (bfd_vma) bfd_tell (abfd) == symhdr->offset);	\
-  if (size != 0							\
+  if (symhdr->count != 0					\
       && bfd_bwrite (debug->ptr,				\
 		     (bfd_size_type) size * symhdr->count,	\
 		     abfd) != size * symhdr->count)		\
-- 
cgit v1.1