From 18d7868b1b721d11916912fa398363f4b5e50128 Mon Sep 17 00:00:00 2001 From: Hans-Peter Nilsson Date: Wed, 12 Nov 2008 01:41:12 +0000 Subject: * read.c (read_a_source_file): Rearrange evaluation order when looking for '=' to avoid conditional on undefined contents of input_line_pointer[1]. --- gas/ChangeLog | 6 ++++++ gas/read.c | 8 ++++---- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/gas/ChangeLog b/gas/ChangeLog index c89a192..6857bab 100644 --- a/gas/ChangeLog +++ b/gas/ChangeLog @@ -1,3 +1,9 @@ +2008-11-12 Hans-Peter Nilsson + + * read.c (read_a_source_file): Rearrange evaluation order when + looking for '=' to avoid conditional on undefined contents of + input_line_pointer[1]. + 2008-11-06 Adam Nemet * config/tc-mips.c (COP_INSN): Change logic to always return false diff --git a/gas/read.c b/gas/read.c index 121c97a..1cf5e9a 100644 --- a/gas/read.c +++ b/gas/read.c @@ -791,10 +791,10 @@ read_a_source_file (char *name) /* Input_line_pointer->after ':'. */ SKIP_WHITESPACE (); } - else if (input_line_pointer[1] == '=' - && (c == '=' - || ((c == ' ' || c == '\t') - && input_line_pointer[2] == '='))) + else if ((c == '=' && input_line_pointer[1] == '=') + || ((c == ' ' || c == '\t') + && input_line_pointer[1] == '=' + && input_line_pointer[2] == '=')) { equals (s, -1); demand_empty_rest_of_line (); -- cgit v1.1