aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
3 daysgas: Define comment_chars for non-ELF PowerPC targetsNick Clifton2-7/+7
3 daysFix gdb.base/gcorebg.exp and --program-prefixPedro Alves4-8/+31
When GDB is configured with --program-prefix, we see: Running /home/pedro/gdb/src/gdb/testsuite/gdb.base/gcorebg.exp ... FAIL: gdb.base/gcorebg.exp: detached=detached: Spawned gcore finished FAIL: gdb.base/gcorebg.exp: detached=detached: Core file generated by gcore FAIL: gdb.base/gcorebg.exp: detached=standard: Spawned gcore finished FAIL: gdb.base/gcorebg.exp: detached=standard: Core file generated by gcore The problem is here (with --program-prefix=prefix-), from gdb.log: gcore: GDB binary (/home/pedro/gdb/build-program-prefix/gdb/testsuite/../../gdb/prefix-gdb) not found FAIL: gdb.base/gcorebg.exp: detached=detached: Spawned gcore finished That is gcore (the script, not the GDB command) trying to run the installed GDB: if [ ! -f "$binary_path/@GDB_TRANSFORM_NAME@" ]; then echo "gcore: GDB binary (${binary_path}/@GDB_TRANSFORM_NAME@) not found" exit 1 fi ... "$binary_path/@GDB_TRANSFORM_NAME@" </dev/null \ ... When running the testsuite with the just-built GDB, the GDB binary is 'gdb', not @GDB_TRANSFORM_NAME@. Fix this by adding a new '-g gdb" option to the 'gcore' script, that lets you override the GDB binary gcore runs, and then making gdb.base/gcorebg.exp pass it to gcore. The GDB binary we're testing is always in the $GDB global. This is similar to how it is already possible to specify GDB's data directory with an option to gcore, and then gdb.base/gcorebg.exp uses it. NEWS and documentation changes included. Approved-by: Kevin Buettner <kevinb@redhat.com> Change-Id: I6c60fba8768618eeba8d8d03b131dc756b57ee78
3 daysFix nested gdb_caching_proc with argsPedro Alves3-25/+21
Commit d09eba07 ("Make get_compiler_info use gdb_caching_proc") regressed some tests when you run them in isolation (as this depends on the order the gdb_caching_proc procs' results are cached). E.g.: Running /home/pedro/rocm/gdb/build/gdb/testsuite/../../../src/gdb/testsuite/gdb.rocm/simple.exp ... ERROR: tcl error sourcing /home/pedro/rocm/gdb/build/gdb/testsuite/../../../src/gdb/testsuite/gdb.rocm/simple.exp. ERROR: tcl error code TCL WRONGARGS ERROR: wrong # args: should be "gdb_real__get_compiler_info_1 language" while executing "gdb_real__get_compiler_info_1" ("uplevel" body line 1) invoked from within "uplevel 2 $real_name" (procedure "gdb_do_cache_wrap" line 3) invoked from within "gdb_do_cache_wrap $real_name {*}$args" (procedure "gdb_do_cache" line 98) invoked from within gdb.base/attach.exp triggers it too, for example. This is actually a latent problem in gdb_do_cache_wrap, introduced in: commit 71f1ab80f1aabd70bce526635f84c7b849e8a0f4 CommitDate: Mon Mar 6 16:49:19 2023 +0100 [gdb/testsuite] Allow args in gdb_caching_proc This change: # Call proc real_name and return the result, while ignoring calls to pass. -proc gdb_do_cache_wrap {real_name} { +proc gdb_do_cache_wrap {real_name args} { if { [info procs save_pass] != "" } { return [uplevel 2 $real_name] <<<<<<<<<<<<<<<<<<<<<<< HERE } @@ -31,7 +31,7 @@ proc gdb_do_cache_wrap {real_name} { rename pass save_pass rename ignore_pass pass - set code [catch {uplevel 2 $real_name} result] + set code [catch {uplevel 2 [list $real_name {*}$args]} result] Missed updating the line marked with HERE above, to pass down $args. So the case of a caching proc calling another caching proc with args isn't handled correctly. We could fix this by fixing the HERE line like so: - return [uplevel 2 $real_name] + return [uplevel 2 [list $real_name {*}$args]] However, we have with_override nowadays that we can use here which eliminates the duplicated logic, which was what was missed originally. A new test that exposes the problem is added to gdb.testsuite/gdb-caching-proc.exp. This also adds a new test to gdb.testsuite/with-override.exp that I think was missing, making sure that the inner foo override restores the outer foo override. Tested-By: Simon Marchi <simon.marchi@efficios.com> Change-Id: I8b2a7366bf910902fe5f547bde58c3b475bf5133
3 daysgas: testsuite: all: Avoid clashing names in err-sizeof.sRichard Earnshaw1-1/+1
The first junk test in this file was missing "junk" in the test name, which resulted in a duplicate test name when comparing with the real test on line 3.
3 daysgas: testsuite: elf: avoid clashing mbind test namesRichard Earnshaw1-1/+1
The section12b.d test has the wrong name, leading to a clash with the section 16b.d test. Fix that up.
3 daysbinutils: testsuite: avoid dup names when using multiple as: directivesRichard Earnshaw1-11/+16
binutils tests support running a test with distinct options to the assembler by allowing #as: <optset-1> #as: <optset-2> But results in both test runs using the same test name in the summary file. This causes confusion if one test fails but the other doesn't (and GCC's compare_tests script will diagnose this as an error). To fix the ambiguity append the appropriate optset to the test name. We only do this if a test has multiple runs in this way to avoid causing every test result name to change.
3 daysgas: testsuite: all: use unique test names for multibyte3 testsRichard Earnshaw1-1/+1
There are two tests of the mutibyte3 source file, with different options. As things stand this results in two distinct tests in the logs with the same name. Avoid this by adding the optional testname option to the second test.
3 daysRemove Solaris/PowerPC supportRainer Orth14-99/+42
Solaris/PowerPC was a shortlived Solaris port with limited hardware support. It was released with Solaris 2.5.1 back in 1996, with support removed again only a year later in Solaris 2.6. Since this is long obsolete, this patch removes the remains of the support. Tested by a cross to ppc-unknown-linux-gnu to ascertain the build didn't get broken. 2025-09-15 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> bfd: * config.bfd <powerpc-*-solaris2*>: Remove. gas: * NEWS: Mention Solaris/PowerPC removal. * configure.ac <ppc-*-solaris*>: Remove. * configure: Regenerate. * configure.in: Regenerate. * configure.tgt <ppc-*-solaris*>: Remove. * config/tc-ppc.c (ppc_solaris_comment_chars): Remove. (ppc_eabi_comment_chars): Remove. (SOLARIS_P): Remove. (msolaris): Remove. (md_parse_option): Remove "solaris", "no-solaris" hangling. (md_show_usage): Likewise. (md_begin): Remove msolaris handling. * config/tc-ppc.h (ppc_comment_chars): Fix declaration. * stabs.c (s_stab_generic) [TC_PPC && OBJ_ELF]: Remove 4-arg .stabd support. * doc/as.texi (Overview, Target PowerPC options): Remove -msolaris, -mno-solaris. * doc/c-ppc.texi (PowerPC-Opts): Remove -msolaris, -mno-solaris. (PowerPC-Chars): Remove ! as line comment character. ld: * configure.tgt <powerpc*-*-solaris*>: Remove.
4 daysgas/expr.h fixmeAlan Modra1-12/+4
* expr.h (expressionS): Adjust comments. Use ENUM_BITFIELD for X_op. (enum operatorT): Define.
4 daysDelete gas/po/gas.es.poAlan Modra1-24208/+0
es.po is newer, and this file is wrongly named.
4 daysAutomatic date update in version.inGDB Administrator1-1/+1
4 daysMake get_compiler_info use gdb_caching_procPedro Alves2-34/+24
While running tests on Windows with: $ make check-parallel RUNTESTFLAGS="-v" I noticed that get_compiler_info was invoking the compiler over and over for each testcase, even though the result is supposed to be cached. This isn't normally very visible in gdb.log, because we suppress it there: # Run $ifile through the right preprocessor. # Toggle gdb.log to keep the compiler output out of the log. set saved_log [log_file -info] log_file ... I'm not sure it's a good idea to do that suppression, BTW. I was very confused when I couldn't find the compiler invocation in gdb.log, and it took me a while to notice that code. The reason get_compiler_info in parallel mode isn't hitting the cache is that in that mode each testcase runs under its own expect/dejagnu process, and the way get_compiler_info caches results currently doesn't handle that -- the result is simply cached in a global variable, which is private to each expect. So improve this by switching get_compiler_info's caching mechanism to gdb_caching_proc instead, so that results are cached across parallel invocations of dejagnu. On an x86-64 GNU/Linux run with "make check-parallel -j32", before the patch I get 2223 calls to get_compiler_info that result in a compiler invocation. After the patch, I get 7. On GNU/Linux, those compiler invocations don't cost much, but on Windows, they add up. On my machine each invocation takes around 500ms to 700ms. Here is one representative run: $ time x86_64-w64-mingw32-gcc \ /c/msys2/home/alves/gdb/build-testsuite/temp/14826/compiler.c \ -fdiagnostics-color=never -E ... real 0m0.639s user 0m0.061s sys 0m0.141s This reference to a 'compiler_info' global: # N.B. compiler_info is intended to be local to this file. # Call test_compiler_info with no arguments to fetch its value. # Yes, this is counterintuitive when there's get_compiler_info, # but that's the current API. if [info exists compiler_info] { unset compiler_info } is outdated, even before this patch, as "compiler_info" is a local variable in get_compiler_info. Remove all that code. Since test_compiler_info now calls get_compiler_info directly, the "Requires get_compiler_info" comments in skip_inline_frame_tests and skip_inline_var_tests are no longer accurate. Remove them. test_compiler_info's intro comment is also outdated; improve it. Changing the return value of get_compiler_info to be the 'compiler_info' string directly instead of 0/-1 was simpler. It would be possible to support the current 0/-1 interface by making get_compiler_info_1 still return the 'compiler_info' string, and then having the get_compiler_info wrapper convert to 0/-1, and I considered doing that. But the only caller of get_compiler_info outside gdb.exp is gdb.python/py-event-load.exp, and it seems that one simply crossed wires with: commit 9704b8b4bc58f4f464961cca97d362fd33740ce8 gdb/testsuite: remove unneeded calls to get_compiler_info as the test as added at roughly the same time as that commit. So simply remove that call in gdb.python/py-event-load.exp, otherwise we get something like: ERROR: ------------------------------------------- ERROR: in testcase src/gdb/testsuite/gdb.python/py-event-load.exp ERROR: expected boolean value but got "gcc-13-3-0" ERROR: tcl error code TCL VALUE NUMBER ERROR: tcl error info: expected boolean value but got "gcc-13-3-0" Approved-By: Tom Tromey <tom@tromey.com> Change-Id: Ia3d3dc34f7cdcf9a2013f1054128c62a108eabfb
4 daysgdbsupport: remove xmalloc in format_piecesSimon Marchi6-86/+89
Remove the use of xmalloc (and the arbitrary allocation size) in format_pieces. This turned out a bit more involved than expected, but not too bad. format_pieces::m_storage is a buffer with multiple concatenated null-terminated strings, referenced by format_piece::string. Change this to an std::string, while keeping its purpose (use the std::string as a buffer with embedded null characters). However, because the std::string's internal buffer can be reallocated as it grows, and I do not want to hardcode a big reserved size like we have now, it's not possible to store the direct pointer to the string in format_piece::string. Those pointers would become stale as the buffer gets reallocated. Therefore, change format_piece to hold an index into the storage instead. Add format_pieces::piece_str for the callers to be able to access the piece's string. This requires changing the few callers, but in a trivial way. The selftest also needs to be updated. I want to keep the test cases as-is, where the expected pieces contain the expected string, and not hard-code an expected index. To achieve this, add the expected_format_piece structure. Note that the previous format_piece::operator== didn't compare the n_int_args fields, while the test provides expected values for that field. I guess that was a mistake. The new code checks it, and the test still passes. Change-Id: I80630ff60e01c8caaa800ae22f69a9a7660bc9e9 Reviewed-By: Keith Seitz <keiths@redhat.com>
4 daysgdbsupport: remove remaining alloca usesSimon Marchi3-36/+21
Remove the three remaining uses of alloca in gdbsupport. I only built-tested the Windows-only portion in pathstuff.cc. Change-Id: Ie588fa57f43de900d5f42e93a8875a7da462404b Reviewed-By: Keith Seitz <keiths@redhat.com>
4 daysgdbsupport: format_pieces: declare variables when neededSimon Marchi1-14/+9
I think it makes the code slightly easier to understand. Change-Id: I49056728e43fbf37c2af8f3904a543c10e987bba Reviewed-By: Keith Seitz <keiths@redhat.com>
4 daysarm: Rename some tests to avoid duplicate tests namesRichard Earnshaw29-29/+29
A number of arm-specific tests print the same name. This can cause problems if one of those tests fails, since then comparing tests with GCC's compare_tests script can result in ambiguities in the changes summary. Avoid this by giving tests unique names. Still to do is where a test is run more than once (eg by having multiple '#as: ' lines). This will require a tweak to the framework.
5 daysRISC-V: Add support for sdtrig and ssstrict extensions.Dongyan Chen5-0/+15
This implements the sdtrig extension, version 1.0[1] and ssstrict extension, version 1.0[2]. [1]https://github.com/riscv/riscv-debug-spec/blob/main/Sdtrig.adoc [2]https://github.com/riscv/riscv-profiles/issues/173 bfd/ChangeLog: * elfxx-riscv.c: Added sdtrig and ssstrict v1.0, and imply rules. gas/ChangeLog: * NEWS: Updated for sdtrig and ssstrict. * testsuite/gas/riscv/imply.d: DItto. * testsuite/gas/riscv/imply.s: Ditto. * testsuite/gas/riscv/march-help.l: Ditto.
5 daysAutomatic date update in version.inGDB Administrator1-1/+1
5 daysRemove uses of "eval" from gdb testsuiteTom Tromey22-56/+53
This patch removes a lot of uses of the Tcl "eval" proc from the gdb test suite. In most cases the {*} "splat" expansion is used instead. A few uses of eval remain, primarily ones that were more complicated to untangle. In a couple of tests I also replaced some ad hoc code with string_to_regexp. Tested on x86-64 Fedora 40. Reviewed-By: Tom de Vries <tdevries@suse.de>
5 daysgdb: improve show text and help text for 'remote exec-file'Andrew Burgess3-6/+18
The current behaviour for 'show remote exec-file' is this: (gdb) show remote exec-file (gdb) set remote exec-file /abc (gdb) show remote exec-file /abc (gdb) The first output, the blank line, is just GDB showing the default empty value. This output is not really inline with GDB's more full sentence style output, so in this commit I've updated things, the output is now: (gdb) show remote exec-file The remote exec-file is unset, the default remote executable will be used. (gdb) set remote exec-file /abc (gdb) show remote exec-file The remote exec-file is "/abc". (gdb) Which I think is more helpful to the user. I have also updated the help text for this setting. Previously we had a set/show header line, but no body text, now we have: (gdb) help show remote exec-file Show the remote file name for starting inferiors. This is the file name, on the remote target, used when starting an inferior, for example with the \"run\", \"start\", or \"starti\" commands. This setting is only useful when debugging a remote target, otherwise, this setting is not used. (gdb) Which I think is more helpful. Reviewed-By: Mark Wielaard <mark@klomp.org> Tested-By: Mark Wielaard <mark@klomp.org> Reviewed-By: Eli Zaretskii <eliz@gnu.org> Approved-By: Tom Tromey <tom@tromey.com>
5 daysgdb: improve how 'remote exec-file' is stored and accessedAndrew Burgess2-36/+39
This commit makes two related changes. The goal of the commit is to update the 'remote exec-file' setting to work correctly in a multi-inferior setup. To do this I have switched from the older style add_setshow_* function, which uses a single backing variable, to the newer style add_setshow_* functions that uses a get/set callback. The get/set callbacks now directly access the state held in the progspace which ensures that the correct value is always returned. However, the new get/set API requires that the get callback return a reference to the setting's value, which in this case needs to be a std::string. Currently the 'remote exec-file' setting is stored as a 'char *' string, which isn't going to work. And so, this commit also changes 'remote exec-file' to be stored as a std::string within the progspace. Now, when switching between multiple inferiors, GDB can correctly inform the user about the value of the 'remote exec-file' setting. Approved-By: Tom Tromey <tom@tromey.com>
5 daysgdb: have remote_target::extended_remote_run take the exec filenameAndrew Burgess1-4/+5
Small refactor, have remote_target::extended_remote_run take the name of the executable to run rather than looking it up directly, the one caller of this function has already looked up the remote-exec filename. There should be no user visible changes after this commit. Approved-By: Tom Tromey <tom@tromey.com>
6 daysAutomatic date update in version.inGDB Administrator1-1/+1
6 days[gdb/testsuite] Fix test names in gdb.tui/{empty,new-layout}.expTom de Vries2-2/+2
Post-commit review [1] pointed out that this change in gdb.tui/empty.exp: ... - eval Term::check_box [list "box $boxno"] $box + Term::check_box [list "box $boxno"] {*}$box ... is incomplete because it leaves the "[list ...]" in place. Indeed, it changes the test name like this: ... -PASS: gdb.tui/empty.exp: src: 80x24: box 1 +PASS: gdb.tui/empty.exp: src: 80x24: {box 1} ... Fix this by dropping the "[list ...]". Likewise in gdb.tui/new-layout.exp. [1] https://sourceware.org/pipermail/gdb-patches/2025-September/220863.html
6 daysdoc: sframe: add DRAFT marker for all outputsIndu Bhagat1-0/+4
Add DRAFT marker to be emitted in the info, pdf and html outputs. This is done in two places: one in the @ifnottex block meant for PDF output and another in @titlepage block meant for info and html output. While at it, also add date to non-pdf outputs. The marker lines: @center @strong{*** DRAFT - NOT FOR DISTRIBUTION ***} should be removed before a release. libsframe/doc/ * sframe-spec.texi: Add marker for DRAFT.
7 daysgdb, gdbserver: fix typosSimon Marchi2-4/+4
Found by the codespell pre-commit hook. Change-Id: Iafadd9485ce334c069dc8dbdab88ac3fb5fba674
7 daysAutomatic date update in version.inGDB Administrator1-1/+1
7 daysgdb/tui: Fix build for older ncursesCiaran Woodward2-1/+9
Older versions of ncurses (including the version that ships inside macos, and Centos 7) do not include the A_ITALIC macro. This patch simply hides any use of A_ITALIC behind a preprocessor guard. The result of this is that italics won't be rendered in the tui if ncurses isn't supported. We do have other options if we think it's important - for instance we could show italics as bold if italics aren't supported. From my understanding, that might be overthinking it - so I took the simplest approach here, just to fix the build. Those versions also define tgetnum as: int tgetnum(char *id); so attempting to compile for c++ results in the error: ISO C++ forbids converting a string constant to 'char*' [-Werror=write-strings] This is just a dated API issue, so a const cast resolves the issue. Approved-By: Tom Tromey <tom@tromey.com>
7 daysFix 32-bit failure in array_long_idx.expTom Tromey1-1/+4
Testing on the AdaCore-internal equivalent to array_long_idx.exp showed that it failed on 32-bit targets. This patch fixes the problem by arranging to use types that aren't target-dependent.
7 daysgdb: clear proceed status before starting a new inferiorAndrew Burgess2-0/+114
This patch fixes a bug when 'set schedule-multiple on' is in use and a second inferior is started using the 'run' command (or 'start' or 'starti'). This bug was reported as PR gdb/28777. The problem appears as the first inferior terminating with an unexpected SIGTRAP. The bug can be reproduced like this: gdb -ex 'set schedule-multiple on' \ -ex 'file /tmp/spin' \ -ex 'break main' \ -ex 'run' \ -ex 'add-inferior' \ -ex 'inferior 2' \ -ex 'file /tmp/spin' \ -ex 'break main' \ -ex 'run' The final 'run' can be replaced with 'start' or 'starti'. The output is different in the 'starti' case, but the cause is the same. For the 'run' and 'start' cases the final output is: Starting program: /tmp/spin Program terminated with signal SIGTRAP, Trace/breakpoint trap. The program no longer exists. In the 'starti' case the output is: Starting program: /tmp/spin Thread 2.1 "spin" stopped. Cannot remove breakpoints because program is no longer writable. Further execution is probably impossible. 0x00007ffff7fd3110 in _start () from /lib64/ld-linux-x86-64.so.2 What's happening is that GDB is failing to clear the previous proceed status from inferior 1 before starting inferior 2. Normally when schedule-multiple is off, this isn't a problem as 'run' only starts the new inferior, and the new inferior will have no previous proceed status that needs clearing. But when schedule-multiple is on, starting a new inferior, with 'run' and friends, will actually start all inferiors, including those that previous stopped at a breakpoint with a SIGTRAP signal. By failing to clear out the proceed status for those threads, when GDB restarts inferior 1 it arranges for the thread to receive the SIGTRAP, which is delivered, and, as GDB isn't expecting a SIGTRAP, is allowed to kill the process. Fix this by calling clear_proceed_status from run_command_1. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=28777
7 daysgdb: ensure thread state is updated when remote target starts upAndrew Burgess2-9/+18
This patch fixes a bug that was exposed by a test added in the previous commit. After writing this patch I also discovered that this issue had been reported as PR gdb/27322. When 'maint set target-non-stop on' is in effect, then the remote targets will be running in non-stop mode. The previous commit revealed a bug where, in this mode, GDB can fail to copy the thread state from the target to the GDB frontend, this leaves the thread marked as running in the frontend, even though the thread is actually stopped. When this happens the user is no longer able to interrupt the thread (it's already stopped), nor can the user resume the thread (GDB thinks the threads is running). To reproduce the bug: gdb -q -ex 'maint set target-non-stop on' \ -ex 'set non-stop off' \ -ex 'set sysroot' \ -ex 'file /bin/ls' \ -ex 'run &' \ -ex 'add-inferior' \ -ex 'infer 2' \ -ex 'set sysroot' \ -ex 'target remote | gdbserver - ls' \ -ex 'info threads' The 'info threads' output will look something like: Id Target Id Frame 1.1 process 1746383 "ls" (running) * 2.1 Thread 1746389.1746389 "ls" 0x00007ffff7fd3110 in _start () from /lib64/ld-linux-x86-64.so.2 The thread 1.1 should be stopped. GDB is running in all-stop mode after all. The problem is that in remote_target::process_initial_stop_replies, there is a call to stop_all_threads, however, the changes in the thread state are never copied back to the GDB frontend. This leaves the threads stopped, but still marked running. Solve this by adding a scoped_finish_thread_state. This is similar to how scoped_finish_thread_state is used in run_command_1 when we start a new inferior running. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=27322
7 daysgdb: disable commit resumed in wait_for_inferiorAndrew Burgess3-0/+225
This patch proposes a fix for PR gdb/33147. The bug can be reproduced like this: gdb -q -ex 'file /bin/ls' \ -ex 'run &' \ -ex 'add-inferior' \ -ex 'infer 2' \ -ex 'set sysroot' \ -ex 'target remote | gdbserver - ls' Which will trigger an assertion failure: target.c:3760: internal-error: target_stop: Assertion `!proc_target->commit_resumed_state' failed. The problem is that target_stop is being called for a target when commit_resumed_state is true, the comment on process_stratum_target::commit_resumed_state is pretty clear: To simplify the implementation of targets, the following methods are guaranteed to be called with COMMIT_RESUMED_STATE set to false: - resume - stop - wait So clearly we're breaking a precondition of target_stop. In this example there are two target, the native target (inferior 1), and the remote target (inferior 2). It is the first, the native target, for which commit_resumed_state is set incorrectly. At the point target_stop is called looks like this: #11 0x00000000009a3c19 in target_stop (ptid=...) at ../../src/gdb/target.c:3760 #12 target_stop (ptid=...) at ../../src/gdb/target.c:3756 #13 0x00000000007042f2 in stop_all_threads (reason=<optimized out>, inf=<optimized out>) at ../../src/gdb/infrun.c:5739 #14 0x0000000000711d3a in wait_for_inferior (inf=0x2b90fd0) at ../../src/gdb/infrun.c:4412 #15 start_remote (from_tty=from_tty@entry=1) at ../../src/gdb/infrun.c:3829 #16 0x0000000000897014 in remote_target::start_remote_1 (this=this@entry=0x2c4a520, from_tty=from_tty@entry=1, extended_p=extended_p@entry=0) at ../../src/gdb/remote.c:5350 #17 0x00000000008976e7 in remote_target::start_remote (extended_p=0, from_tty=1, this=0x2c4a520) at ../../src/gdb/remote.c:5441 #18 remote_target::open_1 (name=<optimized out>, from_tty=1, extended_p=0) at ../../src/gdb/remote.c:6312 #19 0x00000000009a815f in open_target (args=0x7fffffffa93c "| gdbserver - ls", from_tty=1, command=<optimized out>) at ../../src/gdb/target.c:838 For new inferiors commit_resumed_state starts set to false, for this reason, if we only start a remote inferior, then when wait_for_inferior is called commit_resumed_state will be false, and everything will work. Further, as target_stop is only called for running threads, if, when the remote inferior is started, all other threads (in other targets) are already stopped, then GDB will never need to call target_stop for the other targets, and so GDB will not notice that commit_resumed_state for those target is set to true. In this case though, as the first (native) inferior is left running in the background while the remote inferior is created, and because GDB is running in all-stop mode (so needs to stop all threads in all targets), then GDB does call target_stop for the other targets, and so spots that commit_resumed_state is not set correctly and asserts. The fix is to add scoped_disable_commit_resumed somewhere in the call stack. Initially I planned to add the scoped_disable_commit_resumed in `wait_for_inferior`, however, this isn't good enough. This location would solve the problem as described in the bug, but when writing the test I extended the problem to also cover non-stop mode, and this runs into a second problem, the same assertion, but triggered from a different call path. For this new case the stack looks like this: #1 0x0000000000fb0e50 in target_stop (ptid=...) at ../../src/gdb/target.c:3771 #2 0x0000000000a7f0ae in stop_all_threads (reason=0x1d0ff74 "remote connect in all-stop", inf=0x0) at ../../src/gdb/infrun.c:5756 #3 0x0000000000d9c028 in remote_target::process_initial_stop_replies (this=0x3e10670, from_tty=1) at ../../src/gdb/remote.c:5017 #4 0x0000000000d9cdf0 in remote_target::start_remote_1 (this=0x3e10670, from_tty=1, extended_p=0) at ../../src/gdb/remote.c:5405 #5 0x0000000000d9d0d4 in remote_target::start_remote (this=0x3e10670, from_tty=1, extended_p=0) at ../../src/gdb/remote.c:5457 #6 0x0000000000d9e8ac in remote_target::open_1 (name=0x7fffffffa931 "| gdbserver - /bin/ls", from_tty=1, extended_p=0) at ../../src/gdb/remote.c:6329 #7 0x0000000000d9d167 in remote_target::open (name=0x7fffffffa931 "| gdbserver - /bin/ls", from_tty=1) at ../../src/gdb/remote.c:5479 #8 0x0000000000f9914d in open_target (args=0x7fffffffa931 "| gdbserver - /bin/ls", from_tty=1, command=0x35d1a40) at ../../src/gdb/target.c:838 So I'm now thinking that stop_all_threads would be the best place for the scoped_disable_commit_resumed. I did leave an assert in wait_for_inferior as, having thought about the assert some, I do still think the logic of it is true, and it doesn't hurt to leave it in place I think. However, it's not quite that simple, the test throws up yet another bug when we 'maint set target-non-stop on', but then 'set non-stop off'. This bug leaves a stopped thread marked as "(running)" in the 'info threads' output. I have a fix for this issue, but I'm leaving that for the next commit. For now I've just disabled part of the test in the problem case. I've also tagged this patch with PR gdb/27322. That bug was created before the above assert was added, but if you follow the steps to reproduce for that bug today you will hit the above assert. The actual issue described in PR gdb/27322 is fixed in the next patch. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=27322 Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33147
7 daysgdb: ensure normal stop finishes the thread state of all threadsAndrew Burgess3-4/+208
This patch fixes a multi-target issue where the normal_stop function can fail to finish the thread state of threads from a non current target, this leaves the threads marked as running in GDB core, while the threads is actually stopped. For testing I used this test program: #include <unistd.h> int main () { while (1) sleep (1); return 0; } Compile this to make '/tmp/spin', then the bug can be shown using this command: $ gdb -ex 'file /tmp/spin' \ -ex 'start' \ -ex 'add-inferior' \ -ex 'inferior 2' \ -ex 'set sysroot' \ -ex 'target extended-remote | gdbserver --multi --once - /tmp/spin' \ -ex 'inferior 1' \ -ex 'continue&' \ -ex 'inferior 2' \ -ex 'search sleep' \ -ex 'break $_ inferior 2' \ -ex 'continue' \ -ex 'info threads' The interesting part of the output is: Id Target Id Frame 1.1 process 1610445 "spin" (running) * 2.1 Thread 1610451.1610451 "spin" main () at spin.c:7 (gdb) Notice that thread 1.1 is marked as running when it should be stopped. We can see that the thread is actually stopped if we try this: (gdb) inferior 1 [Switching to inferior 1 [process 1610445] (/tmp/spin)] [Switching to thread 1.1 (process 1610445)](running) (gdb) continue Cannot execute this command while the selected thread is running. (gdb) interrupt (gdb) info threads Id Target Id Frame * 1.1 process 1610445 "spin" (running) 2.1 Thread 1610451.1610451 "spin" main () at spin.c:7 (gdb) We can see the expected behaviour if both inferiors run on the same target, like this: $ gdb -ex 'file /tmp/spin' \ -ex 'start' \ -ex 'add-inferior' \ -ex 'inferior 2' \ -ex 'file /tmp/spin' \ -ex 'start' \ -ex 'inferior 1' \ -ex 'continue&' \ -ex 'inferior 2' \ -ex 'search sleep' \ -ex 'break $_ inferior 2' \ -ex 'continue' \ -ex 'info threads' The 'info threads' from this series of commands looks like this: Id Target Id Frame 1.1 process 1611589 "spin" 0x00007ffff7e951e7 in nanosleep () from /lib64/libc.so.6 * 2.1 process 1611593 "spin" main () at spin.c:7 (gdb) Now both threads are stopped as we'd expect. The problem is in normal_stop. The scoped_finish_thread_state uses user_visible_resume_target to select the target(s) over which GDB will iterate to find the threads to update. The problem with this is that when the ptid_t is minus_one_ptid, meaning all threads, user_visible_resume_target only returns nullptr, meaning all targets, when sched_multi is true. This dependency on sched_multi makes sense when _resuming_ threads. If we are resuming all threads, then when sched_multi (the schedule-multiple setting) is off (the default), all threads actually means all threads in the current inferior only. When sched_multi is true (schedule-multiple is on) then this means all threads, from all inferiors, which means GDB needs to consider every target. However, when stopping an inferior in all-stop mode (non_stop is false), then GDB wants to stop all threads from all inferiors, regardless of the sched_multi setting. What this means is that, when 'non_stop' is false, then we should be passing nullptr as the target selection to scoped_finish_thread_state. My proposal is that we should stop using user_visible_resume_target in the normal_stop function for the target selection of the scoped_finish_thread_state, instead we should manually figure out the correct target value and pass this in. There is precedent for this in GDB, see run_command_1, where 'finish_target' is calculated directly within the function rather than using user_visible_resume_target. After this commit, when using two different targets (native and remote) as in my first example above, both threads will be correctly stopped.
7 days[gdb/testsuite] Remove use of then keyword some moreTom de Vries6-9/+9
Find uses of the then keyword: ... $ find gdb/testsuite/ -type f -name *.exp* | xargs grep "if.*then {" ... and remove them. See also commit d4c4542312c ("gdb/testsuite: remove use of then keyword from library files") and related commits. Tested on aarch64-linux.
7 days[gdb/testsuite, tclint] Fix gdb.objcTom de Vries1-1/+1
Running tclint on the test-cases in gdb.opt shows a problem. Fix it. Tested on aarch64-linux.
7 days[gdb/testsuite, tclint] Fix gdb.optTom de Vries3-3/+3
Running tclint on the test-cases in gdb.opt shows a few problems. Fix these. Tested on aarch64-linux.
7 days[gdb/testsuite, tclint] Fix gdb.pascalTom de Vries6-10/+10
Running tclint on the test-cases in gdb.pascal shows a few problems. Fix these. Tested on aarch64-linux.
7 days[gdb/testsuite, tclint] Fix gdb.rocmTom de Vries1-3/+3
Running tclint on the test-cases in gdb.rocm shows a few problems: ... precise-memory-multi-inferiors.exp:33:5: expected braced word or word \ without substitutions in argument interpreted as expr [command-args] precise-memory-multi-inferiors.exp:43:5: expected braced word or word \ without substitutions in argument interpreted as expr [command-args] precise-memory-multi-inferiors.exp:55:5: expected braced word or word \ without substitutions in argument interpreted as expr [command-args] ... Fix these. The gdb.rocm test-cases are unsupported for me, so I can't test this.
7 days[gdb/testsuite, tclint] Fix gdb.rustTom de Vries2-2/+2
Running tclint on the test-cases in gdb.rust shows a few problems: ... modules.exp:37:1: expected braced word or word without substitutions in \ argument interpreted as expr [command-args] traits.exp:28:13: expected braced word or word without substitutions in \ argument interpreted as script [command-args] ... Fix these. Tested on aarch64-linux.
7 days[gdb/testsuite, tclint] Fix gdb.serverTom de Vries8-8/+8
Running tclint on the test-cases in gdb.server shows a few problems: ... connect-with-no-symbol-file.exp:72:1: line has trailing whitespace \ [trailing-whitespace] exit-multiple-threads.exp:73:5: expected braced word or word without \ substitutions in argument interpreted as expr [command-args] extended-remote-restart.exp:73:5: expected braced word or word without \ substitutions in argument interpreted as expr [command-args] monitor-exit-quit.exp:73:5: expected braced word or word without \ substitutions in argument interpreted as expr [command-args] reconnect-ctrl-c.exp:54:5: expected braced word or word without \ substitutions in argument interpreted as expr [command-args] server-exec-info.exp:24:1: expected braced word or word without \ substitutions in argument interpreted as expr [command-args] stop-reply-no-thread.exp:73:5: expected braced word or word without \ substitutions in argument interpreted as expr [command-args] /stop-reply-no-thread-multi.exp:81:5: expected braced word or word without \ substitutions in argument interpreted as expr [command-args] ... Fix these. Tested on aarch64-linux.
7 days[gdb/testsuite, tclint] Fix lib/tuiterm.expTom de Vries1-4/+4
Running tclint on lib/tuiterm.exp shows a few problems: ... $ tclint --ignore line-length gdb/testsuite/lib/tuiterm.exp tuiterm.exp:105:3: expression with substitutions should be enclosed by \ braces [unbraced-expr] tuiterm.exp:1576:28: unnecessary command substitution within expression \ [redundant-expr] tuiterm.exp:1582:25: unnecessary command substitution within expression \ [redundant-expr] ... Fix these. Tested on aarch64-linux.
7 days[gdb/testsuite, tclint] Fix gdb.tuiTom de Vries5-9/+9
Running tclint on the test-cases in gdb.tui shows a few problems: ... $ ( cd gdb/testsuite/gdb.tui; tclint --ignore line-length *.exp ) compact-source.exp:58:28: expression with substitutions should be enclosed by \ braces [unbraced-expr] compact-source.exp:60:27: expression with substitutions should be enclosed by \ braces [unbraced-expr] compact-source.exp:68:32: expression with substitutions should be enclosed by \ braces [unbraced-expr] empty.exp:68:2: eval received an argument with a substitution, unable to \ parse its arguments [command-args] new-layout.exp:84:2: eval received an argument with a substitution, unable \ to parse its arguments [command-args] source-search.exp:33:25: expression with substitutions should be enclosed by \ braces [unbraced-expr] wrap-line.exp:40:21: expression with substitutions should be enclosed by \ braces [unbraced-expr] wrap-line.exp:44:14: expression with substitutions should be enclosed by \ braces [unbraced-expr] wrap-line.exp:62:40: expression with substitutions should be enclosed by \ braces [unbraced-expr] ... Fix these. Tested on aarch64-linux.
7 daysgdb/gdbserver: pass inferior arguments as a single stringAndrew Burgess8-95/+265
GDB holds the inferior arguments as a single string. Currently when GDB needs to pass the inferior arguments to a remote target as part of a vRun packet, this is done by splitting the single argument string into its component arguments by calling gdb::remote_args::split, which uses the gdb_argv class to split the arguments for us. The same gdb_argv class is used when the user has asked GDB/gdbserver to start the inferior without first invoking a shell; the gdb_argv class is used to split the argument string into it component arguments, and each is passed as a separate argument to the execve call which spawns the inferior. There is however, a problem with using gdb_argv to split the arguments before passing them to a remote target. To understand this problem we must first understand how gdb_argv is used when invoking an inferior without a shell. And to understand how gdb_argv is used to start an inferior without a shell, I feel we need to first look at an example of starting an inferior with a shell. Consider these two cases: (a) (gdb) set args \$VAR (b) (gdb) set args $VAR When starting with a shell, in case (a) the user expects the inferior to receive a literal '$VAR' string as an argument, while in case (b) the user expects to see the shell expanded value of the variable $VAR. If the user does 'set startup-with-shell off', then in (a) GDB will strip the '\' while splitting the arguments, and the inferior will be passed a literal '$VAR'. In (b) there is no '\' to strip, so also in this case the inferior will receive a literal '$VAR', remember startup-with-shell is off, so there is no shell that can ever expand $VAR. Notice, that when startup-with-shell is off, we end up with a many to one mapping, both (a) and (b) result in the literal string $VAR being passed to the inferior. I think this is the correct behaviour in this case. However, as we use gdb_argv to split the remote arguments we have the same many to one mapping within the vRun packet. But the vRun packet will be used when startup-with-shell is both on and off. What this means is that when gdbserver receives a vRun packet containing '$VAR' it doesn't know if GDB actually had '$VAR', or if GDB had '\$VAR'. And this is a huge problem. We can address this by making the argument splitting for remote targets smarter, and I do have patches that try to do this in this series: https://inbox.sourceware.org/gdb-patches/cover.1730731085.git.aburgess@redhat.com That series was pretty long, and wasn't getting reviewed, so I'm pulling the individual patches out and posting them separately. This patch doesn't try to improve remote argument splitting. I think that splitting and then joining the arguments is a mistake which can only introduce problems. The patch in the above series which tries to make the splitting and joining "smarter" handles unquoted, single quoted, and double quoted strings. But that doesn't really address parameter substitution, command substitution, or arithmetic expansion. And even if we did try to address these cases, what rules exactly would we implement? Probably POSIX shell rules, but what if the remote target doesn't have a POSIX shell? The only reason we're talking about which shell rules to follow is because the splitting and joining logic needs to mirror those rules. If we stop splitting and joining then we no longer need to care about the target's shell. Clearly, for backward compatibility we need to maintain some degree of argument splitting and joining as we currently have; and that's why I have a later patch (see the series above) that tries to improve that splitting and joining a little. But I think, what we should really do, is add a new feature flag (as used by the qSupported packet) and, if GDB and the remote target agree, we should pass the inferior arguments as a single string. This solves all our problems. In the startup with shell case, we no longer need to worry about splitting at all. The arguments are passed unmodified to the remote target, that can then pass the arguments to the shell directly. In the 'startup-with-shell off' case it is now up to the remote target to split the arguments, though in gdbserver we already did this, so nothing really changes in this case. And if the remote target doesn't have a POSIX shell, well GDB just doesn't need to worry about it! Something similar to this was originally suggested in this series: https://inbox.sourceware.org/gdb-patches/20211022071933.3478427-1-m.weghorn@posteo.de/ though this series didn't try to maintain backward compatibility, which I think is an issue that my patch solves. Additionally, this series only passed the arguments as a single string in some cases, I've simplified this so that, when GDB and the remote agree, the arguments are always passed as a single string. I think this is a little cleaner. I've also added documentation and some tests with this commit, including ensuring that we test both the new single string approach, and the fallback split/join approach. I've credited the author of the referenced series as co-author as they did come to a similar conclusion, though I think my implementation is different enough that I'm happy to list myself as primary author. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=28392 Co-Authored-By: Michael Weghorn <m.weghorn@posteo.de> Reviewed-By: Eli Zaretskii <eliz@gnu.org> Tested-By: Guinevere Larsen <guinevere@redhat.com> Approved-by: Kevin Buettner <kevinb@redhat.com>
7 daysgdb/gdbserver: add a '--no-escape-args' command line optionMichael Weghorn7-55/+441
This introduces a new '--no-escape-args' option for gdb and gdbserver. I (Andrew Burgess) have based this patch from work done in this series: https://inbox.sourceware.org/gdb-patches/20211022071933.3478427-1-m.weghorn@posteo.de/ I have changed things slightly from the original series. I think this work is close enough that I've left the original author (Michael) in place and added myself as co-author. Any bugs introduced by my modifications to the original patch should be considered mine. I've also added documentation and tests which were missing from the originally proposed patch. When the startup-with-shell option is enabled, arguments passed directly as 'gdb --args <args>' or 'gdbserver <args>', are by default escaped so that they are passed to the inferior as passed on the command line, no globbing or variable substitution happens within the shell GDB uses to start the inferior. For gdbserver, this is the case since commit: commit bea571ebd78ee29cb94adf648fbcda1e109e1be6 Date: Mon May 25 11:39:43 2020 -0400 Use construct_inferior_arguments which handles special chars Only arguments set via 'set args <args>', 'run <args>', or through the Python API are not escaped in standard upstream GDB right now. For the 'gdb --args' case, directly setting unescaped args on gdb invocation is possible e.g. by using the "--eval-command='set args <args>'", while this possibility does not exist for gdbserver. This commit adds a new '--no-escape-args' command line option for GDB and gdbserver. This option is used with GDB as a replacement for the current '--args' option, and for gdbserver this new option is a flag which changes how gdbserver handles inferior arguments on the command line. When '--no-escape-args' is used inferior arguments passed on the command line will not have escaping added by GDB or gdbserver. For gdbserver, using this new option allows having the behaviour from before commit bea571ebd78ee29cb94adf648fbcda1e109e1be6, while keeping the default behaviour unified between GDB and GDBserver. For GDB the --no-escape-args option can be used as a replacement for --args, like this: shell> gdb --no-escape-args my-program arg1 arg2 arg3 While for gdbserver, the --no-escape-args option is a flag, which can be used like: shell> gdbserver --no-escape-args --once localhost:54321 \ my-program arg1 arg2 arg3 Co-Authored-By: Andrew Burgess <aburgess@redhat.com> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=28392 Reviewed-By: Eli Zaretskii <eliz@gnu.org> Tested-By: Guinevere Larsen <guinevere@redhat.com>
7 dayslibsframe: testsuite: Fix testsuite build on Solaris [PR33168]Rainer Orth15-135/+98
As reported in PR libsframe/33168, the libsframe tests don't build on Solaris. The failure is In file included from libsframe/testsuite/libsframe.decode/be-flipping.c:28: /usr/include/dejagnu.h:48:1: error: conflicting types for ‘wait’; have ‘void(void)’ 48 | wait (void) | ^~~~ In file included from /usr/include/stdlib.h:16, from libsframe/testsuite/libsframe.decode/be-flipping.c:21: /usr/include/sys/wait.h:85:14: note: previous declaration of ‘wait’ with type ‘pid_t(int *)’ {aka ‘long int(int *)’} 85 | extern pid_t wait(int *); | ^~~~ We have a combination of two factors here: * Solaris <stdlib.h> has and configure.ac predefines __EXTENSIONS__ due to the use of AC_USE_SYSTEM_EXTENSIONS. * This conflicts with <dejagnu.h>'s definition void wait (void) { ... } While this version of wait was removed in upstream DejaGnu, the removal only happened after the latest release, 1.6.3. To avoid this, I've moved all testsuite includes into a new sframe-test.h, adding a workaround for the wait conflict. -Wall and -I$(srcdir) have been removed from AM_CPPFLAGS since they don't seem to be needed. To fix the Makefile fragment duplication, the local.mk files now use $(testsuite_LDADD) and $(testsuite_CPPFLAGS) throughout. Tested on {i386,amd64}-pc-solaris2.11, {sparc,sparcv9}-sun-solaris2.11, {x86_64,i686}-pc-linux-gnu, and amd64-pc-freebsd14.0. Coauthored-By: Alan Modra <amodra@gmail.com> 2025-08-31 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> Alan Modra <amodra@gmail.com> libsframe: PR libsframe/33168 * testsuite/sframe-test.h: New file. * testsuite/libsframe.decode/be-flipping.c: Replace includes by sframe-test.h. * testsuite/libsframe.decode/frecnt-1.c: Likewise. * testsuite/libsframe.decode/frecnt-2.c: Likewise. * testsuite/libsframe.encode/encode-1.c: Likewise. * testsuite/libsframe.find/findfre-1.c: Likewise. * testsuite/libsframe.find/findfunc-1.c: Likewise. * testsuite/libsframe.find/plt-findfre-1.c: Likewise. * testsuite/libsframe.find/plt-findfre-2.c: Likewise. * Makefile.am (AM_CPPFLAGS): Remove -I$(srcdir). * Makefile.in: Regenerate. * testsuite/local.mk (testsuite_LDADD): New variable. (testsuite_CPPFLAGS): Likewise. * testsuite/libsframe.decode/local.mk: Use $(testsuite_LDADD), $(testsuite_CPPFLAGS). * testsuite/libsframe.encode/local.mk: Likewise. * testsuite/libsframe.find/local.mk: Likewise.
8 days[gdb/testsuite, tclint] Fix gdb.testsuiteTom de Vries3-8/+8
Running tclint on the test-cases in gdb.testsuite shows a few problems: ... board-sanity.exp:47:38: line has trailing whitespace [trailing-whitespace] board-sanity.exp:83:1: line has trailing whitespace [trailing-whitespace] board-sanity.exp:95:38: line has trailing whitespace [trailing-whitespace] gdb-caching-proc-consistency.exp:66:2: expected braced word or word without \ substitutions in argument interpreted as expr [command-args] gdb-caching-proc-consistency.exp:117:12: eval received an argument with a \ substitution, unable to parse its arguments [command-args] with-override.exp:53:18: expression with substitutions should be enclosed by \ braces [unbraced-expr] with-override.exp:57:18: expression with substitutions should be enclosed by \ braces [unbraced-expr] ... Fix these. Tested on x86_64-linux.
8 days[gdb/testsuite] Remove gdb.testsuite/lmap.expTom de Vries1-20/+0
Test-case gdb.testsuite/lmap.exp was added to test a local definition of lmap in lib/gdb.exp. That one has been removed in commit e447f3a122c ("Require Tcl 8.6.2"). Remove the unnecessary test-case.
8 daysRISC-V: Also, fixed more ld testcases for --with-arch and --with-abiNelson Chu6-6/+12
Well these testcases cannot be fixed by .option norvc simply, that is because current linker needs to check mapping symbols before doing any rvc relaxations, https://github.com/riscv-non-isa/riscv-elf-psabi-doc/pull/393 Once we support the above features, we can revert this patch.
8 daysRISC-V: Fixed more testcases for --with-arch and --with-abiNelson Chu5-1/+5
Same as cabae1c1c87d5f4ba28b7fdafe735b7c6207fb78
8 daysAutomatic date update in version.inGDB Administrator1-1/+1
generated by cgit v1.1 at 2025-09-19 19:49:48 +0000