aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2024-04-30testsuite: libsframest: more renamesusers/ibhagat/sframe-stacktracer-testsuiteIndu Bhagat4-36/+36
and fixing some formatting issues. ChangeLog: * include/sframe-stacktrace-api.h * sframe-stacktrace.c * sframe-state.c * sframe-state.h
2024-04-30testsuite: libsframest: create new sframest_sfinfo_initIndu Bhagat2-65/+36
ChangeLog: * sframe-state.c * sframe-state.h
2024-04-30testsuite: libsframest: define a new function sframest_sfinfo_addr_range_pIndu Bhagat3-38/+23
Use this function consistently and remove unnecessary API sframest_update_sfinfo. ChangeLog: * sframe-stacktrace.c * sframe-state.c * sframe-state.h
2024-04-30more renames for readabilityIndu Bhagat3-48/+49
ChangeLog: * sframe-stacktrace.c * sframe-state.c * sframe-state.h
2024-04-30testsuite: libsframest: rename for readabilityIndu Bhagat3-116/+129
Some struct names and member names were long and unintuitive. Reduce the technical debt and make the code hopefully easier to maintain. libsframe/testsuite/ * libsframe.stacktrace/libsframest/sframe-stacktrace.c * libsframe.stacktrace/libsframest/sframe-state.c * libsframe.stacktrace/libsframest/sframe-state.h
2024-04-30testsuite: libsframest: use shorter version in conditionalsIndu Bhagat2-31/+33
libsframe/testsuite/ * libsframe.stacktrace/libsframest/sframe-stacktrace.c * libsframe.stacktrace/libsframest/sframe-state.c
2024-04-30libsframest: use access API instead of direct access using FRE infoIndu Bhagat1-2/+2
libsframe/testsuite/ * libsframe.stacktrace/libsframest/sframe-backtrace.c
2024-04-25lisbframest: remove unnecessary arch-specific codeIndu Bhagat1-20/+4
ChangeLog: * libsframe/testsuite/libsframe.stacktrace/libsframest /sframe-stacktrace.c (sframe_unwind): Remove unnecessary guards and arch-specific handling.
2024-04-25testsuite: minor housekeepingIndu Bhagat5-25/+24
Fix some code formatting nits. libsframe/testsuite/ * libsframe.stacktrace/libsframest/sframe-stacktrace-err.c: * libsframe.stacktrace/libsframest/sframe-stacktrace.c: * libsframe.stacktrace/libsframest/sframe-state.c: * libsframe.stacktrace/libsframest/sframe-state.h: * libsframe.stacktrace/stacktrace-inline-2.c:
2024-04-25testsuite: libsframest: use as, ld, collect-ld from build dirIndu Bhagat11-94/+68
instead of host's as and ld. Also disable libsframest build if cross compiling. The testsuite will consequently also be skipped. Override the check-am make target and first execute setup.sh to bring in the as-new / ld-new and use -B<path> to ensure these are picked up for building: - libsframest - libsframe.stacktrace testsuite Remove the configure time variable HAVE_SFRAME_AS as it is now unnecessary. TBD: - Get review on whether the whole setup.sh way of doing this is OK. But it seems there is no other way ? - Check the portability of the setup.sh script. ChangeLog: * libsframe/Makefile.am: Override check-am to first run setup.sh before invoking make. This ensures libsframest is built with the newly setup tmpdir/libsframe. * libsframe/Makefile.in: Regenerate. * libsframe/acinclude.m4: Delete. * libsframe/aclocal.m4: Remove include for acinclude.m4. * libsframe/configure: Regenerate. * libsframe/configure.ac: Remove HAVE_SFRAME_AS. Add a new AM_CONDITIONAL for CROSS_COMPILE. * libsframe/setup.sh: New file. * libsframe/testsuite/config/default.exp: Remove the creation and setup of tmpdir/lisframe. * libsframe/testsuite/lib/sframe-lib.exp: Use -B<path> to use the as/ld from build tree. * libsframe/testsuite/libsframe.stacktrace/libsframest/local.mk: Use -B<path> and use the as/ld from build tree. * libsframe/testsuite/libsframe.stacktrace/stacktrace.exp: Skip testing if cross build.
2024-04-25libsframest: use as a test tool insteadIndu Bhagat48-789/+1068
Add a configure time check for dl_iterate_phdr and run libsframe.stacktrace testsuite using libsframest. libsframest is the library for stack tracing using the SFrame stack trace format. libsframest is not installed anymore but used in the testsuite only. TBD: - More renamings are in order. - Cleanup the .exp files. - Disable (libsframest based) stack tracer tests in a cross build
2024-04-25testsuite: sframebt: Add backtrace-1 which uses -O2 alwaysIndu Bhagat2-0/+116
Keep a testcase with an explicit -O2 for testing purposes.
2024-04-25testsuite: sframebt: Use -fno-optimize-sibling-callsWeimin Pan2-2/+2
With -O2 and above, the compiler performs a sibling call optimization as main () and it's callee have compatible stack usage. As for generating stack traces though, there is nothing that any stack trace or unwind format can do here. Use -fno-optimize-sibling-calls to at least ensure the testcase checkes for the complete stack trace. ChangeLog: * libsframe/testsuite/libsframe.unwind/backtrace-fp-attr-1.lk: Use -fno-optimize-sibling-calls. * libsframe/testsuite/libsframe.unwind/backtrace-fp-attr-2.lk: Likewise.
2024-04-25sframebt: Factor register access code into a header fileWeimin Pan2-14/+84
ChangeLog: * libsframe/sframe-backtrace-regs.h: New file. * libsframe/sframe-backtrace.c: Use the new abstractions.
2024-04-25unwinder: Add SFrame unwinder testsWeimin Pan27-81/+1533
[Changes in V4] - Addressed Mike's review comments. - Be careful with the use of # and dnl in configure.ac - Add AC_CANONICAL_TARGET as we check for target. - Remove the LC_ALL=C bits. - Minor code fixups in the testcases - Removed unnecessary unistd.h. - use ATTRIBUTE_NOCLONE consistently. - Other minor cleanups. [End of changes in V4] [Changes in V3] - Added two new tests with attributes -f(no-)omit-frame-pointer. - Minor adjustments due to buildsystem changes in libsframe. [End of changes in V3] [Changes in V2] - minor changes in filenames in the testsuite. [End of changes in V2] Add tests for backtracing using SFrame section. ChangeLog: * libsframe/Makefile.in: Regenerated. * libsframe/configure: Regenerated. * libsframe/configure.ac: Check for cross compilation. * libsframe/testsuite/Makefile.in: Regenerated. * libsframe/testsuite/config/default.exp: Load sframe-lib.exp. * libsframe/testsuite/libsframe.decode/Makefile.in: Regenerated. * libsframe/testsuite/libsframe.encode/Makefile.in: Regenerated. * libsframe/testsuite/lib/sframe-lib.exp: New file. Add procedures for handling unwinder tests. * libsframe/testsuite/libsframe.unwind/backtrace.c: New test. * libsframe/testsuite/libsframe.unwind/backtrace.lk: New test. * libsframe/testsuite/libsframe.unwind/inline-cmds.c: New test. * libsframe/testsuite/libsframe.unwind/inline-cmds.lk: New test. * libsframe/testsuite/libsframe.unwind/inline.c: New test. * libsframe/testsuite/libsframe.unwind/inline.lk: New test. * libsframe/testsuite/libsframe.unwind/solib-lib1.c: New test. * libsframe/testsuite/libsframe.unwind/solib-lib2.c: New test. * libsframe/testsuite/libsframe.unwind/solib-main.c: New test. * libsframe/testsuite/libsframe.unwind/solib-main.d: New test. * libsframe/testsuite/libsframe.unwind/solib.exp: New file. * libsframe/testsuite/libsframe.unwind/solib-lib1.h: New test. * libsframe/testsuite/libsframe.unwind/solib-lib2.h: New test. * libsframe/testsuite/libsframe.unwind/tailcall.c: New test. * libsframe/testsuite/libsframe.unwind/tailcall.lk: New test. * libsframe/testsuite/libsframe.unwind/ttest.c: New test. * libsframe/testsuite/libsframe.unwind/ttest.lk: New test. * libsframe/testsuite/libsframe.unwind/unwind.exp: New file. * libsframe/testsuite/libsframe.unwind/backtrace-fp-attr-1.c: Likewise. * libsframe/testsuite/libsframe.unwind/backtrace-fp-attr-1.lk: Likewise. * libsframe/testsuite/libsframe.unwind/backtrace-fp-attr-2.c: Likewise. * libsframe/testsuite/libsframe.unwind/backtrace-fp-attr-2.lk: Likewise.
2024-04-25unwinder: generate backtrace using SFrame formatWeimin Pan9-17/+878
[Changes in V4] - Renamed ESFRAME_* enum error code names to SFRAME_ERR_*. - Addressed review comments by Mike. - Use AC_CACHE_CHECK macro in sframe.m4 - Delete config/sframe.m4. Add into libsframe/acinclude.m4. - Code fixups. [End of changes in V4] [Changes in V3] - Use the updated APIs from libsframe. - Use sframe_decoder_get_fixed_ra_offset on AMD64 instead of magic number -8. [End of changes in V3] [Changes in V2] - Minor formatting fixes. [End of changes in V2] A simple unwinder based on SFrame format. The unwinder is made available via libsframebt library. Buildsystem changes have been made to build libsframebt only when --gsframe support is available in the assembler. These buildsystem changes are necessary because the SFrame based unwinder the SFrame unwind info for itself to work. include/ChangeLog: * sframe-backtrace-api.h: New file. ChangeLog: * libsframe/acinclude.m4: New file. * libsframe/Makefile.am: Build backtrace functionality in its own library. Install libsframebt conditionally. * libsframe/Makefile.in: Regenerate. * libsframe/aclocal.m4: Regenerate. * libsframe/configure: Regenerate. * libsframe/configure.ac: Check if gas supports --gsframe command line option. * libsframe/sframe-backtrace-err.c: New file. * libsframe/sframe-backtrace.c: New file.
2024-04-25bpf: fix calculation when deciding to relax branchDavid Faust7-43/+95
In certain cases we were calculating the jump displacement incorrectly when deciding whether to relax a branch. This meant for some branches, such as a very long backwards conditional branch, relaxation was not done when it should have been. The result was to error later, because the actual jump displacement was too large to fit in the original instruction. This patch fixes up the displacement calculation so that those branches are correctly relaxed and no longer result in an error. In addition, it changes md_convert_frag to install fixups for the JAL instructions in the resulting relaxations rather than encoding the displacement value directly. gas/ * config/tc-bpf.c (relaxed_branch_length): Correct displacement calculation when relaxing. (md_convert_frag): Likewise. Install fixups for JAL instructions resulting from relaxation. * testsuite/gas/bpf/jump-relax-ja-be.d: Correct and expand test. * testsuite/gas/bpf/jump-relax-ja.d: Likewise. * testsuite/gas/bpf/jump-relax-ja.s: Likewise. * testsuite/gas/bpf/jump-relax-jump-be.d: Likewise. * testsuite/gas/bpf/jump-relax-jump.d: Likewise. * testsuite/gas/bpf/jump-relax-jump.s: Likewise.
2024-04-25gdb: add type annotations to ada-unicode.pySimon Marchi1-37/+61
Add type annotations to ada-unicode.py, just enough to make pyright happy: $ pyright --version pyright 1.1.359 $ pyright ada-unicode.py 0 errors, 0 warnings, 0 informations Introduce a `Range` class instead of using separate variables and tuples, to make the code and type annotations a bit cleaner. When running ada-unicode.py, I get a diff for ada-casefold.h, but I get the same diff before and after this patch, so that is a separate issue. Change-Id: I0d8975a57f9fb115703178ae197dc6b6b8b4eb7a Approved-By: Tom Tromey <tom@tromey.com>
2024-04-25gdb: remove gdbcmd.hSimon Marchi176-207/+163
Most files including gdbcmd.h currently rely on it to access things actually declared in cli/cli-cmds.h (setlist, showlist, etc). To make things easy, replace all includes of gdbcmd.h with includes of cli/cli-cmds.h. This might lead to some unused includes of cli/cli-cmds.h, but it's harmless, and much faster than going through the 170 or so files by hand. Change-Id: I11f884d4d616c12c05f395c98bbc2892950fb00f Approved-By: Tom Tromey <tom@tromey.com>
2024-04-25gdb: move style_set_list/style_show_list declarations to cli/cli-style.hSimon Marchi2-4/+4
They are defined in cli/cli-style.c. Change-Id: Ic478a3985ff0fd773bd7ba85bb144c6e914d0be6 Approved-By: Tom Tromey <tom@tromey.com>
2024-04-25gdb: remove unused print_command_line and print_command_lines declarationsSimon Marchi1-5/+0
There is no corresponding definition for print_command_line. There is already a declaration for print_command_lines in cli/cli-script.h (the implementation is in cli/cli-script.c). Change-Id: Ic9e67ed04703306d614383ead14e2b2b059b2a8e Approved-By: Tom Tromey <tom@tromey.com>
2024-04-25gdb: move execute function declarations from gdbcmd.h to top.hSimon Marchi10-37/+38
These functions are implemented in top.c, move their declarations to top.h. Change-Id: I8893ef91d955156a6530734fefe8002d78c3e5fc Approved-By: Tom Tromey <tom@tromey.com>
2024-04-25LoongArch: gas: Simplify relocations in sections without code flagJinyang He3-3/+19
Gas should not emit ADD/SUB relocation pairs for label differences if they are in the same section without code flag even relax enabled. Because the real value is not be affected by relaxation and it can be compute out in assembly stage. Thus, correct the `TC_FORCE_RELOCATION _SUB_SAME` and the label differences in same section without code flag can be resolved in fixup_segment().
2024-04-25LoongArch: Add bad static relocation check and output more information to userLulu Cai8-2/+76
Absolute address symbols cannot be used with -shared. We output more information to the user than just BFD_ASSETR.
2024-04-25LoongArch: The symbol got type can only be obtained after initializationLulu Cai1-1/+8
When scanning relocations and determining whether TLS type transition is possible, it will try to obtain the symbol got type. If the symbol got type record has not yet been allocated space and initialized, it will cause ld to crash. So when uninitialized, the symbol is set to GOT_UNKNOWN.
2024-04-25Automatic date update in version.inGDB Administrator1-1/+1
2024-04-24gdb/testsuite: Add libc_has_debug_info require helperThiago Jung Bauermann2-12/+57
Factor the test for libc debug info out of gdb.base/relativedebug.exp to a new procedure. Also, change the "info sharedlibrary" test to explicitly detect when libc has debug info. Approved-by: Kevin Buettner <kevinb@redhat.com>
2024-04-24gdb/doc: Fix incorrect information in RSP docCiaran Woodward1-1/+1
The 'PacketSize' attribute of the qSupported packet was documented to be the maximum size of the packet including the frame and checksum bytes, however this is not how it was treated in the code. In reality, PacketSize is the maximum size of the data in the RSP packets, not including the framing or checksum bytes. For instance, GDB's remote.c treats it as the maximum number of data bytes. See remote_read_bytes_1, where the size of the request is capped at PacketSize/2 (for hex-encoding). Also see gdbserver's server.cc, where the internal buffer is sized as PBUFSIZ and PBUFSIZ-1 is used as PacketSize. In gdbserver's case, the buffer is not used for any of the framing or checksum characters. (I am not certain where the -1 comes from. I think it comes from back when there were no binary packets, so packets were treated as strings with null terminators). It also seems like gdbservers in the wild treat it in this way: Embocosm doc: https://www.embecosm.com/appnotes/ean4/embecosm-howto-rsp-server-ean4-issue-2.html#id3078000 A quick glance over openocd's gdb_server.c gdb_put_packet_inner() function shows that the internal buffer also excludes the framing and checksum. Likewise, qEmu's gdbstub.c allocates PacketSize bytes for the internal packet contents, and PacketSize+4 for the full frame. Reviewed-By: Eli Zaretskii <eliz@gnu.org> Approved-By: Pedro Alves <pedro@palves.net>
2024-04-24Handle two-linetable function in find_epilogue_using_linetableBernd Edlinger6-160/+284
Consider the following test-case: ... $ cat hello.c int main() { printf("hello "); #include "world.inc" $ cat world.inc printf("world\n"); return 0; } $ gcc -g hello.c ... The line table for the compilation unit, consisting just of function main, is translated into these two gdb line tables, one for hello.c and one for world.inc: ... compunit_symtab: hello.c symtab: hello.c INDEX LINE REL-ADDRESS UNREL-ADDRESS IS-STMT PROLOGUE-END EPILOGUE-BEGIN 0 3 0x400557 0x400557 Y 1 4 0x40055b 0x40055b Y 2 END 0x40056a 0x40056a Y compunit_symtab: hello.c symtab: world.inc INDEX LINE REL-ADDRESS UNREL-ADDRESS IS-STMT PROLOGUE-END EPILOGUE-BEGIN 0 1 0x40056a 0x40056a Y 1 2 0x400574 0x400574 Y 2 3 0x400579 0x400579 Y 3 END 0x40057b 0x40057b Y ... The epilogue of main starts at 0x400579: ... 400579: 5d pop %rbp 40057a: c3 ret ... Now, say we have an epilogue_begin marker in the line table at 0x400579. We won't find it using find_epilogue_using_linetable, because it does: ... const struct symtab_and_line sal = find_pc_line (start_pc, 0); ... which gets us the line table for hello.c. Fix this by using "find_pc_line (end_pc - 1, 0)" instead. Tested on x86_64-linux. Co-Authored-By: Tom de Vries <tdevries@suse.de> PR symtab/31622 Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31622
2024-04-24Fix an out of bounds array access in find_epilogue_using_linetableBernd Edlinger1-10/+84
An out of bounds array access in find_epilogue_using_linetable causes random test failures like these: FAIL: gdb.base/unwind-on-each-insn-amd64.exp: foo: instruction 6: $fba_value == $fn_fba FAIL: gdb.base/unwind-on-each-insn-amd64.exp: foo: instruction 6: check frame-id matches FAIL: gdb.base/unwind-on-each-insn-amd64.exp: foo: instruction 6: bt 2 FAIL: gdb.base/unwind-on-each-insn-amd64.exp: foo: instruction 6: up FAIL: gdb.base/unwind-on-each-insn-amd64.exp: foo: instruction 6: $sp_value == $::main_sp FAIL: gdb.base/unwind-on-each-insn-amd64.exp: foo: instruction 6: $fba_value == $::main_fba FAIL: gdb.base/unwind-on-each-insn-amd64.exp: foo: instruction 6: [string equal $fid $::main_fid] Here the read happens below the first element of the line table, and the test failure depends on the value that is read from there. It also happens that std::lower_bound returns a pointer exactly at the upper bound of the line table, also here the read value is undefined, that happens in this test: FAIL: gdb.dwarf2/dw2-epilogue-begin.exp: confirm watchpoint doesn't trigger Fixes: 528b729be1a2 ("gdb/dwarf2: Add support for DW_LNS_set_epilogue_begin in line-table") Co-Authored-By: Tom de Vries <tdevries@suse.de> PR symtab/31268 Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31268
2024-04-24[gdb/testsuite] Fix gdb.threads/threadcrash.exp for remote hostTom de Vries1-5/+3
With test-case gdb.threads/threadcrash.exp using host board local-remote-host and target board remote-gdbserver-on-localhost I run into: ... (gdb) PASS: gdb.threads/threadcrash.exp: test_gcore: continue to crash gcore $outputs/gdb.threads/threadcrash/threadcrash.gcore^M Failed to open '$outputs/gdb.threads/threadcrash/threadcrash.gcore' for output.^M (gdb) FAIL: gdb.threads/threadcrash.exp: test_gcore: saving gcore UNSUPPORTED: gdb.threads/threadcrash.exp: test_gcore: couldn't generate gcore file ... The problem is that the gcore command tries to save a file on a remote host, but the filename is a location on build. Fix this by using host_standard_output_file. Tested on x86_64-linux.
2024-04-24[gdb/testsuite] Fix gdb.threads/threadcrash.exp with glibc debuginfoTom de Vries1-1/+1
After installing glibc debuginfo, I ran into: ... FAIL: gdb.threads/threadcrash.exp: test_live_inferior: \ $thread_count == [llength $test_list] ... This happens because the clause: ... -re "^\r\n${hs}main$hs$eol" { ... which is intended to match only: ... #1 <hex> in main () at threadcrash.c:423^M ... also matches "remaining" in: ... #1 <hex> in __GI___nanosleep (requested_time=<hex>, remaining=<hex>) at \ nanosleep.c:27^M ... Fix this by checking for "in main" instead. Tested on x86_64-linux.
2024-04-24Update readelf's display of RELR sections to include the number of locations ↵Nick Clifton14-33/+128
relocated
2024-04-24gdb: include extract-store-integer.h in charset.c when PHONY_ICONVSimon Marchi1-0/+2
When building on a system where "phony iconv" is used (NetBSD in this case, not sure why), I get: CXX charset.o /home/smarchi/src/binutils-gdb/gdb/charset.c: In function 'size_t phony_iconv(int, const char**, size_t*, char**, size_t*)': /home/smarchi/src/binutils-gdb/gdb/charset.c:140:8: error: 'extract_unsigned_integer' was not declared in this scope = extract_unsigned_integer ((const gdb_byte *)*inbuf, 4, endian); ^~~~~~~~~~~~~~~~~~~~~~~~ /home/smarchi/src/binutils-gdb/gdb/charset.c:140:8: note: suggested alternative: 'btrace_insn_number' = extract_unsigned_integer ((const gdb_byte *)*inbuf, 4, endian); ^~~~~~~~~~~~~~~~~~~~~~~~ btrace_insn_number Add the necessary include. Change-Id: I10b967584645961c86167a8395d88929a42bef03
2024-04-24PPC maintainersAlan Modra1-2/+1
I'm retiring from IBM, and Geoff hasn't been active for a very long time. * MAINTAINERS (ppc): Remove myself and Geoff Keating. Add Geoff to past maintainers.
2024-04-24buffer overflow in libctf testsAlan Modra2-2/+2
* testsuite/libctf-regression/gzrewrite.c (main): Don't overflow "a" buffer in "after adding types" check. * testsuite/libctf-regression/zrewrite.c (main): Likewise.
2024-04-24Automatic date update in version.inGDB Administrator1-1/+1
2024-04-23gdb: adjust copyright years of extract-store-integer.{c,h}Simon Marchi2-2/+2
The contents of these files was copied from defs.h and findvar. Copy over the copyright years (1986-2024). Change-Id: Idfb0f255fbcfda7e107e9a82804cece3d81ed5fc
2024-04-23arm: Fix MVE vmla encodingClaudio Bantaloukas4-1356/+2042
2024-04-23bfd: Remove duplicate word in elf-vxworks.cOlivier Hainque1-1/+1
PR ld/31652 * elf-vxworks.c (elf_vxworks_emit_relocs): Drop duplicate word.
2024-04-23objcopy.c: Fix bfd_copy_private_symbol_data on 32-bit hostsH.J. Lu1-2/+2
Use long with bfd_copy_private_symbol_data to fix .../binutils/objcopy.c: In function ‘copy_object’: .../binutils/objcopy.c:3383:17: error: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘long int’ [-Werror=sign-compare] 3383 | for (i = 0; i < symcount; i++) | ^ on 32-bit hosts. PR binutils/14493 * objcopy.c (copy_object): Use long with bfd_copy_private_symbol_data.
2024-04-23gdb: move symbol_file_command declaration to symfile.hSimon Marchi3-17/+17
Move it out of defs.h, the corresponding definition is in symfile.c. Change-Id: I984666c3bcd213f8574e9ec91462e1d61f77f16b Approved-By: Tom Tromey <tom@tromey.com>
2024-04-23gdb: remove enum precision_typeSimon Marchi1-7/+0
It is unused. Change-Id: Ic49a3ef03c21b209594cd567ae80b5441606bef6 Approved-By: Tom Tromey <tom@tromey.com>
2024-04-23gdb: move annotation_level declaration/definition to annotate.{h,c}Simon Marchi5-14/+13
The declaration of annotation_level is currently in defs.h, while the definition is in stack.c. I don't really understand why that variable would live in stack.c, it seems completely unrelated. Move it to annotate.c, and move the declaration to annotate.h. Change-Id: I6cf8e9bd20e83959bdf5ad58dd008b6e1187d7d8 Approved-By: Tom Tromey <tom@tromey.com>
2024-04-23gdb: move a bunch of quit-related things to event-top.{c,h}Simon Marchi51-88/+144
Move some declarations related to the "quit" machinery from defs.h to event-top.h. Most of the definitions associated to these declarations are in event-top.c. The exceptions are `quit()` and `maybe_quit()`, that are defined in utils.c. For consistency, move these two definitions to event-top.c. Include "event-top.h" in many files that use these things. Change-Id: I6594f6df9047a9a480e7b9934275d186afb14378 Approved-By: Tom Tromey <tom@tromey.com>
2024-04-23gdb: change type of quit_flag to boolSimon Marchi2-5/+5
Change-Id: I7dc5189ee172e82ef5b2c4a739c011f43a84258b Approved-By: Tom Tromey <tom@tromey.com>
2024-04-23gdb: change return type of check_quit_flag to boolSimon Marchi5-12/+12
Change the return type of the check_quit_flag function to bool. Update a few related spots. Change-Id: I9d3a15d3f8651efb02c7d211f06222a592bd4184 Approved-By: Tom Tromey <tom@tromey.com>
2024-04-23gdb: move declarations of check_quit_flag and set_quit_flag to extension.hSimon Marchi3-32/+34
Move them out of defs.h, to extension.h, since the implementations are in extension.c. Change-Id: Ie7321468bd7fecc684d70b09f72c3ee8ac75d8f4 Approved-By: Tom Tromey <tom@tromey.com>
2024-04-23gdb: remove unused include in infrun.cSimon Marchi1-1/+1
Remove the gdbcmd.h, which is reported as unused by clangd. Add cli/cli-cmds.h instead, to get access to `cmdlist` and friends. Change-Id: Ic0c60d2f6d3618f1bd9fd80b95ffd7c33c692a04
2024-04-23objdump: Round ASCII art lines in jump visualizationWaqar Hameed1-4/+4
generated by cgit v1.1 at 2024-06-28 04:30:05 +0000