diff options
| author | Alan Modra <amodra@gmail.com> | 2020-03-22 20:02:55 +1030 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2020-03-22 23:22:13 +1030 |
| commit | beea5cc1bc2249389dc77ea0c86ab82dafd05bb5 (patch) | |
| tree | f02333970b7f89fe382b04939f0ebe4a32303835 /opcodes | |
| parent | 03704c7704870a0e6cbb0eae99488d544c4adb30 (diff) | |
| download | gdb-beea5cc1bc2249389dc77ea0c86ab82dafd05bb5.zip gdb-beea5cc1bc2249389dc77ea0c86ab82dafd05bb5.tar.gz gdb-beea5cc1bc2249389dc77ea0c86ab82dafd05bb5.tar.bz2 | |
ARC: Use of uninitialised value
* arc-dis.c (find_format): Use ISO C string concatenation rather
than line continuation within a string. Don't access needs_limm
before testing opcode != NULL.
Diffstat (limited to 'opcodes')
| -rw-r--r-- | opcodes/ChangeLog | 6 | ||||
| -rw-r--r-- | opcodes/arc-dis.c | 7 |
2 files changed, 10 insertions, 3 deletions
diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog index 06b81d7..eb3e4c3 100644 --- a/opcodes/ChangeLog +++ b/opcodes/ChangeLog @@ -1,5 +1,11 @@ 2020-03-22 Alan Modra <amodra@gmail.com> + * arc-dis.c (find_format): Use ISO C string concatenation rather + than line continuation within a string. Don't access needs_limm + before testing opcode != NULL. + +2020-03-22 Alan Modra <amodra@gmail.com> + * ns32k-dis.c (print_insn_arg): Update comment. (print_insn_ns32k): Reduce size of index_offset array, and initialize, passing -1 to print_insn_arg for args that are not diff --git a/opcodes/arc-dis.c b/opcodes/arc-dis.c index 9662c2f..131aee6 100644 --- a/opcodes/arc-dis.c +++ b/opcodes/arc-dis.c @@ -436,8 +436,9 @@ find_format (bfd_vma memaddr, opcode = arcExtMap_genOpcode (i, isa_mask, &errmsg); if (opcode == NULL) { - (*info->fprintf_func) (info->stream, "\ -An error occured while generating the extension instruction operations"); + (*info->fprintf_func) (info->stream, + _("An error occured while generating the " + "extension instruction operations")); *opcode_result = NULL; return FALSE; } @@ -452,7 +453,7 @@ An error occured while generating the extension instruction operations"); opcode = find_format_from_table (info, arc_opcodes, insn, *insn_len, isa_mask, &needs_limm, TRUE); - if (needs_limm && opcode != NULL) + if (opcode != NULL && needs_limm) { bfd_byte buffer[4]; int status; |