diff options
| author | Nick Alcock <nick.alcock@oracle.com> | 2020-11-20 13:34:04 +0000 |
|---|---|---|
| committer | Nick Alcock <nick.alcock@oracle.com> | 2020-11-20 13:34:10 +0000 |
| commit | 0e28ade476e20bd8af917e01a3f1429a34cc1d83 (patch) | |
| tree | e71bd47c4efb2f5847743e155c07f42e6efed78e /libctf/ChangeLog | |
| parent | 0ad70c536abd64b1b913ce89e385faef34c373c0 (diff) | |
| download | gdb-0e28ade476e20bd8af917e01a3f1429a34cc1d83.zip gdb-0e28ade476e20bd8af917e01a3f1429a34cc1d83.tar.gz gdb-0e28ade476e20bd8af917e01a3f1429a34cc1d83.tar.bz2 | |
libctf, ld: properly deduplicate function types
Some type kinds in CTF (functions, arrays, pointers, slices, and
cvr-quals) are intrinsically nameless: the ctt_name field in the CTF
is always zero, and the libctf API provides no way to set a name.
But the compiler can and does sometimes set names for some of these
kinds: in particular, the name it sets on CTF_K_FUNCTION types is the
means it uses to force the name of the function into the string table
so that it can point at it from the function info section.
So null out the name at hashing time so that the deduplicator can
correctly detect that e.g. function types identical but for name should
be considered truly identical, since they will not have a name when the
deduplicator re-emits them into the output.
ld/ChangeLog
2020-11-20 Nick Alcock <nick.alcock@oracle.com>
* testsuite/ld-ctf/data-func-conflicted.d: Shrink the expected
size of the type section now that function types are being
deduplicated properly.
libctf/ChangeLog
2020-11-20 Nick Alcock <nick.alcock@oracle.com>
* ctf-dedup.c (ctf_dedup_rhash_type): Null out the names of nameless
type kinds, just in case the input has named them.
Diffstat (limited to 'libctf/ChangeLog')
| -rw-r--r-- | libctf/ChangeLog | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/libctf/ChangeLog b/libctf/ChangeLog index e81db2c..e571404 100644 --- a/libctf/ChangeLog +++ b/libctf/ChangeLog @@ -1,5 +1,10 @@ 2020-11-20 Nick Alcock <nick.alcock@oracle.com> + * ctf-dedup.c (ctf_dedup_rhash_type): Null out the names of nameless + type kinds, just in case the input has named them. + +2020-11-20 Nick Alcock <nick.alcock@oracle.com> + * ctf-dump.c (ctf_dump_header): Dump the new flags bits and the index section lengths. (ctf_dump_objts): Report indexed sections. Also dump functions. Use |