diff options
| author | Alan Modra <amodra@gmail.com> | 2020-07-09 22:48:10 +0930 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2020-07-09 22:58:16 +0930 |
| commit | c560184eb2074570988c498aaae494d0c4b00328 (patch) | |
| tree | fd84ad11e234236f0ec8f0bdd10b9a745435e72a /ld | |
| parent | 470cd0faa7f433b47944683eee4fc3dad6ef7cdf (diff) | |
| download | gdb-c560184eb2074570988c498aaae494d0c4b00328.zip gdb-c560184eb2074570988c498aaae494d0c4b00328.tar.gz gdb-c560184eb2074570988c498aaae494d0c4b00328.tar.bz2 | |
powerpc garbage collect test
ld's garbage collection test on powerpc64 catered for old compilers
(pre -mcmodel=medium support), setting options that caused the test to
fail. Which meant the test wasn't really testing anything. Get rid
of that old compiler support, and avoid -fPIE fails on ppc32.
* testsuite/ld-gc/gc.exp: Don't set -mminimal-toc for powerpc64,
and remove powerpc64 xfail. Use -fno-PIE for ppc32.
Diffstat (limited to 'ld')
| -rw-r--r-- | ld/ChangeLog | 5 | ||||
| -rw-r--r-- | ld/testsuite/ld-gc/gc.exp | 9 |
2 files changed, 8 insertions, 6 deletions
diff --git a/ld/ChangeLog b/ld/ChangeLog index fa45f16..195731e 100644 --- a/ld/ChangeLog +++ b/ld/ChangeLog @@ -1,5 +1,10 @@ 2020-07-09 Alan Modra <amodra@gmail.com> + * testsuite/ld-gc/gc.exp: Don't set -mminimal-toc for powerpc64, + and remove powerpc64 xfail. Use -fno-PIE for ppc32. + +2020-07-09 Alan Modra <amodra@gmail.com> + PR 18841 * testsuite/ld-ifunc/ifunc.exp: Run pr18841 tests non-pie. diff --git a/ld/testsuite/ld-gc/gc.exp b/ld/testsuite/ld-gc/gc.exp index ea33168..285e7d1 100644 --- a/ld/testsuite/ld-gc/gc.exp +++ b/ld/testsuite/ld-gc/gc.exp @@ -26,9 +26,9 @@ if ![check_gc_sections_available] { set cflags "-ffunction-sections -fdata-sections $NOSANTIZE_CFLAGS" set objfile "tmpdir/gc.o" -if [istarget powerpc64*-*-*] { - # otherwise with -mcmodel=medium gcc we get XPASSes. - set cflags "$cflags -mminimal-toc" +if { [istarget powerpc*-*-*] && ![istarget powerpc64*-*-*] } { + # Avoid using .got2 for powerpc -m32 + set cflags "$cflags $NOPIE_CFLAGS" } if { [istarget m681*-*-*] || [istarget m68hc1*-*-*] } { @@ -71,9 +71,6 @@ proc test_gc { testname filename linker ldflags} { fail $testname return } - #ppc64_elf_gc_mark_hook needs to be taught how to look through - #the .toc section to properly mark variable sections for gc. - setup_xfail "powerpc64*-*-*" if {[info exists nm_output(unused_func)] \ || [info exists nm_output(unused_var)]} { send_log "unused section still here\n" |