diff options
author | Alan Modra <amodra@gmail.com> | 2016-06-07 22:04:38 +0930 |
---|---|---|
committer | Alan Modra <amodra@gmail.com> | 2016-06-07 22:04:38 +0930 |
commit | 14b57c7c6a53c747a8819fed3da858eae4195a0e (patch) | |
tree | a58d1965b9a9ba6b40dfb02e9cadd008a45d44f8 /ld | |
parent | 2091da296fd563f62d856dcb5a049a63484ed65e (diff) | |
download | gdb-14b57c7c6a53c747a8819fed3da858eae4195a0e.zip gdb-14b57c7c6a53c747a8819fed3da858eae4195a0e.tar.gz gdb-14b57c7c6a53c747a8819fed3da858eae4195a0e.tar.bz2 |
PowerPC VLE
VLE is an encoding, not a particular processor architecture, so it
isn't really proper to select insns based on PPC_OPCODE_VLE. For
example
{"evaddw", VX (4, 512), VX_MASK, PPCSPE|PPCVLE, PPCNONE, {RS, RA, RB}},
{"vaddubs", VX (4, 512), VX_MASK, PPCVEC|PPCVLE, PPCNONE, {VD, VA, VB}},
shows two insns that have the same encoding, both available with VLE.
Enabling both with VLE means we can't disassemble the second variant
even if -Maltivec is given rather than -Mspe. Also, we don't check
user assembly against the processor type as well as we could.
Another problem is that when using the VLE encoding, insns from the
main ppc opcode table are not available, except those using opcode 4
and 31. Correcting this revealed two errors in the ld testsuite,
use of "nop" and "rfmci" when -mvle.
This patch fixes those problems in the opcode table, and removes
PPCNONE. I find a plain 0 distracts less from other values.
In addition, I've implemented code to recognize some machine values
from the apuinfo note present in ppc32 objects. It's not a complete
disambiguation since we're lacking info to detect newer chips, but
what we have should help with disassembly.
include/
* elf/ppc.h (APUINFO_SECTION_NAME, APUINFO_LABEL, PPC_APUINFO_ISEL,
PPC_APUINFO_PMR, PPC_APUINFO_RFMCI, PPC_APUINFO_CACHELCK,
PPC_APUINFO_SPE, PPC_APUINFO_EFS, PPC_APUINFO_BRLOCK,
PPC_APUINFO_VLE: Define.
opcodes/
* ppc-dis.c (ppc_opts): Delete extraneous parentheses. Default
cpu for "vle" to e500.
* ppc-opc.c (ALLOW8_SPRG): Remove PPC_OPCODE_VLE.
(NO371, PPCSPE, PPCISEL, PPCEFS, MULHW, DCBT_EO): Likewise.
(PPCNONE): Delete, substitute throughout.
(powerpc_opcodes): Remove PPCVLE from "flags". Add to "deprecated"
except for major opcode 4 and 31.
(vle_opcodes <se_rfmci>): Add PPCRFMCI to flags.
bfd/
* cpu-powerpc.c (powerpc_compatible): Allow bfd_mach_ppc_vle entry
to match other 32-bit archs.
* elf32-ppc.c (_bfd_elf_ppc_set_arch): New function.
(ppc_elf_object_p): Call it.
(ppc_elf_special_sections): Use APUINFO_SECTION_NAME. Fix
overlong line.
(APUINFO_SECTION_NAME, APUINFO_LABEL): Don't define here.
* elf64-ppc.c (ppc64_elf_object_p): Call _bfd_elf_ppc_set_arch.
* bfd-in.h (_bfd_elf_ppc_at_tls_transform,
_bfd_elf_ppc_at_tprel_transform): Move to..
* elf-bfd.h: ..here.
(_bfd_elf_ppc_set_arch): Declare.
* bfd-in2.h: Regenerate.
gas/
* config/tc-ppc.c (PPC_APUINFO_ISEL, PPC_APUINFO_PMR,
PPC_APUINFO_RFMCI, PPC_APUINFO_CACHELCK, PPC_APUINFO_SPE,
PPC_APUINFO_EFS, PPC_APUINFO_BRLOCK, PPC_APUINFO_VLE): Don't define.
(ppc_setup_opcodes): Check vle disables powerpc_opcodes overridden
by vle_opcodes, and that vle flag doesn't enable opcodes. Don't
add vle_opcodes twice.
(ppc_cleanup): Use APUINFO_SECTION_NAME and APUINFO_LABEL.
ld/
* testsuite/ld-powerpc/apuinfo1.s: Delete nop.
* testsuite/ld-powerpc/apuinfo-vle2.s: New.
* testsuite/ld-powerpc/powerpc.exp: Use apuinfo-vle2.s.
Diffstat (limited to 'ld')
-rw-r--r-- | ld/ChangeLog | 6 | ||||
-rw-r--r-- | ld/testsuite/ld-powerpc/apuinfo-vle2.s | 8 | ||||
-rw-r--r-- | ld/testsuite/ld-powerpc/apuinfo1.s | 3 | ||||
-rw-r--r-- | ld/testsuite/ld-powerpc/powerpc.exp | 2 |
4 files changed, 16 insertions, 3 deletions
diff --git a/ld/ChangeLog b/ld/ChangeLog index 96b844b..ac08ee6 100644 --- a/ld/ChangeLog +++ b/ld/ChangeLog @@ -1,3 +1,9 @@ +2016-06-07 Alan Modra <amodra@gmail.com> + + * testsuite/ld-powerpc/apuinfo1.s: Delete nop. + * testsuite/ld-powerpc/apuinfo-vle2.s: New. + * testsuite/ld-powerpc/powerpc.exp: Use apuinfo-vle2.s. + 2016-06-06 H.J. Lu <hongjiu.lu@intel.com> * testsuite/ld-x86-64/pass.out: New file. diff --git a/ld/testsuite/ld-powerpc/apuinfo-vle2.s b/ld/testsuite/ld-powerpc/apuinfo-vle2.s new file mode 100644 index 0000000..7174a8a --- /dev/null +++ b/ld/testsuite/ld-powerpc/apuinfo-vle2.s @@ -0,0 +1,8 @@ + .text + .global apuinfo2 +apuinfo2: + evstdd 29,8(1) + mfbbear 29 + mfpmr 29, 27 + dcbtstls 1, 29, 28 + se_rfmci diff --git a/ld/testsuite/ld-powerpc/apuinfo1.s b/ld/testsuite/ld-powerpc/apuinfo1.s index fd42eac..cdcfc47 100644 --- a/ld/testsuite/ld-powerpc/apuinfo1.s +++ b/ld/testsuite/ld-powerpc/apuinfo1.s @@ -1,9 +1,8 @@ .text .global apuinfo1 -apuinfo1: +apuinfo1: evstdd 29,8(1) isellt 29, 28, 27 efsabs 29, 28 .global _start _start: - nop diff --git a/ld/testsuite/ld-powerpc/powerpc.exp b/ld/testsuite/ld-powerpc/powerpc.exp index 46ffcf5..37e53fd 100644 --- a/ld/testsuite/ld-powerpc/powerpc.exp +++ b/ld/testsuite/ld-powerpc/powerpc.exp @@ -104,7 +104,7 @@ set ppcelftests { "-a32 -me500" {apuinfo1.s apuinfo-nul.s apuinfo2.s} {{readelf -x2 apuinfo.rd}} "apuinfo"} {"APUinfo VLE section processing" "-melf32ppc" "" - "-a32 -me500 -mvle" {apuinfo1.s apuinfo-vle.s apuinfo2.s} + "-a32 -me500 -mvle" {apuinfo1.s apuinfo-vle.s apuinfo-vle2.s} {{readelf -x2 apuinfo-vle.rd}} "apuinfo-vle"} {"APUinfo NULL section processing" "-melf32ppc" "" "-a32 -me500" {apuinfo-nul1.s apuinfo-nul.s} |