diff options
| author | H.J. Lu <hjl.tools@gmail.com> | 2018-08-17 03:54:05 -0700 |
|---|---|---|
| committer | H.J. Lu <hjl.tools@gmail.com> | 2018-08-17 03:54:16 -0700 |
| commit | bfb1e8c15a6b7d02cd0b9a124d01722a07ebf09a (patch) | |
| tree | ca561553a9b38085c41dd850e2678b209c860c90 /ld/testsuite/ld-i386 | |
| parent | 2ecae92e2372102ac0fa774fce4c4c0d6f8c85f5 (diff) | |
| download | gdb-bfb1e8c15a6b7d02cd0b9a124d01722a07ebf09a.zip gdb-bfb1e8c15a6b7d02cd0b9a124d01722a07ebf09a.tar.gz gdb-bfb1e8c15a6b7d02cd0b9a124d01722a07ebf09a.tar.bz2 | |
x86: Remove empty X86_FEATURE_1_AND property
There is no need to generate .note.gnu.property section with empty
X86_FEATURE_1_AND property. This patch adds fixup_gnu_properties
to ELF linker backend so that x86 backend can remove it.
bfd/
PR ld/23515
* elf-bfd.h (elf_backend_data): Add fixup_gnu_properties.
* elf-properties.c (_bfd_elf_link_setup_gnu_properties): Call
backend fixup_gnu_properties if it isn't NULL. Discard
.note.gnu.property section if all properties have been removed.
* elfxx-target.h (elf_backend_fixup_gnu_properties): New.
(elfNN_bed): Initialize fixup_gnu_properties.
* elfxx-x86.c (_bfd_x86_elf_link_fixup_gnu_properties): New
function.
* elfxx-x86.h (_bfd_x86_elf_link_fixup_gnu_properties): New
prototype.
(elf_backend_fixup_gnu_properties): New.
ld/
PR ld/23515
* testsuite/ld-i386/ibt-plt-2a.d: Updated.
* testsuite/ld-i386/ibt-plt-2b.d: Likewise.
* testsuite/ld-x86-64/ibt-plt-2a-x32.d: Likewise.
* testsuite/ld-x86-64/ibt-plt-2a.d: Likewise.
* testsuite/ld-x86-64/ibt-plt-2b-x32.d: Likewise.
* testsuite/ld-x86-64/ibt-plt-2b.d: Likewise.
Diffstat (limited to 'ld/testsuite/ld-i386')
| -rw-r--r-- | ld/testsuite/ld-i386/ibt-plt-2a.d | 22 | ||||
| -rw-r--r-- | ld/testsuite/ld-i386/ibt-plt-2b.d | 26 |
2 files changed, 21 insertions, 27 deletions
diff --git a/ld/testsuite/ld-i386/ibt-plt-2a.d b/ld/testsuite/ld-i386/ibt-plt-2a.d index 03c8e12..5825be4 100644 --- a/ld/testsuite/ld-i386/ibt-plt-2a.d +++ b/ld/testsuite/ld-i386/ibt-plt-2a.d @@ -8,45 +8,45 @@ Disassembly of section .plt: -0+160 <.plt>: +0+140 <.plt>: +[a-f0-9]+: ff b3 04 00 00 00 pushl 0x4\(%ebx\) +[a-f0-9]+: ff a3 08 00 00 00 jmp \*0x8\(%ebx\) +[a-f0-9]+: 0f 1f 40 00 nopl 0x0\(%eax\) +[a-f0-9]+: f3 0f 1e fb endbr32 +[a-f0-9]+: 68 00 00 00 00 push \$0x0 - +[a-f0-9]+: e9 e2 ff ff ff jmp 160 <.plt> + +[a-f0-9]+: e9 e2 ff ff ff jmp 140 <.plt> +[a-f0-9]+: 66 90 xchg %ax,%ax +[a-f0-9]+: f3 0f 1e fb endbr32 +[a-f0-9]+: 68 08 00 00 00 push \$0x8 - +[a-f0-9]+: e9 d2 ff ff ff jmp 160 <.plt> + +[a-f0-9]+: e9 d2 ff ff ff jmp 140 <.plt> +[a-f0-9]+: 66 90 xchg %ax,%ax Disassembly of section .plt.sec: -0+190 <bar1@plt>: +0+170 <bar1@plt>: +[a-f0-9]+: f3 0f 1e fb endbr32 +[a-f0-9]+: ff a3 0c 00 00 00 jmp \*0xc\(%ebx\) +[a-f0-9]+: 66 0f 1f 44 00 00 nopw 0x0\(%eax,%eax,1\) -0+1a0 <bar2@plt>: +0+180 <bar2@plt>: +[a-f0-9]+: f3 0f 1e fb endbr32 +[a-f0-9]+: ff a3 10 00 00 00 jmp \*0x10\(%ebx\) +[a-f0-9]+: 66 0f 1f 44 00 00 nopw 0x0\(%eax,%eax,1\) Disassembly of section .text: -0+1b0 <foo>: +0+190 <foo>: +[a-f0-9]+: 53 push %ebx - +[a-f0-9]+: e8 18 00 00 00 call 1ce <__x86.get_pc_thunk.bx> - +[a-f0-9]+: 81 c3 36 11 00 00 add \$0x1136,%ebx + +[a-f0-9]+: e8 18 00 00 00 call 1ae <__x86.get_pc_thunk.bx> + +[a-f0-9]+: 81 c3 1a 11 00 00 add \$0x111a,%ebx +[a-f0-9]+: 83 ec 08 sub \$0x8,%esp - +[a-f0-9]+: e8 dc ff ff ff call 1a0 <bar2@plt> - +[a-f0-9]+: e8 c7 ff ff ff call 190 <bar1@plt> + +[a-f0-9]+: e8 dc ff ff ff call 180 <bar2@plt> + +[a-f0-9]+: e8 c7 ff ff ff call 170 <bar1@plt> +[a-f0-9]+: 83 c4 08 add \$0x8,%esp +[a-f0-9]+: 5b pop %ebx +[a-f0-9]+: c3 ret -0+1ce <__x86.get_pc_thunk.bx>: +0+1ae <__x86.get_pc_thunk.bx>: +[a-f0-9]+: 8b 1c 24 mov \(%esp\),%ebx +[a-f0-9]+: c3 ret #pass diff --git a/ld/testsuite/ld-i386/ibt-plt-2b.d b/ld/testsuite/ld-i386/ibt-plt-2b.d index d7b4e1e..0fa9a99 100644 --- a/ld/testsuite/ld-i386/ibt-plt-2b.d +++ b/ld/testsuite/ld-i386/ibt-plt-2b.d @@ -18,37 +18,31 @@ Contents of the .eh_frame section: DW_CFA_nop DW_CFA_nop -0+18 0000001c 0000001c FDE cie=00000000 pc=000001b0..000001ce - DW_CFA_advance_loc: 1 to 000001b1 +0+18 0000001c 0000001c FDE cie=00000000 pc=00000190..000001ae + DW_CFA_advance_loc: 1 to 00000191 DW_CFA_def_cfa_offset: 8 DW_CFA_offset: r3 \(ebx\) at cfa-8 - DW_CFA_advance_loc: 14 to 000001bf + DW_CFA_advance_loc: 14 to 0000019f DW_CFA_def_cfa_offset: 16 - DW_CFA_advance_loc: 13 to 000001cc + DW_CFA_advance_loc: 13 to 000001ac DW_CFA_def_cfa_offset: 8 - DW_CFA_advance_loc: 1 to 000001cd + DW_CFA_advance_loc: 1 to 000001ad DW_CFA_restore: r3 \(ebx\) DW_CFA_def_cfa_offset: 4 -0+38 00000010 0000003c FDE cie=00000000 pc=000001ce..000001d2 +0+38 00000010 0000003c FDE cie=00000000 pc=000001ae..000001b2 DW_CFA_nop DW_CFA_nop DW_CFA_nop -0+4c 00000020 00000050 FDE cie=00000000 pc=00000160..00000190 +0+4c 00000020 00000050 FDE cie=00000000 pc=00000140..00000170 DW_CFA_def_cfa_offset: 8 - DW_CFA_advance_loc: 6 to 00000166 + DW_CFA_advance_loc: 6 to 00000146 DW_CFA_def_cfa_offset: 12 - DW_CFA_advance_loc: 10 to 00000170 + DW_CFA_advance_loc: 10 to 00000150 DW_CFA_def_cfa_expression \(DW_OP_breg4 \(esp\): 4; DW_OP_breg8 \(eip\): 0; DW_OP_lit15; DW_OP_and; DW_OP_lit9; DW_OP_ge; DW_OP_lit2; DW_OP_shl; DW_OP_plus\) -0+70 00000010 00000074 FDE cie=00000000 pc=00000190..000001b0 +0+70 00000010 00000074 FDE cie=00000000 pc=00000170..00000190 DW_CFA_nop DW_CFA_nop DW_CFA_nop - - -Displaying notes found in: .note.gnu.property - Owner Data size Description - GNU 0x0000000c NT_GNU_PROPERTY_TYPE_0 - Properties: x86 feature: |