aboutsummaryrefslogtreecommitdiff
path: root/gold/powerpc.cc
diff options
context:
space:
mode:
authorCary Coutant <ccoutant@gmail.com>2018-04-06 16:06:16 -0700
committerCary Coutant <ccoutant@gmail.com>2018-04-06 22:50:14 -0700
commit43193fe9fc39138c912095ba6f21c4302abafe5e (patch)
treeeeb5ed5dd17f654c78a0ef45cde2ac7c442d40b6 /gold/powerpc.cc
parentef4bf13b1f47b59b69335178367734dfc9ad166e (diff)
downloadgdb-43193fe9fc39138c912095ba6f21c4302abafe5e.zip
gdb-43193fe9fc39138c912095ba6f21c4302abafe5e.tar.gz
gdb-43193fe9fc39138c912095ba6f21c4302abafe5e.tar.bz2
Further improve warnings for relocations referring to discarded sections.
Relocations referring to discarded sections are now treated as errors instead of warnings. Also with this patch, we will now print the section group signature and the object file with the prevailing definition of that group along with the name of the symbol that the relocation is referring to. This additional information should be much more useful to anyone trying to track down the source of such errors. To do so, we now map each discarded section to the Kept_section info in the Layout class, and defer the logic that maps a discarded section to its counterpart in the kept group. This gives us the information we need to identify the signature symbol given the discarded section, and the name of the object file that provided the prevailing (i.e., first) definition of that group. gold/ * object.cc (Sized_relobj_file::include_section_group): Store reference to Kept_section info for discarded comdat sections regardless of size. Move size checking to map_to_kept_section. (Sized_relobj_file::include_linkonce_section): Likewise. (Sized_relobj_file::map_to_kept_section): Add section name parameter. Insert size checking logic from above functions. (Sized_relobj_file::find_kept_section_object): New method. (Sized_relobj_file::get_symbol_name): New method. * object.h (Sized_relobj_file::map_to_kept_section): Add section_name parameter. Adjust all callers. (Sized_relobj_file::find_kept_section_object): New method. (Sized_relobj_file::get_symbol_name): New method. (Sized_relobj_file::Kept_comdat_section): Replace object and shndx fields with sh_size, kept_section, symndx, and is_comdat fields. (Sized_relobj_file::set_kept_comdat_section): Replace kept_object and kept_shndx parameters with is_comdat, symndx, sh_size, and kept_section. (Sized_relobj_file::get_kept_comdat_section): Likewise. * target-reloc.h (enum Comdat_behavior): Change CB_WARNING to CB_ERROR. Adjust all references. (issue_undefined_symbol_error): New function template. (relocate_section): Pass section name to map_to_kept_section. Move discarded section code to new function above. * aarch64.cc (Target_aarch64::scan_reloc_section_for_stubs): Move declaration for gsym out one level. Call issue_discarded_error. * arm.cc (Target_arm::scan_reloc_section_for_stubs): Likewise. * powerpc.cc (Relocate_comdat_behavior): Change CB_WARNING to CB_ERROR.
Diffstat (limited to 'gold/powerpc.cc')
-rw-r--r--gold/powerpc.cc2
1 files changed, 1 insertions, 1 deletions
diff --git a/gold/powerpc.cc b/gold/powerpc.cc
index bddc2b8..a2c9698 100644
--- a/gold/powerpc.cc
+++ b/gold/powerpc.cc
@@ -1351,7 +1351,7 @@ class Target_powerpc : public Sized_target<size, big_endian>
{
gold::Default_comdat_behavior default_behavior;
Comdat_behavior ret = default_behavior.get(name);
- if (ret == CB_WARNING)
+ if (ret == CB_ERROR)
{
if (size == 32
&& (strcmp(name, ".fixup") == 0