aboutsummaryrefslogtreecommitdiff
path: root/gdbserver
diff options
context:
space:
mode:
authorTom Tromey <tromey@adacore.com>2020-04-08 14:33:35 -0600
committerTom Tromey <tromey@adacore.com>2020-04-08 14:47:58 -0600
commita816ba1897ae6939518d628cb58d6281c9b64a4f (patch)
tree179eba68f717d61dac25ea5221d8c834944fdfe4 /gdbserver
parenta00caa12790706017c9331ad984b4f6b102db1b6 (diff)
downloadgdb-a816ba1897ae6939518d628cb58d6281c9b64a4f.zip
gdb-a816ba1897ae6939518d628cb58d6281c9b64a4f.tar.gz
gdb-a816ba1897ae6939518d628cb58d6281c9b64a4f.tar.bz2
Share handle_load_dll and handle_unload_dll declarations
This changes nat/windows-nat.h to declare handle_load_dll and handle_unload_dll. The embedding application is required to implement these -- while the actual code was difficult to share due to some other differences between the two programs, sharing the declaration lets a subsequent patch share more code that uses these as callbacks. gdb/ChangeLog 2020-04-08 Tom Tromey <tromey@adacore.com> * windows-nat.c (windows_nat::handle_load_dll) (windows_nat::handle_unload_dll): Rename. No longer static. * nat/windows-nat.h (handle_load_dll, handle_unload_dll): Declare. gdbserver/ChangeLog 2020-04-08 Tom Tromey <tromey@adacore.com> * win32-low.c (windows_nat::handle_load_dll): Rename from handle_load_dll. No longer static. (windows_nat::handle_unload_dll): Rename from handle_unload_dll. No longer static.
Diffstat (limited to 'gdbserver')
-rw-r--r--gdbserver/ChangeLog7
-rw-r--r--gdbserver/win32-low.cc22
2 files changed, 13 insertions, 16 deletions
diff --git a/gdbserver/ChangeLog b/gdbserver/ChangeLog
index c6acece..e6213ad 100644
--- a/gdbserver/ChangeLog
+++ b/gdbserver/ChangeLog
@@ -1,5 +1,12 @@
2020-04-08 Tom Tromey <tromey@adacore.com>
+ * win32-low.c (windows_nat::handle_load_dll): Rename from
+ handle_load_dll. No longer static.
+ (windows_nat::handle_unload_dll): Rename from handle_unload_dll.
+ No longer static.
+
+2020-04-08 Tom Tromey <tromey@adacore.com>
+
* win32-low.c (handle_output_debug_string): Add parameter. Change
return type.
(win32_kill, get_child_debug_event): Update.
diff --git a/gdbserver/win32-low.cc b/gdbserver/win32-low.cc
index 2130366..73d4a6a 100644
--- a/gdbserver/win32-low.cc
+++ b/gdbserver/win32-low.cc
@@ -1123,15 +1123,10 @@ typedef HANDLE (WINAPI *winapi_CreateToolhelp32Snapshot) (DWORD, DWORD);
typedef BOOL (WINAPI *winapi_Module32First) (HANDLE, LPMODULEENTRY32);
typedef BOOL (WINAPI *winapi_Module32Next) (HANDLE, LPMODULEENTRY32);
-/* Handle a DLL load event.
-
- This function assumes that this event did not occur during inferior
- initialization, where their event info may be incomplete (see
- do_initial_child_stuff and win32_add_all_dlls for more info on
- how we handle DLL loading during that phase). */
+/* See nat/windows-nat.h. */
-static void
-handle_load_dll (void)
+void
+windows_nat::handle_load_dll ()
{
LOAD_DLL_DEBUG_INFO *event = &current_event.u.LoadDll;
const char *dll_name;
@@ -1144,15 +1139,10 @@ handle_load_dll (void)
win32_add_one_solib (dll_name, (CORE_ADDR) (uintptr_t) event->lpBaseOfDll);
}
-/* Handle a DLL unload event.
-
- This function assumes that this event did not occur during inferior
- initialization, where their event info may be incomplete (see
- do_initial_child_stuff and win32_add_one_solib for more info
- on how we handle DLL loading during that phase). */
+/* See nat/windows-nat.h. */
-static void
-handle_unload_dll (void)
+void
+windows_nat::handle_unload_dll ()
{
CORE_ADDR load_addr =
(CORE_ADDR) (uintptr_t) current_event.u.UnloadDll.lpBaseOfDll;