diff options
| author | Tom Tromey <tom@tromey.com> | 2020-10-29 15:04:33 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2020-10-29 15:04:38 -0600 |
| commit | e39fb97114f28dbc0f38a9851437437bfc5c43a0 (patch) | |
| tree | 1fb7f93dd50e73b398ae35e170bb36dc9a41a61a /gdb | |
| parent | a42d7dd873b1fc989b25c2fc793d6d084c6af907 (diff) | |
| download | gdb-e39fb97114f28dbc0f38a9851437437bfc5c43a0.zip gdb-e39fb97114f28dbc0f38a9851437437bfc5c43a0.tar.gz gdb-e39fb97114f28dbc0f38a9851437437bfc5c43a0.tar.bz2 | |
Change clear_program_space_solib_cache to method on program_space
This changes clear_program_space_solib_cache to be a method on
program_space. Also, it removes a call to this function from the
program_space destructor, as that is not necessary.
gdb/ChangeLog
2020-10-29 Tom Tromey <tom@tromey.com>
* progspace.c (program_space::~program_space): Don't call
clear_program_space_solib_cache.
(program_space::clear_solib_cache): Rename from
clear_solib_cache.
* solib.c (handle_solib_event): Update.
* progspace.h (struct program_space) <clear_solib_cache>: New
method.
(clear_program_space_solib_cache): Don't declare.
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/ChangeLog | 11 | ||||
| -rw-r--r-- | gdb/progspace.c | 7 | ||||
| -rw-r--r-- | gdb/progspace.h | 10 | ||||
| -rw-r--r-- | gdb/solib.c | 2 |
4 files changed, 20 insertions, 10 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index c074b4f..9793194 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,16 @@ 2020-10-29 Tom Tromey <tom@tromey.com> + * progspace.c (program_space::~program_space): Don't call + clear_program_space_solib_cache. + (program_space::clear_solib_cache): Rename from + clear_solib_cache. + * solib.c (handle_solib_event): Update. + * progspace.h (struct program_space) <clear_solib_cache>: New + method. + (clear_program_space_solib_cache): Don't declare. + +2020-10-29 Tom Tromey <tom@tromey.com> + * windows-tdep.c (windows_solib_create_inferior_hook): Update. * target.c (info_target_command): Update. * symfile.c (syms_from_objfile_1, finish_new_objfile) diff --git a/gdb/progspace.c b/gdb/progspace.c index 52482ca..84baaea 100644 --- a/gdb/progspace.c +++ b/gdb/progspace.c @@ -154,7 +154,6 @@ program_space::~program_space () clear_symtab_users (SYMFILE_DEFER_BP_RESET); if (!gdbarch_has_shared_address_space (target_gdbarch ())) free_address_space (this->aspace); - clear_program_space_solib_cache (this); /* Discard any data modules have associated with the PSPACE. */ program_space_free_data (this); } @@ -448,10 +447,10 @@ update_address_spaces (void) /* See progspace.h. */ void -clear_program_space_solib_cache (struct program_space *pspace) +program_space::clear_solib_cache () { - pspace->added_solibs.clear (); - pspace->deleted_solibs.clear (); + added_solibs.clear (); + deleted_solibs.clear (); } diff --git a/gdb/progspace.h b/gdb/progspace.h index e719cee..22805d7 100644 --- a/gdb/progspace.h +++ b/gdb/progspace.h @@ -288,6 +288,11 @@ struct program_space ebfd = std::move (abfd); } + /* Reset saved solib data at the start of an solib event. This lets + us properly collect the data when calling solib_add, so it can then + later be printed. */ + void clear_solib_cache (); + /* Unique ID number. */ int num = 0; @@ -435,11 +440,6 @@ extern int address_space_num (struct address_space *aspace); mappings. */ extern void update_address_spaces (void); -/* Reset saved solib data at the start of an solib event. This lets - us properly collect the data when calling solib_add, so it can then - later be printed. */ -extern void clear_program_space_solib_cache (struct program_space *); - /* Keep a registry of per-pspace data-pointers required by other GDB modules. */ diff --git a/gdb/solib.c b/gdb/solib.c index 9df4eca..baa1801 100644 --- a/gdb/solib.c +++ b/gdb/solib.c @@ -1252,7 +1252,7 @@ handle_solib_event (void) if (ops->handle_event != NULL) ops->handle_event (); - clear_program_space_solib_cache (current_inferior ()->pspace); + current_inferior ()->pspace->clear_solib_cache (); /* Check for any newly added shared libraries if we're supposed to be adding them automatically. Switch terminal for any messages |