aboutsummaryrefslogtreecommitdiff
path: root/gdb
diff options
context:
space:
mode:
authorSimon Marchi <simon.marchi@ericsson.com>2017-06-25 12:49:19 +0200
committerSimon Marchi <simon.marchi@ericsson.com>2017-06-25 12:49:19 +0200
commit07809eafc959a0c588663c0c949eaf8044a1b40a (patch)
tree781644fbcdfd67834cfeea9959d42b0d8ef24b9c /gdb
parentf076f0349cb958b451872ce4a7987821533c2f49 (diff)
downloadgdb-07809eafc959a0c588663c0c949eaf8044a1b40a.zip
gdb-07809eafc959a0c588663c0c949eaf8044a1b40a.tar.gz
gdb-07809eafc959a0c588663c0c949eaf8044a1b40a.tar.bz2
dtrace-probe: Put semicolon after while on its own line
clang shows this warning. /home/emaisin/src/binutils-gdb/gdb/dtrace-probe.c:424:52: error: while loop has empty body [-Werror,-Wempty-body] while (*p++ != '\0' && p - strtab < strtab_size); ^ /home/emaisin/src/binutils-gdb/gdb/dtrace-probe.c:424:52: note: put the semicolon on a separate line to silence this warning Putting the semicolon on its own line is not a big sacrifice to get rid of this warning. I think it's also useful to keep this, because it can catch errors like this: while (something); { ... } although gcc would warn about it in a different way (misleading indentation). This warning is already discussed here in the GCC bugzilla: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62184 gdb/ChangeLog: * dtrace-probe.c (dtrace_process_dof_probe): Put semi-colon on its own line.
Diffstat (limited to 'gdb')
-rw-r--r--gdb/ChangeLog5
-rw-r--r--gdb/dtrace-probe.c3
2 files changed, 7 insertions, 1 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 7914b1d..7c48bf4 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
2017-06-25 Simon Marchi <simon.marchi@ericsson.com>
+ * dtrace-probe.c (dtrace_process_dof_probe): Put semi-colon on
+ its own line.
+
+2017-06-25 Simon Marchi <simon.marchi@ericsson.com>
+
* nat/x86-dregs.c (x86_show_dr): Print registers one per line.
2017-06-23 Alan Hayward <alan.hayward@arm.com>
diff --git a/gdb/dtrace-probe.c b/gdb/dtrace-probe.c
index 122f8de..c611b16 100644
--- a/gdb/dtrace-probe.c
+++ b/gdb/dtrace-probe.c
@@ -421,7 +421,8 @@ dtrace_process_dof_probe (struct objfile *objfile,
arg.type_str = xstrdup (p);
/* Use strtab_size as a sentinel. */
- while (*p++ != '\0' && p - strtab < strtab_size);
+ while (*p++ != '\0' && p - strtab < strtab_size)
+ ;
/* Try to parse a type expression from the type string. If
this does not work then we set the type to `long