aboutsummaryrefslogtreecommitdiff
path: root/gdb
diff options
context:
space:
mode:
authorAndrew Burgess <aburgess@redhat.com>2022-12-15 16:50:57 +0000
committerAndrew Burgess <aburgess@redhat.com>2022-12-16 12:57:37 +0000
commit38c0c0cac9f4b0298312ca6791db155dfaaf8442 (patch)
treecf2ce141af06f96de47d13b3369c93ac9e9df461 /gdb
parentfa501b69309ccb03ec957101f24109ed7f737733 (diff)
downloadgdb-38c0c0cac9f4b0298312ca6791db155dfaaf8442.zip
gdb-38c0c0cac9f4b0298312ca6791db155dfaaf8442.tar.gz
gdb-38c0c0cac9f4b0298312ca6791db155dfaaf8442.tar.bz2
gdb: clean up some inefficient std::string usage
This commit: commit 53cf95c3389a3ecd97276d322e4a60fe3396a201 Date: Wed Dec 14 14:17:44 2022 +0000 gdb: make more use of make_target_connection_string Introduced a couple of inefficient uses of std::string, both of which are fixed in this commit. There should be no user visible changes after this commit. Approved-By: Simon Marchi <simon.marchi@efficios.com>
Diffstat (limited to 'gdb')
-rw-r--r--gdb/inferior.c3
-rw-r--r--gdb/target-connection.c2
2 files changed, 2 insertions, 3 deletions
diff --git a/gdb/inferior.c b/gdb/inferior.c
index 3d2bce9..928305f 100644
--- a/gdb/inferior.c
+++ b/gdb/inferior.c
@@ -486,8 +486,7 @@ uiout_field_connection (process_stratum_target *proc_target)
return {};
else
{
- std::string conn_str
- = make_target_connection_string (proc_target).c_str ();
+ std::string conn_str = make_target_connection_string (proc_target);
return string_printf ("%d (%s)", proc_target->connection_number,
conn_str.c_str ());
}
diff --git a/gdb/target-connection.c b/gdb/target-connection.c
index d88b9c8..55818cf 100644
--- a/gdb/target-connection.c
+++ b/gdb/target-connection.c
@@ -91,7 +91,7 @@ print_connection (struct ui_out *uiout, const char *requested_connections)
process_stratum_target *t = it.second;
- size_t l = strlen (make_target_connection_string (t).c_str ());
+ size_t l = make_target_connection_string (t).length ();
if (l > what_len)
what_len = l;
}