aboutsummaryrefslogtreecommitdiff
path: root/gdb/tracepoint.h
diff options
context:
space:
mode:
authorYao Qi <yao@codesourcery.com>2014-02-15 08:48:53 +0800
committerYao Qi <yao@codesourcery.com>2014-03-06 11:33:06 +0800
commitcc3da688013b5fb3dcc1fa5206bbeef4a35cc10c (patch)
tree8bccdf77f1d2543b5d3c7f658b9e4cf027cacd6c /gdb/tracepoint.h
parent6a5f844b29319793deb3840b20803bd3a0fa01a2 (diff)
downloadgdb-cc3da688013b5fb3dcc1fa5206bbeef4a35cc10c.zip
gdb-cc3da688013b5fb3dcc1fa5206bbeef4a35cc10c.tar.gz
gdb-cc3da688013b5fb3dcc1fa5206bbeef4a35cc10c.tar.bz2
Fix PR16508
This patch fixes PR16508, which is about MI "-trace-find frame-number 0" behaves differently from CLI "tfind 0". In CLI, we check both status->running and status->filename, but in MI, we only check status->running, which looks wrong to me. This patch moves the code of checking to a new function check_trace_running, and use it in both CLI and MI. This patch also adds a test case pr16508.exp, which fails without this fix, and passes with the fix applied. FAIL: gdb.trace/pr16508.exp: interpreter-exec mi "-trace-find frame-number 0" gdb: 2014-03-06 Yao Qi <yao@codesourcery.com> PR breakpoints/16508 * tracepoint.c (check_trace_running): New function. (trace_find_command): Move code to check_trace_running and call check_trace_running. (trace_find_pc_command): Likewise. (trace_find_tracepoint_command): Likewise. (trace_find_line_command): Likewise. (trace_find_range_command): Likewise. * tracepoint.h (check_trace_running): Likewise. * mi/mi-main.c (mi_cmd_trace_find): Call check_trace_running. gdb/testsuite: 2014-03-06 Yao Qi <yao@codesourcery.com> * gdb.trace/pr16508.exp: New file.
Diffstat (limited to 'gdb/tracepoint.h')
-rw-r--r--gdb/tracepoint.h2
1 files changed, 2 insertions, 0 deletions
diff --git a/gdb/tracepoint.h b/gdb/tracepoint.h
index 6b00b30..8a1abbf 100644
--- a/gdb/tracepoint.h
+++ b/gdb/tracepoint.h
@@ -334,6 +334,8 @@ extern void query_if_trace_running (int from_tty);
extern void disconnect_tracing (void);
extern void trace_reset_local_state (void);
+extern void check_trace_running (struct trace_status *);
+
extern void start_tracing (char *notes);
extern void stop_tracing (char *notes);