aboutsummaryrefslogtreecommitdiff
path: root/gdb/target
diff options
context:
space:
mode:
authorSimon Marchi <simon.marchi@efficios.com>2021-12-01 20:40:01 -0500
committerSimon Marchi <simon.marchi@polymtl.ca>2021-12-03 08:25:05 -0500
commit857dfb92de66c1ce66e78ae40a4b7d0e8fdbf2f0 (patch)
treed8d1508737a094e8519732a7a3faed3370520ed9 /gdb/target
parentce1a6f421d29aad57f5f25fe2b8a929523c3de27 (diff)
downloadgdb-857dfb92de66c1ce66e78ae40a4b7d0e8fdbf2f0.zip
gdb-857dfb92de66c1ce66e78ae40a4b7d0e8fdbf2f0.tar.gz
gdb-857dfb92de66c1ce66e78ae40a4b7d0e8fdbf2f0.tar.bz2
gdb: return *this in target_waitstatus setters
While playing with some code creating target_waitstatus objects, I was mildly annoyed by the fact that we can't just return a new target_waitstatus object. We have to do: target_waitstatus ws; ws.set_exited (123); return ws; Make the setters return the "this" object as a reference, such that it's possible to do: return target_waitstatus ().set_exited (123); I initially thought of adding static creation functions, which you would use like: return target_waitstatus::make_exited (123); However, making the setters return a reference to the object achieves pretty much the same thing, with less new code. Change-Id: I45159b7f9fcd9db5b20603480e323020b14ed147
Diffstat (limited to 'gdb/target')
-rw-r--r--gdb/target/waitstatus.h48
1 files changed, 32 insertions, 16 deletions
diff --git a/gdb/target/waitstatus.h b/gdb/target/waitstatus.h
index 5b53735..72fa5fb 100644
--- a/gdb/target/waitstatus.h
+++ b/gdb/target/waitstatus.h
@@ -219,109 +219,125 @@ struct target_waitstatus
/* Setters: set the wait status kind plus any associated data. */
- void set_exited (int exit_status)
+ target_waitstatus &set_exited (int exit_status)
{
this->reset ();
m_kind = TARGET_WAITKIND_EXITED;
m_value.exit_status = exit_status;
+ return *this;
}
- void set_stopped (gdb_signal sig)
+ target_waitstatus &set_stopped (gdb_signal sig)
{
this->reset ();
m_kind = TARGET_WAITKIND_STOPPED;
m_value.sig = sig;
+ return *this;
}
- void set_signalled (gdb_signal sig)
+ target_waitstatus &set_signalled (gdb_signal sig)
{
this->reset ();
m_kind = TARGET_WAITKIND_SIGNALLED;
m_value.sig = sig;
+ return *this;
}
- void set_loaded ()
+ target_waitstatus &set_loaded ()
{
this->reset ();
m_kind = TARGET_WAITKIND_LOADED;
+ return *this;
}
- void set_forked (ptid_t child_ptid)
+ target_waitstatus &set_forked (ptid_t child_ptid)
{
this->reset ();
m_kind = TARGET_WAITKIND_FORKED;
m_value.child_ptid = child_ptid;
+ return *this;
}
- void set_vforked (ptid_t child_ptid)
+ target_waitstatus &set_vforked (ptid_t child_ptid)
{
this->reset ();
m_kind = TARGET_WAITKIND_VFORKED;
m_value.child_ptid = child_ptid;
+ return *this;
}
- void set_execd (gdb::unique_xmalloc_ptr<char> execd_pathname)
+ target_waitstatus &set_execd (gdb::unique_xmalloc_ptr<char> execd_pathname)
{
this->reset ();
m_kind = TARGET_WAITKIND_EXECD;
m_value.execd_pathname = execd_pathname.release ();
+ return *this;
}
- void set_vfork_done ()
+ target_waitstatus &set_vfork_done ()
{
this->reset ();
m_kind = TARGET_WAITKIND_VFORK_DONE;
+ return *this;
}
- void set_syscall_entry (int syscall_number)
+ target_waitstatus &set_syscall_entry (int syscall_number)
{
this->reset ();
m_kind = TARGET_WAITKIND_SYSCALL_ENTRY;
m_value.syscall_number = syscall_number;
+ return *this;
}
- void set_syscall_return (int syscall_number)
+ target_waitstatus &set_syscall_return (int syscall_number)
{
this->reset ();
m_kind = TARGET_WAITKIND_SYSCALL_RETURN;
m_value.syscall_number = syscall_number;
+ return *this;
}
- void set_spurious ()
+ target_waitstatus &set_spurious ()
{
this->reset ();
m_kind = TARGET_WAITKIND_SPURIOUS;
+ return *this;
}
- void set_ignore ()
+ target_waitstatus &set_ignore ()
{
this->reset ();
m_kind = TARGET_WAITKIND_IGNORE;
+ return *this;
}
- void set_no_history ()
+ target_waitstatus &set_no_history ()
{
this->reset ();
m_kind = TARGET_WAITKIND_NO_HISTORY;
+ return *this;
}
- void set_no_resumed ()
+ target_waitstatus &set_no_resumed ()
{
this->reset ();
m_kind = TARGET_WAITKIND_NO_RESUMED;
+ return *this;
}
- void set_thread_created ()
+ target_waitstatus &set_thread_created ()
{
this->reset ();
m_kind = TARGET_WAITKIND_THREAD_CREATED;
+ return *this;
}
- void set_thread_exited (int exit_status)
+ target_waitstatus &set_thread_exited (int exit_status)
{
this->reset ();
m_kind = TARGET_WAITKIND_THREAD_EXITED;
m_value.exit_status = exit_status;
+ return *this;
}
/* Get the kind of this wait status. */