aboutsummaryrefslogtreecommitdiff
path: root/gdb/stap-probe.c
diff options
context:
space:
mode:
authorSergio Durigan Junior <sergiodj@redhat.com>2019-05-16 16:11:20 -0400
committerSergio Durigan Junior <sergiodj@redhat.com>2019-05-16 16:26:29 -0400
commit3ca58cdea13ddad01d70aa170eb419903b241b94 (patch)
treeae36fc802dc87b4ca1889198681e39fdbaaa0799 /gdb/stap-probe.c
parentaf2d9beee989c7b75de849d9c08629a1e3f567ad (diff)
downloadgdb-3ca58cdea13ddad01d70aa170eb419903b241b94.zip
gdb-3ca58cdea13ddad01d70aa170eb419903b241b94.tar.gz
gdb-3ca58cdea13ddad01d70aa170eb419903b241b94.tar.bz2
Update some comments on stap-probe.c
Some functions's comments were not entirely correct on stap-probe.c, so this patch updates them. Pushed as obvious. gdb/ChangeLog: 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com> * stap-probe.c (stap_get_opcode): Update comment. (stap_get_expected_argument_type): Likewise. (handle_stap_probe): Likewise.
Diffstat (limited to 'gdb/stap-probe.c')
-rw-r--r--gdb/stap-probe.c13
1 files changed, 6 insertions, 7 deletions
diff --git a/gdb/stap-probe.c b/gdb/stap-probe.c
index 89cd780..bc2f9fc 100644
--- a/gdb/stap-probe.c
+++ b/gdb/stap-probe.c
@@ -316,8 +316,9 @@ stap_get_operator_prec (enum exp_opcode op)
}
}
-/* Given S, read the operator in it and fills the OP pointer with its code.
- Return 1 on success, zero if the operator was not recognized. */
+/* Given S, read the operator in it. Return the EXP_OPCODE which
+ represents the operator detected, or throw an error if no operator
+ was found. */
static enum exp_opcode
stap_get_opcode (const char **s)
@@ -422,7 +423,8 @@ stap_get_opcode (const char **s)
}
/* Given the bitness of the argument, represented by B, return the
- corresponding `struct type *'. */
+ corresponding `struct type *', or throw an error if B is
+ unknown. */
static struct type *
stap_get_expected_argument_type (struct gdbarch *gdbarch,
@@ -1491,10 +1493,7 @@ stap_probe::gen_info_probes_table_values () const
probe doesn't have an associated semaphore;
- Probe's provider name;
- Probe's name;
- - Probe's argument format
-
- This function returns 1 if the handling was successful, and zero
- otherwise. */
+ - Probe's argument format. */
static void
handle_stap_probe (struct objfile *objfile, struct sdt_note *el,