aboutsummaryrefslogtreecommitdiff
path: root/gdb/remote-udi.c
diff options
context:
space:
mode:
authorJim Kingdon <jkingdon@engr.sgi.com>1994-10-15 18:13:47 +0000
committerJim Kingdon <jkingdon@engr.sgi.com>1994-10-15 18:13:47 +0000
commite080a68fce6b8e73c9869a6016d726f820dee7fc (patch)
treee4b54e9e71c3a7a58e9e9bbfd30ae019f0dd7134 /gdb/remote-udi.c
parent966b6b3b9e1d3fee5eade33f59cff7e0264874dc (diff)
downloadgdb-e080a68fce6b8e73c9869a6016d726f820dee7fc.zip
gdb-e080a68fce6b8e73c9869a6016d726f820dee7fc.tar.gz
gdb-e080a68fce6b8e73c9869a6016d726f820dee7fc.tar.bz2
* exec.c (map_vmap): Cast return from xmalloc to its proper type,
not to PTR. * symfile.c (reread_symbols): Include bfd_errmsg string in error message if bfd_close fails. * exec.c (exec_close), solib.c (clear_solib), corelow.c (core_close), objfiles.c (free_objfile), irix5-nat.c (clear_solib), remote-utils.c (gr_load_image): Check for errors from bfd_close. * solib.c (look_for_base), remote-utils.c (gr_load_image), remote-udi.c (download), corelow.c (core_open), symfile.c (symfile_bfd_open), symfile.c (generic_load): Add comment regarding error from bfd_close. * remote-udi.c (download), remote-utils.c (gr_load_image): Add comment about bogus handling of errors from bfd_openr. * exec.c (exec_close): Add comment regarding memory leak and dangling reference to vp->name.
Diffstat (limited to 'gdb/remote-udi.c')
-rw-r--r--gdb/remote-udi.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/gdb/remote-udi.c b/gdb/remote-udi.c
index e57cad0..c2366fd 100644
--- a/gdb/remote-udi.c
+++ b/gdb/remote-udi.c
@@ -1139,8 +1139,13 @@ download(load_arg_string, from_tty)
pbfd = bfd_openr (filename, gnutarget);
if (!pbfd)
+ /* FIXME: should be using bfd_errmsg, not assuming it was
+ bfd_error_system_call. */
perror_with_name (filename);
+ /* FIXME: should be checking for errors from bfd_close (for one thing,
+ on error it does not free all the storage associated with the
+ bfd). */
make_cleanup (bfd_close, pbfd);
QUIT;