aboutsummaryrefslogtreecommitdiff
path: root/gdb/gdbarch.h
diff options
context:
space:
mode:
authorAndrew Burgess <andrew.burgess@embecosm.com>2019-07-02 12:06:06 +0100
committerAndrew Burgess <andrew.burgess@embecosm.com>2019-07-17 16:24:32 +0100
commit6b78c3f83c8bcbfa714aab7627ece9673b2d602a (patch)
treee8224084dbf069be1e592ea23aeefc509ddf1316 /gdb/gdbarch.h
parentd72a9b85651c872378f6dd732cb578f6f055a9b3 (diff)
downloadgdb-6b78c3f83c8bcbfa714aab7627ece9673b2d602a.zip
gdb-6b78c3f83c8bcbfa714aab7627ece9673b2d602a.tar.gz
gdb-6b78c3f83c8bcbfa714aab7627ece9673b2d602a.tar.bz2
gdb: Remove a non-const reference parameter
Non-const reference parameter should be avoided according to the GDB coding standard: https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards#Avoid_non-const_reference_parameters.2C_use_pointers_instead This commit updates the gdbarch method gdbarch_stap_adjust_register, and the one implementation i386_stap_adjust_register to avoid using a non-const reference parameter. I've also removed the kfail from the testsuite for bug 24541, as this issue is now resolved. gdb/ChangeLog: PR breakpoints/24541 * gdbarch.c: Regenerate. * gdbarch.h: Regenerate. * gdbarch.sh: Adjust return type and parameter types for 'stap_adjust_register'. (i386_stap_adjust_register): Adjust signature and return new register name. * stap-probe.c (stap_parse_register_operand): Adjust use of 'gdbarch_stap_adjust_register'. gdb/testsuite/ChangeLog: PR breakpoints/24541 * gdb.mi/mi-catch-cpp-exceptions.exp: Remove kfail due to 24541.
Diffstat (limited to 'gdb/gdbarch.h')
-rw-r--r--gdb/gdbarch.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/gdb/gdbarch.h b/gdb/gdbarch.h
index 0857d2f..c3556d3 100644
--- a/gdb/gdbarch.h
+++ b/gdb/gdbarch.h
@@ -1376,8 +1376,8 @@ extern void set_gdbarch_stap_parse_special_token (struct gdbarch *gdbarch, gdbar
extern int gdbarch_stap_adjust_register_p (struct gdbarch *gdbarch);
-typedef void (gdbarch_stap_adjust_register_ftype) (struct gdbarch *gdbarch, struct stap_parse_info *p, std::string &regname, int regnum);
-extern void gdbarch_stap_adjust_register (struct gdbarch *gdbarch, struct stap_parse_info *p, std::string &regname, int regnum);
+typedef std::string (gdbarch_stap_adjust_register_ftype) (struct gdbarch *gdbarch, struct stap_parse_info *p, const std::string &regname, int regnum);
+extern std::string gdbarch_stap_adjust_register (struct gdbarch *gdbarch, struct stap_parse_info *p, const std::string &regname, int regnum);
extern void set_gdbarch_stap_adjust_register (struct gdbarch *gdbarch, gdbarch_stap_adjust_register_ftype *stap_adjust_register);
/* DTrace related functions.