diff options
| author | Tom Tromey <tromey@redhat.com> | 2013-10-07 19:31:13 +0000 |
|---|---|---|
| committer | Tom Tromey <tromey@redhat.com> | 2013-10-07 19:31:13 +0000 |
| commit | 1da77581c0559e62b80b27f06f81dad4c7a7a0be (patch) | |
| tree | 6ff5dc49a1c003c5b888f3f0fe32419fabcfe570 /gdb/gdb_bfd.h | |
| parent | f44eeb117f66f09bf1ffed1cfb423f36a89ddfe6 (diff) | |
| download | gdb-1da77581c0559e62b80b27f06f81dad4c7a7a0be.zip gdb-1da77581c0559e62b80b27f06f81dad4c7a7a0be.tar.gz gdb-1da77581c0559e62b80b27f06f81dad4c7a7a0be.tar.bz2 | |
don't share per-BFD data if relocations are needed
Right now we always share per-BFD data across objfiles, if there is a
BFD. This works fine. However, we're going to start sharing more
data, and sometimes this data will come directly from sections of the
BFD. If such a section has SEC_RELOC set, then the data coming from
that section will not be truly sharable -- the section will be
program-space-dependent, and re-read by gdb for each objfile.
This patch disallows per-BFD sharing in this case. This is a bit
"heavy" in that we could in theory examine each bit of shared data for
suitability. However, that is more complicated, and SEC_RELOC is rare
enough that I think we needn't bother.
Note that the "no sharing" case is equivalent to "gdb works as it
historically did". That is, the sharing is a new(-ish) optimization.
Built and regtested on x86-64 Fedora 18.
* gdb_bfd.c (struct gdb_bfd_data) <relocation_computed,
needs_relocations>: New fields.
(gdb_bfd_requires_relocations): New function.
* gdb_bfd.h (gdb_bfd_requires_relocations): Declare.
* objfiles.c (get_objfile_bfd_data): Disallow sharing if
the BFD needs relocations applied.
Diffstat (limited to 'gdb/gdb_bfd.h')
| -rw-r--r-- | gdb/gdb_bfd.h | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/gdb/gdb_bfd.h b/gdb/gdb_bfd.h index ca2eddc..d28b29e 100644 --- a/gdb/gdb_bfd.h +++ b/gdb/gdb_bfd.h @@ -135,4 +135,9 @@ int gdb_bfd_section_index (bfd *abfd, asection *section); int gdb_bfd_count_sections (bfd *abfd); +/* Return true if any section requires relocations, false + otherwise. */ + +int gdb_bfd_requires_relocations (bfd *abfd); + #endif /* GDB_BFD_H */ |