aboutsummaryrefslogtreecommitdiff
path: root/gdb/exec.c
diff options
context:
space:
mode:
authorSimon Marchi <simon.marchi@polymtl.ca>2021-06-28 15:28:26 -0400
committerSimon Marchi <simon.marchi@polymtl.ca>2021-06-28 15:28:26 -0400
commit0c1bcd23274e9f465dc43eda4fc467150631f824 (patch)
treea7ebad33d064631f80c6b016da5cb3e2df3eedae /gdb/exec.c
parentf07fad95a949b070e51a18276b8f1e03cf86490f (diff)
downloadgdb-0c1bcd23274e9f465dc43eda4fc467150631f824.zip
gdb-0c1bcd23274e9f465dc43eda4fc467150631f824.tar.gz
gdb-0c1bcd23274e9f465dc43eda4fc467150631f824.tar.bz2
gdb: convert obj_section macros to methods
Convert these three macros to methods of obj_section. The problem fixed by the following patch is caused by an out of bound access of the objfile::section_offsets vector. Since this is deep in macros, we don't get a clear backtrace and it's difficult to debug. Changing that to methods means we can step in them and break on them. Because their implementation requires knowing about struct objfile, move struct obj_section below struct objfile in objfiles.h. The obj_section_offset was used in one place as an lvalue to set offsets, in machoread.c. Replace that with a set_offset method. Add the objfile::section_offset and objfile::set_section_offset methods to improve encapsulation (reduce other objects poking into struct objfile's internals). gdb/ChangeLog: * objfiles.h (struct obj_section): Move down. <offset, set_offset, addr, endaddr>: New. (obj_section_offset, obj_section_addr, obj_section_endaddr), replace all users to use obj_section methods. (struct objfile) <section_offset, set_section_offset>: New. Change-Id: I97e8fcae93ab2353fbdadcb4a5ec10d7949a7334
Diffstat (limited to 'gdb/exec.c')
-rw-r--r--gdb/exec.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/gdb/exec.c b/gdb/exec.c
index ff0db82..35bf7bd 100644
--- a/gdb/exec.c
+++ b/gdb/exec.c
@@ -636,8 +636,7 @@ program_space::add_target_sections (struct objfile *objfile)
if (bfd_section_size (osect->the_bfd_section) == 0)
continue;
- m_target_sections.emplace_back (obj_section_addr (osect),
- obj_section_endaddr (osect),
+ m_target_sections.emplace_back (osect->addr (), osect->endaddr (),
osect->the_bfd_section, (void *) objfile);
}
}