diff options
| author | Tom Tromey <tromey@adacore.com> | 2022-04-19 07:33:09 -0600 |
|---|---|---|
| committer | Tom Tromey <tromey@adacore.com> | 2022-04-22 06:57:07 -0600 |
| commit | 0f34437ba0f5acab1fcb05630d88057402abbfeb (patch) | |
| tree | ad31b8a122e9f3c9017bf27f8b588c6b493d8e7d /gdb/coff-pe-read.c | |
| parent | fa265c9bef46fc2211f8dccbc9d9b432778087be (diff) | |
| download | gdb-0f34437ba0f5acab1fcb05630d88057402abbfeb.zip gdb-0f34437ba0f5acab1fcb05630d88057402abbfeb.tar.gz gdb-0f34437ba0f5acab1fcb05630d88057402abbfeb.tar.bz2 | |
Use std::string in coff-pe-read.c
coff-pe-read.c uses xsnprintf and alloca, but using std::string is
better, and just as easy. In general I think alloca is something to
be avoided, and unbounded uses especially so.
Diffstat (limited to 'gdb/coff-pe-read.c')
| -rw-r--r-- | gdb/coff-pe-read.c | 13 |
1 files changed, 5 insertions, 8 deletions
diff --git a/gdb/coff-pe-read.c b/gdb/coff-pe-read.c index ae4ca54..5bf0e2d 100644 --- a/gdb/coff-pe-read.c +++ b/gdb/coff-pe-read.c @@ -178,16 +178,13 @@ add_pe_forwarded_sym (minimal_symbol_reader &reader, struct bound_minimal_symbol msymbol; enum minimal_symbol_type msymtype; int forward_dll_name_len = strlen (forward_dll_name); - int forward_func_name_len = strlen (forward_func_name); - int forward_len = forward_dll_name_len + forward_func_name_len + 2; - char *forward_qualified_name = (char *) alloca (forward_len); short section; - xsnprintf (forward_qualified_name, forward_len, "%s!%s", forward_dll_name, - forward_func_name); + std::string forward_qualified_name = string_printf ("%s!%s", + forward_dll_name, + forward_func_name); - - msymbol = lookup_bound_minimal_symbol (forward_qualified_name); + msymbol = lookup_bound_minimal_symbol (forward_qualified_name.c_str ()); if (!msymbol.minsym) { @@ -195,7 +192,7 @@ add_pe_forwarded_sym (minimal_symbol_reader &reader, for (i = 0; i < forward_dll_name_len; i++) forward_qualified_name[i] = tolower (forward_qualified_name[i]); - msymbol = lookup_bound_minimal_symbol (forward_qualified_name); + msymbol = lookup_bound_minimal_symbol (forward_qualified_name.c_str ()); } if (!msymbol.minsym) |