aboutsummaryrefslogtreecommitdiff
path: root/gdb/arc-tdep.c
diff options
context:
space:
mode:
authorTom Tromey <tom@tromey.com>2018-09-26 06:54:17 -0600
committerTom Tromey <tom@tromey.com>2018-10-06 22:46:56 -0600
commita8a5dbcab8df0b3a9e04745d4fe8d64740acb323 (patch)
treeb61a60b157158db8b066c30de7fe84b6855a962f /gdb/arc-tdep.c
parent2a8be20359dba9cc684fd3ffa222d985399f3b18 (diff)
downloadgdb-a8a5dbcab8df0b3a9e04745d4fe8d64740acb323.zip
gdb-a8a5dbcab8df0b3a9e04745d4fe8d64740acb323.tar.gz
gdb-a8a5dbcab8df0b3a9e04745d4fe8d64740acb323.tar.bz2
Do not accidentally include in-tree readline headers
PR build/17077 points out that when --with-system-readline is given, gdb will still pick up the in-tree readline headers. Normally this is not a big problem, because readline is very stable and so the ABI does not change much; but it is clearly a bug to do this, and could bite at some point. The basic problem is that OPCODES_CFLAGS uses -I$(OPCODES_SRC)/.. so that #include "opcodes/..." works. However, this also makes it so the This patch fixes the problem in a mildly hacky way: remove the offending -I option, and change gdb to use #include "../opcodes/..." instead. This continues to make it clear where the header comes from, without allowing incorrect behavior. Tested by rebuilding and then looking at the *.Po files. gdb/ChangeLog 2018-10-06 Tom Tromey <tom@tromey.com> PR build/17077: * Makefile.in (OPCODES_CFLAGS): Remove "-I$(OPCODES_SRC)/..". * arc-tdep.c, frv-tdep.c, lm32-tdep.c, mep-tdep.c, microblaze-tdep.c, or1k-tdep.h: Use ../opcodes, not opcodes, in #include.
Diffstat (limited to 'gdb/arc-tdep.c')
-rw-r--r--gdb/arc-tdep.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/gdb/arc-tdep.c b/gdb/arc-tdep.c
index fad9170..b9dcbbc 100644
--- a/gdb/arc-tdep.c
+++ b/gdb/arc-tdep.c
@@ -33,7 +33,7 @@
/* ARC header files. */
#include "opcode/arc.h"
-#include "opcodes/arc-dis.h"
+#include "../opcodes/arc-dis.h"
#include "arc-tdep.h"
/* Standard headers. */