aboutsummaryrefslogtreecommitdiff
path: root/gas
diff options
context:
space:
mode:
authorAlan Modra <amodra@gmail.com>2014-07-12 17:05:35 +0930
committerAlan Modra <amodra@gmail.com>2014-07-12 18:50:53 +0930
commit76bd66cfb5207137dac01534cf7d8af8f708743b (patch)
tree0ada48384425dbaa0bb9af196e8e91129093e184 /gas
parenta25eb0280d6ae5a791e0e613f42e3197c82d3030 (diff)
downloadgdb-76bd66cfb5207137dac01534cf7d8af8f708743b.zip
gdb-76bd66cfb5207137dac01534cf7d8af8f708743b.tar.gz
gdb-76bd66cfb5207137dac01534cf7d8af8f708743b.tar.bz2
Don't force "set" symbols local for PE
gas/ * read.c (assign_symbol): Don't force "set" symbols local for PE. gas/testsuite/ * gas/pe/set.s, * gas/pe/set.d: New test. * gas/pe/pe.exp: Run it.
Diffstat (limited to 'gas')
-rw-r--r--gas/ChangeLog4
-rw-r--r--gas/read.c2
-rw-r--r--gas/testsuite/ChangeLog5
-rw-r--r--gas/testsuite/gas/pe/pe.exp2
-rw-r--r--gas/testsuite/gas/pe/set.d11
-rw-r--r--gas/testsuite/gas/pe/set.s9
6 files changed, 32 insertions, 1 deletions
diff --git a/gas/ChangeLog b/gas/ChangeLog
index 9c183e4..2ef1adf 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,7 @@
+2014-07-12 David Majnemer <david.majnemer@gmail.com>
+
+ * read.c (assign_symbol): Don't force "set" symbols local for PE.
+
2014-07-08 Jiong Wang <jiong.wang@arm.com>
* config/tc-arm.c (literal_pool): New field "alignment".
diff --git a/gas/read.c b/gas/read.c
index 8e1b06e..183ef2c 100644
--- a/gas/read.c
+++ b/gas/read.c
@@ -3187,7 +3187,7 @@ assign_symbol (char *name, int mode)
symbol_set_frag (symbolP, dummy_frag);
}
#endif
-#ifdef OBJ_COFF
+#if defined (OBJ_COFF) && !defined (TE_PE)
/* "set" symbols are local unless otherwise specified. */
SF_SET_LOCAL (symbolP);
#endif
diff --git a/gas/testsuite/ChangeLog b/gas/testsuite/ChangeLog
index a7a6946..4e91b37 100644
--- a/gas/testsuite/ChangeLog
+++ b/gas/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2014-07-12 David Majnemer <david.majnemer@gmail.com>
+
+ * gas/pe/set.s, * gas/pe/set.d: New test.
+ * gas/pe/pe.exp: Run it.
+
2014-07-10 Will Newton <will.newton@linaro.org>
* gas/elf/elf.exp: Remove special handling of arm-elf for
diff --git a/gas/testsuite/gas/pe/pe.exp b/gas/testsuite/gas/pe/pe.exp
index c1c5f49..0fab53d 100644
--- a/gas/testsuite/gas/pe/pe.exp
+++ b/gas/testsuite/gas/pe/pe.exp
@@ -36,6 +36,8 @@ run_dump_test "section-align-1"
run_dump_test "section-align-3"
run_dump_test "section-exclude"
+run_dump_test "set"
+
# SEH related tests
# These tests are only for x86_64 targets
diff --git a/gas/testsuite/gas/pe/set.d b/gas/testsuite/gas/pe/set.d
new file mode 100644
index 0000000..99f2d5a
--- /dev/null
+++ b/gas/testsuite/gas/pe/set.d
@@ -0,0 +1,11 @@
+#nm: --defined-only
+#name: set directive in COFF
+#
+# Ensure that we stick an entry for the left hand side of a set directive
+# depending on the name of the left hand side.
+
+#...
+.* t _b
+#...
+.* T _d
+#...
diff --git a/gas/testsuite/gas/pe/set.s b/gas/testsuite/gas/pe/set.s
new file mode 100644
index 0000000..a19e797
--- /dev/null
+++ b/gas/testsuite/gas/pe/set.s
@@ -0,0 +1,9 @@
+L_a:
+.long 0
+
+_b = L_a
+
+L_c = L_a
+
+.globl _d
+_d = L_a