diff options
| author | Alan Modra <amodra@gmail.com> | 2019-07-09 12:27:55 +0930 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2019-07-09 14:30:00 +0930 |
| commit | d69cd47e7e9884f7b3a319936f70b8d93347e9e0 (patch) | |
| tree | 0f20c0314732be1cc380e0701b207e3176d6304b /gas/testsuite | |
| parent | 64da05d557f59814151e908a34f36996a027d127 (diff) | |
| download | gdb-d69cd47e7e9884f7b3a319936f70b8d93347e9e0.zip gdb-d69cd47e7e9884f7b3a319936f70b8d93347e9e0.tar.gz gdb-d69cd47e7e9884f7b3a319936f70b8d93347e9e0.tar.bz2 | |
Re: gas/ELF: don't accumulate .type settings
git commit f2d4ba38f5 caused many failures for mips-sgi-irix targets,
and added a new test that failed for aarch64, nds32, and rl78.
The mips failures are due to BSF_OBJECT being set in many cases for
symbols by the mips .global/.globl directive. This patch removes that
code and instead sets BSF_OBJECT in a target frob_symbol function,
also moving the mips hacks in elf_frob_symbol to the new function.
Note that common symbols are handled fine in elf.c:swap_out_syms
without needing to set BSF_OBJECT, so that old code can disappear.
* config/obj-elf.c (elf_frob_symbol): Remove mips hacks.
* config/tc-mips.h (tc_frob_symbol): Define.
(mips_frob_symbol): Declare.
* config/tc-mips.c (s_mips_globl): Don't set BSF_OBJECT for irix.
(mips_frob_symbol): Fudge symbols for irix here.
* testsuite/gas/elf/type-2.e: Allow random target symbols.
Diffstat (limited to 'gas/testsuite')
| -rw-r--r-- | gas/testsuite/gas/elf/type-2.e | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/gas/testsuite/gas/elf/type-2.e b/gas/testsuite/gas/elf/type-2.e index 684727c..57f2106 100644 --- a/gas/testsuite/gas/elf/type-2.e +++ b/gas/testsuite/gas/elf/type-2.e @@ -1,10 +1,20 @@ +.+: 0+0 +0 +NOTYPE +LOCAL +DEFAULT +UND * +#... +.+: 0+0 +0 +OBJECT +LOCAL +DEFAULT +. test1 +#... +.+: 0+1 +0 +FUNC +LOCAL +DEFAULT +. test2 +#... +.+: 0+2 +0 +NOTYPE +LOCAL +DEFAULT +. test3 +#... +.+: 0+3 +0 +NOTYPE +LOCAL +DEFAULT +. test4 +#... +.+: 0+4 +0 +NOTYPE +LOCAL +DEFAULT +. test5 +#... +.+: 0+5 +0 +NOTYPE +LOCAL +DEFAULT +. test6 +#... +.+: 0+6 +0 +OBJECT +LOCAL +DEFAULT +. test7 +#... +.+: 0+7 +0 +TLS +LOCAL +DEFAULT +. test8 +#... +.+: 0+8 +0 +IFUNC +LOCAL +DEFAULT +. test9 +#pass |