aboutsummaryrefslogtreecommitdiff
path: root/bfd
diff options
context:
space:
mode:
authorH.J. Lu <hjl.tools@gmail.com>2021-01-16 07:00:09 -0800
committerH.J. Lu <hjl.tools@gmail.com>2021-01-16 07:02:36 -0800
commit75a933f39918ce4f4b9481234992895e022787ee (patch)
treefc7399127a449f992c5b4e5009ab9aec0faa7c30 /bfd
parent68b007788a6cc5376708af42bc220f540e8c4b8a (diff)
downloadgdb-75a933f39918ce4f4b9481234992895e022787ee.zip
gdb-75a933f39918ce4f4b9481234992895e022787ee.tar.gz
gdb-75a933f39918ce4f4b9481234992895e022787ee.tar.bz2
ld/elf/x86: Don't compare IFUNC address in the shared object
On x86, glibc 2.33 starts to issue a fatal error message when calling IFUNC function defined in the unrelocated executable from a shared library. 1. Update x86 ELF linker to always convert IFUNC function defined in position-dependent executable (PDE) to the normal function. GOT in PDE will be updated by R_*_IRELATIVE at run-time. 2. Update PR ld/23169 tests not to compare function address of external IFUNC function in the shared object to avoid calling the IFUNC function defined in the unrelocated executable. 3. Remove pr23169e tests which call the IFUNC function defined in the unrelocated position-independent executable from a shared library. bfd/ PR ld/23169 * elfxx-x86.c (_bfd_x86_elf_link_fixup_ifunc_symbol): Don't check pointer_equality_needed. ld/ PR ld/23169 * testsuite/ld-ifunc/ifunc.exp: Replace pr23169c.rd with pr23169a.rd for pr23169c and pr23169f. Remove pr23169e tests. * testsuite/ld-ifunc/pr23169a.c (foo): Don't compare function address.
Diffstat (limited to 'bfd')
-rw-r--r--bfd/ChangeLog6
-rw-r--r--bfd/elfxx-x86.c3
2 files changed, 7 insertions, 2 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index ac18a85..dbb240a 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,9 @@
+2021-01-16 H.J. Lu <hongjiu.lu@intel.com>
+
+ PR ld/23169
+ * elfxx-x86.c (_bfd_x86_elf_link_fixup_ifunc_symbol): Don't
+ check pointer_equality_needed.
+
2021-01-15 H.J. Lu <hongjiu.lu@intel.com>
* elf-linker-x86.h (elf_linker_x86_params): Add
diff --git a/bfd/elfxx-x86.c b/bfd/elfxx-x86.c
index 8cda8d2..93ad38c 100644
--- a/bfd/elfxx-x86.c
+++ b/bfd/elfxx-x86.c
@@ -1711,8 +1711,7 @@ _bfd_x86_elf_link_fixup_ifunc_symbol (struct bfd_link_info *info,
&& h->def_regular
&& h->dynindx != -1
&& h->plt.offset != (bfd_vma) -1
- && h->type == STT_GNU_IFUNC
- && h->pointer_equality_needed)
+ && h->type == STT_GNU_IFUNC)
{
asection *plt_s;
bfd_vma plt_offset;