diff options
| author | Alan Modra <amodra@gmail.com> | 2018-04-27 09:42:11 +0930 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2018-05-04 18:58:23 +0930 |
| commit | 602f16570454a1597c2af28af66852133432d1f2 (patch) | |
| tree | ad3d519fce4dcf5bdf38e46fac6b0ee090784f53 /bfd/peXXigen.c | |
| parent | a27ca19c95ad3ebc5bd73f072facdd71b5a976ad (diff) | |
| download | gdb-602f16570454a1597c2af28af66852133432d1f2.zip gdb-602f16570454a1597c2af28af66852133432d1f2.tar.gz gdb-602f16570454a1597c2af28af66852133432d1f2.tar.bz2 | |
-Wstringop-truncation warnings
This patch is aimed at silencing gcc8 -Wstringop-truncation warnings.
Unfortunately adding __attribute__ ((__nonstring)) doesn't work in a
number of the places patched here, (see
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85643) so if you have
recent glibc headers installed you'll need to configure binutils with
--disable-werror to compile using gcc8 or gcc9.
include/
* ansidecl.h: Import from gcc.
* coff/internal.h (struct internal_scnhdr): Add ATTRIBUTE_NONSTRING
to s_name.
(struct internal_syment): Add ATTRIBUTE_NONSTRING to _n_name.
bfd/
* elf-linux-core.h (struct elf_external_linux_prpsinfo32_ugid32),
(struct elf_external_linux_prpsinfo32_ugid16),
(struct elf_external_linux_prpsinfo64_ugid32),
(struct elf_external_linux_prpsinfo64_ugid16): Add ATTRIBUTE_NONSTRING
to pr_fname and pr_psargs fields. Remove GCC diagnostic pragmas.
Move comment to..
* elf.c (elfcore_write_prpsinfo): ..here. Indent nested preprocessor
directives.
* elf32-arm.c (elf32_arm_nabi_write_core_note): Add ATTRIBUTE_NONSTRING
to data.
* elf32-ppc.c (ppc_elf_write_core_note): Likewise.
* elf32-s390.c (elf_s390_write_core_note): Likewise.
* elf64-s390.c (elf_s390_write_core_note): Likewise.
* elfxx-aarch64.c (_bfd_aarch64_elf_write_core_note): Likewise.
* elf64-x86-64.c (elf_x86_64_write_core_note): Add GCC diagnostic
pragmas.
* peXXigen.c (_bfd_XXi_swap_scnhdr_out): Use strnlen to avoid
false positive gcc-8 warning.
gas/
* config/obj-evax.c (shorten_identifier): Use memcpy in place
of strncpy.
* config/obj-macho.c (obj_mach_o_make_or_get_sect): Ensure
segname and sectname fields are NUL terminated.
Diffstat (limited to 'bfd/peXXigen.c')
| -rw-r--r-- | bfd/peXXigen.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/bfd/peXXigen.c b/bfd/peXXigen.c index 32ce195..a62d126 100644 --- a/bfd/peXXigen.c +++ b/bfd/peXXigen.c @@ -1051,9 +1051,10 @@ _bfd_XXi_swap_scnhdr_out (bfd * abfd, void * in, void * out) by ld --omagic, or by obcopy --writable-text. */ for (p = known_sections; p->section_name; p++) - if (strcmp (scnhdr_int->s_name, p->section_name) == 0) + if (strncmp (scnhdr_int->s_name, p->section_name, + sizeof scnhdr_int->s_name) == 0) { - if (strcmp (scnhdr_int->s_name, ".text") + if (strncmp (scnhdr_int->s_name, ".text", sizeof scnhdr_int->s_name) || (bfd_get_file_flags (abfd) & WP_TEXT)) scnhdr_int->s_flags &= ~IMAGE_SCN_MEM_WRITE; scnhdr_int->s_flags |= p->must_have; @@ -1066,7 +1067,7 @@ _bfd_XXi_swap_scnhdr_out (bfd * abfd, void * in, void * out) if (coff_data (abfd)->link_info && ! bfd_link_relocatable (coff_data (abfd)->link_info) && ! bfd_link_pic (coff_data (abfd)->link_info) - && strcmp (scnhdr_int->s_name, ".text") == 0) + && strncmp (scnhdr_int->s_name, ".text", sizeof scnhdr_int->s_name) == 0) { /* By inference from looking at MS output, the 32 bit field which is the combination of the number_of_relocs and |